Corryvreckan merge requestshttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests2023-11-30T11:29:18+01:00https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/663AlignmentDUT: Do not attempt to delete pointers because ROOT does it :/2023-11-30T11:29:18+01:00Simon SpannagelAlignmentDUT: Do not attempt to delete pointers because ROOT does it :/This fixes #186
(cc) @avauth @maantone fixed.This fixes #186
(cc) @avauth @maantone fixed.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/647DUTalignmet2023-10-12T16:13:15+02:00Lennart HuthDUTalignmetThe alignment module does not ensure that the tracks are on the sensors' active area and this causes a shift in residuals for the outer pixel ring, wich in turn results in a wrong alignment of the DUT. I checked the results of the test, ...The alignment module does not ensure that the tracks are on the sensors' active area and this causes a shift in residuals for the outer pixel ring, wich in turn results in a wrong alignment of the DUT. I checked the results of the test, which look alright after alignment.
@jbraach and @ruizdaza are cross-checking if everything works finehttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/662Remove Workarounds for RootMacros.cmake2023-11-24T13:34:41+01:00Simon SpannagelRemove Workarounds for RootMacros.cmakeRemoving the workaround that was necessary with ROOT versions below 6.20.
This fixes #82
@avauth @rprivara should fix your issues.Removing the workaround that was necessary with ROOT versions below 6.20.
This fixes #82
@avauth @rprivara should fix your issues.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/642Homebrew clang122023-10-10T15:58:15+02:00Lennart HuthHomebrew clang12It took me a while to figure out how to enable clang-format-12 in the git hooks, so I thought I'll share it with everyone.
The changed hook searches for `llvm@12` at the default home-brew install location and falls back to the systems ...It took me a while to figure out how to enable clang-format-12 in the git hooks, so I thought I'll share it with everyone.
The changed hook searches for `llvm@12` at the default home-brew install location and falls back to the systems versionhttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/638EtaCalculation: Limit Number of Histogram Bins2023-06-29T14:51:43+02:00Simon SpannagelEtaCalculation: Limit Number of Histogram Bins@naomi here you go.@naomi here you go.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/622Allow for short config file names in jobsub2023-04-04T19:48:51+02:00Fabian Simon LexAllow for short config file names in jobsubIn the current implementation the config and log file names contain all parameter names and values, which makes them very long. For some OS this can lead to `OSError: [Errno 36] File name too long:`. This merge request fixes this by allo...In the current implementation the config and log file names contain all parameter names and values, which makes them very long. For some OS this can lead to `OSError: [Errno 36] File name too long:`. This merge request fixes this by allowing for an abbreviated name consisting of the name of the config file + run number + ongoing number for each analysis with the same run number. Furthermore, error handling is improved such that an error in the creation of the config file is properly catched.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/601FilterEvents: Cut histogram filled correctly now2023-02-16T09:35:04+01:00Lennart HuthFilterEvents: Cut histogram filled correctly nowhttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/597AlignmentDUTResidual: ridefinition of residual2023-09-07T13:46:35+02:00Gianpiero VignolaAlignmentDUTResidual: ridefinition of residualImplemented the possibility of redefining residuals with any 2D TFormula with 'x' and 'y' representing `track intercepts` and the `cluster position` respectivelyImplemented the possibility of redefining residuals with any 2D TFormula with 'x' and 'y' representing `track intercepts` and the `cluster position` respectivelySimon SpannagelGianpiero VignolaSimon Spannagelhttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/593DUT Alignment: Tracks need to be refitted also for DUT2023-01-31T09:46:25+01:00Simon SpannagelDUT Alignment: Tracks need to be refitted also for DUT...otherwise the intersection point of track with DUT is wrong.
Solves #178...otherwise the intersection point of track with DUT is wrong.
Solves #178https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/592Tracking4D: add maps of global intersect position2023-01-24T20:39:25+01:00Simon SpannagelTracking4D: add maps of global intersect position@naomi is this useful to you?@naomi is this useful to you?https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/587Alibava: Changed StatusCode after time_cut to DeadTime2023-01-17T15:13:48+01:00Naomi Afiriyie DavisAlibava: Changed StatusCode after time_cut to DeadTimeInstead of returning the StatusCode NoData if an event doesn't fall in the selected time cut range, the StatusCode is changed to DeadTime. Subsequently, the remaining modules for this event are skipped rather than continuing with the nex...Instead of returning the StatusCode NoData if an event doesn't fall in the selected time cut range, the StatusCode is changed to DeadTime. Subsequently, the remaining modules for this event are skipped rather than continuing with the next module.
In this way, a loss of efficiency caused by the dead time of a detector can be reduced.
@lexhttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/584Adding a check if the new geometry could be written already at the start2022-12-15T14:13:46+01:00Lennart HuthAdding a check if the new geometry could be written already at the startThis closes #177. It duplicates a little bit of code, but I think it's worth it. Especially if you have a long alignment running :smile:This closes #177. It duplicates a little bit of code, but I think it's worth it. Especially if you have a long alignment running :smile:https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/544PointerWrapper in GblTrack2022-07-11T18:03:14+02:00David BacherPointerWrapper in GblTrackAs mentioned in !530, `seed_cluster_` in `GblTrack` is still a `TRef` even though it should be `PointerWrapper` after !485 which breaks the alignment with GBL tracks. This fixes this issue.As mentioned in !530, `seed_cluster_` in `GblTrack` is still a `TRef` even though it should be `PointerWrapper` after !485 which breaks the alignment with GBL tracks. This fixes this issue.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/538Track: no core includes in headers2022-07-04T10:35:33+02:00Simon SpannagelTrack: no core includes in headers...otherwise:
```
fatal error: 'core/utils/type.h' file not found
#include "core/utils/type.h"
```
in 3rdparty user code that tries to read Corry data files....otherwise:
```
fatal error: 'core/utils/type.h' file not found
#include "core/utils/type.h"
```
in 3rdparty user code that tries to read Corry data files.Simon SpannagelSimon Spannagelhttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/532Fix the warning from the same variable name with namespace Eigen2022-06-27T11:28:36+02:00Bong-Hwi LimFix the warning from the same variable name with namespace EigenThe general variable name `first` and `last` in the `GblTrack.cpp` is conflicting with the variable name in `Eigen`
This makes an error when it comes with the CMAKE flag `Werror` which is declared in the `gitlab-ci.yml`[1]
It would be ...The general variable name `first` and `last` in the `GblTrack.cpp` is conflicting with the variable name in `Eigen`
This makes an error when it comes with the CMAKE flag `Werror` which is declared in the `gitlab-ci.yml`[1]
It would be great if we can update the variable name and avoid the warning (error).
```
[ 10%] Building CXX object src/objects/CMakeFiles/CorryvreckanObjects.dir/GblTrack.cpp.o
[ 10%] Building CXX object src/objects/CMakeFiles/CorryvreckanObjects.dir/Pixel.cpp.o
[ 11%] Building CXX object src/objects/CMakeFiles/CorryvreckanObjects.dir/Track.cpp.o
[ 12%] Building CXX object src/objects/CMakeFiles/CorryvreckanObjects.dir/StraightLineTrack.cpp.o
[ 13%] Building CXX object src/objects/CMakeFiles/CorryvreckanObjects.dir/Event.cpp.o
[ 14%] Building CXX object src/objects/CMakeFiles/CorryvreckanObjects.dir/Multiplet.cpp.o
[ 14%] Building CXX object src/objects/CMakeFiles/CorryvreckanObjects.dir/CorryvreckanObjectsDictionary.cxx.o
/Users/blim/ITS/corryvreckan/src/objects/GblTrack.cpp:408:10: error: declaration shadows a variable in namespace 'Eigen' [-Werror,-Wshadow]
auto last = planes_.end();
^
/opt/homebrew/include/eigen3/Eigen/src/Core/util/IndexedViewHelper.h:38:64: note: previous declaration is here
static const symbolic::SymbolExpr<internal::symbolic_last_tag> last; // PLEASE use Eigen::last instead of Eigen::placeholders::last
^
1 error generated.
make[2]: *** [src/objects/CMakeFiles/CorryvreckanObjects.dir/GblTrack.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [src/objects/CMakeFiles/CorryvreckanObjects.dir/all] Error 2
make: *** [all] Error 2
```
[1] https://gitlab.cern.ch/corryvreckan/corryvreckan/-/blob/master/.gitlab-ci.yml#L28https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/505Suppress stderr of which in commit hook2022-02-02T16:39:20+01:00Simon SpannagelSuppress stderr of which in commit hook@msuljic@msuljichttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/449EventLoaderEUDAQ2: Allow to Veto Triggers2021-08-05T15:51:50+02:00Simon SpannagelEventLoaderEUDAQ2: Allow to Veto TriggersThis introduces a new parameter `veto_triggers` which - if enabled - will prevent additional trigger IDs to be added to the event.This introduces a new parameter `veto_triggers` which - if enabled - will prevent additional trigger IDs to be added to the event.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/443[AnalysisEfficiency]: Upper and lower error limits on the efficiencies2021-06-22T14:31:25+02:00Keerthi Nakkalil[AnalysisEfficiency]: Upper and lower error limits on the efficienciesThe error limits to the efficiencies are computed and displayed at 68% CL using the Clopper-Pearson statistic function within TEfficiency class.The error limits to the efficiencies are computed and displayed at 68% CL using the Clopper-Pearson statistic function within TEfficiency class.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/423AnalysisEfficiency: added parameter require_associated_cluster_on2021-05-20T22:17:51+02:00Sejla HadzicAnalysisEfficiency: added parameter require_associated_cluster_onI wanted to add a parameter similar to `require_detectors` in the `Tracking4D` module, but this time in the AnalysisEfficiency. The motivation is to have an option to perform the same analysis of our test-beam data with Corryvreckan as i...I wanted to add a parameter similar to `require_detectors` in the `Tracking4D` module, but this time in the AnalysisEfficiency. The motivation is to have an option to perform the same analysis of our test-beam data with Corryvreckan as it was done previously with TBmon2. Here `require_detectors` would contain a list of detectors for which it is required to have an associated cluster to the track.
Just for an example, we normally have two DUTs. For an efficiency measurement on DUT0 in Corryvreckan, I would include DUT1 in tracking and list it as `require_detectors` in the `Tracking4D` module. However, we would like to be able to perform track reconstruction using only telescope planes and select from them tracks for an efficiency measurement with an associated cluster on a required detector, even if that detector is not included in tracking. I did not find other way to do this in Corryvreckan up to now.
Maybe the name `require_detectors` should be changed.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/420WIP: EventLoaderEUDAQ: Added hitmaps2021-05-06T17:00:50+02:00Sejla HadzicWIP: EventLoaderEUDAQ: Added hitmapsI wanted to add hitmaps for the EventLoaderEUDAQ.
I thought it might be useful to be able to check them even before running any other module.I wanted to add hitmaps for the EventLoaderEUDAQ.
I thought it might be useful to be able to check them even before running any other module.