Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • Corryvreckan Corryvreckan
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 39
    • Issues 39
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 14
    • Merge requests 14
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CorryvreckanCorryvreckan
  • CorryvreckanCorryvreckan
  • Merge requests
  • !263

Split planar detector

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jin Zhang requested to merge split-planar-detector into master Mar 11, 2020
  • Overview 57
  • Commits 42
  • Pipelines 21
  • Changes 12

This MR is for #98 (step 1), in order to split the Detector to Detector as interface and PlanarDetector as the implementation of the Cartesian coordinate system.

The modules would not be changed much in this MR to avoid it too big.

The configuration of using PlanarDetector type would best be implemented in this branch, probably as

case(PlanarDetector) : std::shared_ptr<Detector> detector = std::make_shared<PlanarDetector> (detector_section) ;

Edited Mar 24, 2020 by Jin Zhang
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: split-planar-detector