Skip to content

Add track incident angles

Jens Kroeger requested to merge jekroege/corryvreckan:track_angles into master

Goal of this MR:

Implement histograms that show the track incident angle on each plane.

Currently, we only have a histogram for the track angle in the global reference frame (and only for straight-line, this makes no sense for GBL) and the kink angles at each plane for GBL.

Approach:

First, I thought it would be better to implement a new function getIncidentAngle() as part of the Track class:

track->getIncidentAngle(detector);

Started implementing that in:

But then I saw that the Track class doesn't know detector but only has the concepts of planes. And I need detector->rotation() to get the orientation angles. In turn, the Detector class already knows track, so it fits in more naturally like this:

detector->getIncidentAngle(track);

Please have a look at the current implementation and let me know what you think. Of coarse, some clean-up and testing is still necessary.

Edited by Jens Kroeger

Merge request reports