Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • Corryvreckan Corryvreckan
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 33
    • Issues 33
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Corryvreckan
  • CorryvreckanCorryvreckan
  • Merge requests
  • !373

Closed
Created Oct 13, 2020 by Jens Kroeger@jekroegeOwner
  • Report abuse
Report abuse

Add track incident angles

  • Overview 16
  • Commits 19
  • Pipelines 9
  • Changes 12

Goal of this MR:

Implement histograms that show the track incident angle on each plane.

Currently, we only have a histogram for the track angle in the global reference frame (and only for straight-line, this makes no sense for GBL) and the kink angles at each plane for GBL.

Approach:

First, I thought it would be better to implement a new function getIncidentAngle() as part of the Track class:

track->getIncidentAngle(detector);

Started implementing that in:

  • a493678a (reverted in edb88aa3)
  • e1837430 (reverted in bfa2c692)
  • 76c83f9a (reverted in 7246c8b3)
  • b0b67aab (reverted in 085dd694)

But then I saw that the Track class doesn't know detector but only has the concepts of planes. And I need detector->rotation() to get the orientation angles. In turn, the Detector class already knows track, so it fits in more naturally like this:

detector->getIncidentAngle(track);

Please have a look at the current implementation and let me know what you think. Of coarse, some clean-up and testing is still necessary.

Edited Oct 14, 2020 by Jens Kroeger
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: track_angles