Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • Corryvreckan Corryvreckan
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 39
    • Issues 39
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CorryvreckanCorryvreckan
  • CorryvreckanCorryvreckan
  • Merge requests
  • !450

Adding the option to write out the mask from MaskCreator, if no mask existed beforehand.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jens Dopke requested to merge jdopke/corryvreckan:MaskCreatorFileWriting into master Aug 02, 2021
  • Overview 7
  • Commits 2
  • Pipelines 2
  • Changes 7

First attempt at getting something into the main corry repo: MaskCreator always generates mask files, but without an initial mask file existing, it will not deliver an output config with a newly created mask file. Now integrated a parameter to allow the new config to be added into the configuration. In the process I moved Detector::set_mask_file(std::string file) to public namespace as Detector::maskFile(std::string file). I also changed the implementation of void PixelDetector::configure_detector(Configuration& config) const to look at m_maskfile rather than m_maskfile_name (which was only initialised, but otherwise never used - hence I now dropped that completely).

Apologies if this is a bit much... Reasonably sure I checked everything, also ran make format and all jobs ran fine.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: MaskCreatorFileWriting