Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • CTA CTA
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 123
    • Issues 123
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 15
    • Merge requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ctacta
  • CTACTA
  • Issues
  • #274
Closed
Open
Issue created Jan 19, 2023 by Joao Afonso@afonsoOwner

Remove unnecessary catalogue DB queries from QueueCleanupRunner

As part of the analysis done in https://gitlab.cern.ch/cta/operations/-/issues/967 / #155 (closed), we have found that a large part of the RdbmsCatalogue::getTapesByVid(...) queries come from QueueCleanupRunner::runOnePass(...).

Indeed, as we can see on QueueCleanupRunner.cpp#L45, RdbmsCatalogue::getTapesByVid(...) is being called for unnecessarily for every queue in the object store.

We only need to do it the flag queue.doCleanup is true. This alone should allow us to reduce the number of queries by a large amount.

There is already similar fix on main / 214f79ab for this (not released yet), but I will recreate it separately on release_4.8.3 so that we can have this isolated fix on v4.8.4-1.

Edited Jan 19, 2023 by Joao Afonso
Assignee
Assign to
Time tracking