Skip to content

Remove external dependecy on cpp-check CI test

Summary

Currently the cppcheck job in the CI is pulling a container from the docker registry managed by an individual person, https://github.com/neszt/cppcheck-docker the only thing this does is to build cppcheck from the main branch which might not be an official cppcheck release which could contain bugs and report false positives until it is fixed adding noise to our CI. It can also be a security vulnerability.

We should aim to use something more clean, i.e. installing cppcheck from the official repo or maybe cern soft provides containers with cppcheck(?), and use official release version. If the repos available in the distro in use do not provide this we could build from the latest tagged version.

Implemented Solution

Create this repo to generate the cpp check image: https://gitlab.cern.ch/cta/eoscta-operations/containers/cta-cppcheck . Not really a fan of having a repo per Dockerfile but that is what we are doing for now (https://gitlab.cern.ch/cta/eoscta-operations/containers).

Edited by Pablo Oliver Cortes