Skip to content

[CI] Fix new errors from cpp-check 2.15: `returnByReference`

cpp-check is reporting new errors after a version upgrade from 2.13 -> 2.14. For the time being and to unfreeze the CI I have added a supression for the returnByReference errors. They should be fixed.

The error a files are:

<?xml version="1.0" encoding="UTF-8"?>
<results version="2">
    <cppcheck version="2.15 dev"/>
    <errors>
        <error id="returnByReference" severity="performance" msg="Function &apos;get_help_text()&apos; should return member &apos;m_help_txt&apos; by const reference." verbose="Function &apos;get_help_text()&apos; should return member &apos;m_help_txt&apos; by const reference." file0="cmdline/CtaAdminCmdParse.cpp">
            <location file="cmdline/CtaAdminCmdParse.hpp" line="105" column="16"/>
        </error>
        <error id="returnByReference" severity="performance" msg="Function &apos;str()&apos; should return member &apos;m_trace&apos; by const reference." verbose="Function &apos;str()&apos; should return member &apos;m_trace&apos; by const reference." file0="common/exception/Backtrace.cpp">
            <location file="common/exception/Backtrace.hpp" line="28" column="15"/>
        </error>
        <error id="returnByReference" severity="performance" msg="Function &apos;token()&apos; should return member &apos;m_token&apos; by const reference." verbose="Function &apos;token()&apos; should return member &apos;m_token&apos; by const reference." file0="eos_grpc_client/GrpcClient.cpp">
            <location file="eos_grpc_client/GrpcClient.hpp" line="65" column="15"/>
        </error>
        <error id="returnByReference" severity="performance" msg="Function &apos;getCatalogueConnString()&apos; should return member &apos;m_catalogue_conn_string&apos; by const reference." verbose="Function &apos;getCatalogueConnString()&apos; should return member &apos;m_catalogue_conn_string&apos; by const reference." file0="frontend/common/FrontendService.cpp">
            <location file="frontend/common/FrontendService.hpp" line="46" column="15"/>
        </error>
        <error id="returnByReference" severity="performance" msg="Function &apos;getVerificationMountPolicy()&apos; should return member &apos;m_verificationMountPolicy&apos; by const reference." verbose="Function &apos;getVerificationMountPolicy()&apos; should return member &apos;m_verificationMountPolicy&apos; by const reference." file0="frontend/common/FrontendService.cpp">
            <location file="frontend/common/FrontendService.hpp" line="91" column="15"/>
        </error>
        <error id="returnByReference" severity="performance" msg="Function &apos;getNamespaceMap()&apos; should return member &apos;m_namespaceMap&apos; by const reference." verbose="Function &apos;getNamespaceMap()&apos; should return member &apos;m_namespaceMap&apos; by const reference." file0="frontend/common/FrontendService.cpp">
            <location file="frontend/common/FrontendService.hpp" line="96" column="23"/>
        </error>
        <error id="returnByReference" severity="performance" msg="Function &apos;token()&apos; should return member &apos;m_token&apos; by const reference." verbose="Function &apos;token()&apos; should return member &apos;m_token&apos; by const reference." file0="frontend/common/GrpcClient.cpp">
            <location file="frontend/common/GrpcClient.hpp" line="42" column="15"/>
        </error>
        <error id="returnByReference" severity="performance" msg="Function &apos;token()&apos; should return member &apos;m_strToken&apos; by const reference." verbose="Function &apos;token()&apos; should return member &apos;m_strToken&apos; by const reference." file0="frontend/grpc/ClientNegotiationRequestHandler.cpp">
            <location file="frontend/grpc/ClientNegotiationRequestHandler.hpp" line="41" column="28"/>
        </error>
        <error id="returnByReference" severity="performance" msg="Function &apos;user()&apos; should return member &apos;m_user&apos; by const reference." verbose="Function &apos;user()&apos; should return member &apos;m_user&apos; by const reference." file0="objectstore/BackendFactory.cpp">
            <location file="objectstore/BackendRados.hpp" line="51" column="15"/>
        </error>
        <error id="returnByReference" severity="performance" msg="Function &apos;pool()&apos; should return member &apos;m_pool&apos; by const reference." verbose="Function &apos;pool()&apos; should return member &apos;m_pool&apos; by const reference." file0="objectstore/BackendFactory.cpp">
            <location file="objectstore/BackendRados.hpp" line="54" column="15"/>
        </error>
        <error id="returnByReference" severity="performance" msg="Function &apos;getPath()&apos; should return member &apos;m_path&apos; by const reference." verbose="Function &apos;getPath()&apos; should return member &apos;m_path&apos; by const reference." file0="objectstore/BackendFactory.cpp">
            <location file="objectstore/BackendVFS.hpp" line="198" column="17"/>
        </error>
        <error id="returnByReference" severity="performance" msg="Function &apos;getRAOAlgorithmName()&apos; should return member &apos;m_raoAlgorithmName&apos; by const reference." verbose="Function &apos;getRAOAlgorithmName()&apos; should return member &apos;m_raoAlgorithmName&apos; by const reference." file0="tapeserver/castor/tape/tapeserver/RAO/ConfigurableRAOAlgorithmFactory.cpp">
            <location file="tapeserver/castor/tape/tapeserver/RAO/RAOParams.hpp" line="64" column="15"/>
        </error>
        <error id="returnByReference" severity="performance" msg="Function &apos;getFilePositionInfos()&apos; should return member &apos;m_filePositionInfos&apos; by const reference." verbose="Function &apos;getFilePositionInfos()&apos; should return member &apos;m_filePositionInfos&apos; by const reference." file0="tapeserver/castor/tape/tapeserver/RAO/ConfigurableRAOAlgorithmFactory.cpp">
            <location file="tapeserver/castor/tape/tapeserver/RAO/RAOFile.hpp" line="47" column="21"/>
        </error>
        <error id="returnByReference" severity="performance" msg="Function &apos;getOptionsString()&apos; should return member &apos;m_options&apos; by const reference." verbose="Function &apos;getOptionsString()&apos; should return member &apos;m_options&apos; by const reference." file0="tapeserver/castor/tape/tapeserver/RAO/RAOOptions.cpp">
            <location file="tapeserver/castor/tape/tapeserver/RAO/RAOOptions.hpp" line="79" column="15"/>
        </error>
        <error id="returnByReference" severity="performance" msg="Function &apos;getRAOAlgorithmOptions()&apos; should return member &apos;m_raoAlgorithmOptions&apos; by const reference." verbose="Function &apos;getRAOAlgorithmOptions()&apos; should return member &apos;m_raoAlgorithmOptions&apos; by const reference." file0="tapeserver/castor/tape/tapeserver/RAO/SLTFRAOAlgorithm.cpp">
            <location file="tapeserver/castor/tape/tapeserver/RAO/RAOParams.hpp" line="68" column="14"/>
        </error>
        <error id="returnByReference" severity="performance" msg="Function &apos;path()&apos; should return member &apos;m_path&apos; by const reference." verbose="Function &apos;path()&apos; should return member &apos;m_path&apos; by const reference." file0="tests/TempFile.cpp">
            <location file="tests/TempFile.hpp" line="31" column="15"/>
        </error>
    </errors>
</results>
Edited by Pablo Oliver Cortes