1. 02 Mar, 2020 16 commits
  2. 01 Mar, 2020 16 commits
    • Adam Edward Barton's avatar
      Merge branch 'attrList.TrigT1CaloCondSvc-20200229' into 'master' · 349bef3b
      Adam Edward Barton authored
      TrigT1CaloCondSvc: Avoid AttributeList copies.
      
      See merge request atlas/athena!30748
      349bef3b
    • Adam Edward Barton's avatar
      Merge branch 'attrList.TrigT1CaloCalibUtils-20200229' into 'master' · 978e34d5
      Adam Edward Barton authored
      TrigT1CaloCalibUtils: Avoid copying AttributeList.
      
      See merge request atlas/athena!30747
      978e34d5
    • Adam Edward Barton's avatar
      Merge branch 'attrList.TrigConfigSvc-20200229' into 'master' · 30f997da
      Adam Edward Barton authored
      TrigConfigSvc: Avoid copying coral::AttributeList.
      
      See merge request atlas/athena!30746
      30f997da
    • scott snyder's avatar
      xAODCaloEventCnv: Making setSignalState non-const. · de5250fa
      scott snyder authored
      Change the ISignalState::setSignalState and resetSignalState methods
      to be (properly!) non-const.  SignalStateHelper now takes a non-const
      pointer to the object.  (Temporarily?) introduce SignalStateConstHelper
      that takes a const pointer and does a const_cast on it; this is marked
      as not thread-safe.
      
      Remove now-unused SignalStateCollHelper.
      
      Corresponding changes downstream.
      de5250fa
    • scott snyder's avatar
      ParticleEvent: Making setSignalState non-const. · 0e309916
      scott snyder authored
      Change the ISignalState::setSignalState and resetSignalState methods
      to be (properly!) non-const.  SignalStateHelper now takes a non-const
      pointer to the object.  (Temporarily?) introduce SignalStateConstHelper
      that takes a const pointer and does a const_cast on it; this is marked
      as not thread-safe.
      
      Remove now-unused SignalStateCollHelper.
      
      Corresponding changes downstream.
      0e309916
    • scott snyder's avatar
      JetD3PDMaker: Making setSignalState non-const. · 779d8f7e
      scott snyder authored
      Change the ISignalState::setSignalState and resetSignalState methods
      to be (properly!) non-const.  SignalStateHelper now takes a non-const
      pointer to the object.  (Temporarily?) introduce SignalStateConstHelper
      that takes a const pointer and does a const_cast on it; this is marked
      as not thread-safe.
      
      Remove now-unused SignalStateCollHelper.
      
      Corresponding changes downstream.
      779d8f7e
    • scott snyder's avatar
      D2PDMaker: Making setSignalState non-const. · cb1539e3
      scott snyder authored
      Change the ISignalState::setSignalState and resetSignalState methods
      to be (properly!) non-const.  SignalStateHelper now takes a non-const
      pointer to the object.  (Temporarily?) introduce SignalStateConstHelper
      that takes a const pointer and does a const_cast on it; this is marked
      as not thread-safe.
      
      Remove now-unused SignalStateCollHelper.
      cb1539e3
    • scott snyder's avatar
      JetEvent: Making setSignalState non-const. · 33c32bd1
      scott snyder authored
      Change the ISignalState::setSignalState and resetSignalState methods
      to be (properly!) non-const.  SignalStateHelper now takes a non-const
      pointer to the object.  (Temporarily?) introduce SignalStateConstHelper
      that takes a const pointer and does a const_cast on it; this is marked
      as not thread-safe.
      
      Remove now-unused SignalStateCollHelper.
      
      Corresponding changes downstream.
      33c32bd1
    • scott snyder's avatar
      CaloEvent: Making setSignalState non-const. · b10a3b8c
      scott snyder authored
      Change the ISignalState::setSignalState and resetSignalState methods
      to be (properly!) non-const.  SignalStateHelper now takes a non-const
      pointer to the object.  (Temporarily?) introduce SignalStateConstHelper
      that takes a const pointer and does a const_cast on it; this is marked
      as not thread-safe.
      
      Remove now-unused SignalStateCollHelper.
      
      Corresponding changes downstream.
      b10a3b8c
    • scott snyder's avatar
      EventKernel: Making setSignalState non-const. · 46798539
      scott snyder authored
      Change the ISignalState::setSignalState and resetSignalState methods
      to be (properly!) non-const.  SignalStateHelper now takes a non-const
      pointer to the object.  (Temporarily?) introduce SignalStateConstHelper
      that takes a const pointer and does a const_cast on it; this is marked
      as not thread-safe.
      
      Remove now-unused SignalStateCollHelper.
      
      Corresponding changes downstream.
      46798539
    • scott snyder's avatar
      AthenaPoolMultiTest: Avoid AttributeList copy. · 105374ac
      scott snyder authored
      Copying an AttributeList is potentially not thread-safe.
      Fix an instance of that here (which was also a memory leak!).
      105374ac
    • scott snyder's avatar
      OutputStreamAthenaPool: Avoid AttributeList copies. · 13f95f20
      scott snyder authored
      Pending thread-safety checker changes warn about potentially unsafe
      copies of coral::AttributeList.  Avoid that here.
      13f95f20
    • scott snyder's avatar
      RDBAccessSvc: Avoid directly AttributeList copy. · a604661c
      scott snyder authored
      Copying an AttributeList may not be thread-safe.
      
      Rewrite a copy here to avoid any sharing between the original
      and the copy, to try to avoid thread-safety problems.
      a604661c
    • scott snyder's avatar
      xAODCore: Fix undefined shift. · dae7180d
      scott snyder authored
      If m_mantissaBits is 23, then the shift here
      
      ```
            m_rounding = 0x1 << ( 32 - (1 + 8 + m_mantissaBits) - 1 );
      ```
      
      is -1.  This is undefined and gets an ubsan warning.
      
      Try to fix.
      dae7180d
    • scott snyder's avatar
      LArRecUtils: Python 3 / flake8 fixes · 8dff850c
      scott snyder authored
          
      Update to work with python 3.
          
      Also add flake8 checking and fix warnings.
      8dff850c
    • scott snyder's avatar
      LArBadChannelTool: Python 3 / flake8 fixes · fe5b9431
      scott snyder authored
          
      Update to work with python 3.
          
      Also add flake8 checking and fix warnings.
      fe5b9431
  3. 29 Feb, 2020 8 commits