GitLab

Bug fix for ITk seeding algorithm

See merge request !53737

Noemi Calace authored May 28, 2022 and Adam Edward Barton committed May 28, 2022

Bug fix for ITk seeding algorithm

WorkflowTestRunner: Documentation fix.

See merge request !53749

Scott Snyder authored May 28, 2022 and Adam Edward Barton committed May 28, 2022

WorkflowTestRunner: Documentation fix.

Fix documentation of the --exclusion-lists option to match what the code
actually does.

LArGeoEndcap: switched to the updated interface of IRDBRecord::getString()

See merge request !53755

Vakhtang Tsulaia authored May 28, 2022 and Adam Edward Barton committed May 28, 2022

LArGeoEndcap: switched to the updated interface of IRDBRecord::getString()

Use const references to string to avoid unnecessary copies

CoolConvUtilities: python3 fix

See merge request !53747

Scott Snyder authored May 28, 2022 and Adam Edward Barton committed May 28, 2022

CoolConvUtilities: python3 fix

Missing string->bytes conversion.

AthenaServices: Fix race in AthTPCnvSvc.

See merge request !53751

Scott Snyder authored May 28, 2022 and Adam Edward Barton committed May 28, 2022

AthenaServices: Fix race in AthTPCnvSvc.

Fix potential race in AthTPCnvSvc.
See ATR-25049.

RoiDescriptor: Fix linking in dbg build.

See merge request !53750

Scott Snyder authored May 28, 2022 and Adam Edward Barton committed May 28, 2022

RoiDescriptor: Fix linking in dbg build.

A static const class member needs to have a separate definition, even if it's
initialized inline.  (c++17 [12.2.3.2 class.static.data] para 3).
Can avoid this by declaring it instead as constexpr.
Fixes HLTSeeding link failure in the dbg build.

Daily "22.0 to master" sweep: 27/05/22

See merge request !53743

Fix the tier 0 tag and probe analyses

See merge request atlas/athena!53739

Mark Sutton authored May 27, 2022 and Adam Edward Barton committed May 27, 2022

Fix the tier 0 tag and probe analyses

The chain decodeing was not working correctly. This fixes that and includes
some aditional small code tidy up

PanTauAlgs minor fixes

See merge request atlas/athena!53714

Bertrand Martin Dit Latour authored May 27, 2022 and Julien Maurer committed May 27, 2022

PanTauAlgs minor fixes

Hello,

This MR is improving a few things: pass by reference instead of value, drop const_cast (the easy ones, there are still some to be removed), make code a bit more readable.
The reconstruction output is unchanged. Targets 22.0 as the goal is ultimately to make the corresponding algorithm re-entrant for Run3 reco.

Cheers,
Bertrand

r22 JetTagging: label_suspect_red

See merge request atlas/athena!53717

Alessandro Lapertosa authored May 27, 2022 and Julien Maurer committed May 27, 2022

r22 JetTagging: label_suspect_red

tauRec: don't call tool finalize from within algorithm, and use smart pointers...

See merge request atlas/athena!53722

Bertrand Martin Dit Latour authored May 27, 2022 and Julien Maurer committed May 27, 2022

tauRec: don't call tool finalize from within algorithm, and use smart pointers in PanTau to avoid delete in finalize

Hello,

With this MR, we no longer manually call the finalize method of tau tools from within tau algorithms, we let Athena do it (discussed in !50531 (comment 5338603), possibly relevant for ATLASRECTS-7047 too?).
Besides, now, we no longer do anything in tool finalize.
This is achieved by replacing raw pointers with smart pointers in PanTau.
We no longer use the MVAUtils BDT method that relies on a vector of float pointers, we use a vector of floats (possibly lighter for memory).
We no longer use variable caching to evaluate BDTs in PanTau, making one more step towards re-entrancy.
`PanTau::Tool_ModeDiscriminator::getResponse` can't be turned to `const` yet, but we're getting close...

The MR does not change the reconstruction output.

Cheers,
Bertrand

Minor fixes for HLTbphys T0 DQ web display config

See merge request atlas/athena!53723

Semen Turchikhin authored May 27, 2022 and Julien Maurer committed May 27, 2022

Minor fixes for HLTbphys T0 DQ web display config

Update sTGC digitization to keep pad and wire charge

See merge request atlas/athena!53734

Chav Chhiv Chau authored May 27, 2022 and Julien Maurer committed May 27, 2022

Update sTGC digitization to keep pad and wire charge

AthenaCommon: Don't pass exctrace preload to subprocesses.

See merge request atlas/athena!53730

Scott Snyder authored May 27, 2022 and Julien Maurer committed May 27, 2022

AthenaCommon: Don't pass exctrace preload to subprocesses.

AthenaCommon: Don't pass exctrace preload to subprocesses.

Non-athena jobs may not work correctly with exctrace.
Remove it from the preload list for subprocesses.

See ATR-25610.

bugfix in eFexEMRoI Wstot calculation

See merge request atlas/athena!53719

Luke Baines authored May 27, 2022 and Sara Alderweireldt committed May 27, 2022

bugfix in eFexEMRoI Wstot calculation

sTGC Strip Trigger:  Fixed the scattered point segment finding inefficiencies

See merge request atlas/athena!53292

Yi Yu authored May 27, 2022 and Sara Alderweireldt committed May 27, 2022

sTGC Strip Trigger:  Fixed the scattered point segment finding inefficiencies

TriggerJobOpts: roll back to v5 global conditions tag in HLT for Run3 MC

See merge request atlas/athena!53735

Bertrand Martin Dit Latour authored May 27, 2022 and Sara Alderweireldt committed May 27, 2022

TriggerJobOpts: roll back to v5 global conditions tag in HLT for Run3 MC

Hello,

This MR is temporarily changing the global conditions tag used by default in the HLT for Run3 MC, due to an incompatibility between MC21 RDO used in trigger ART tests and v6 MDT conditions (ATR-25570).
It would be great if this MR could be merged asap to avoid interferences with upcoming MRs changing trigger counts.

Cheers,
Bertrand

AsgAnalysisInterfaces+EgammaAnalysisInterfaces: Enable thread-safety checking.

See merge request !53729

MuonAnalysisInterfaces: Enable thread-safety checking.

See merge request !53728

TrigT1CaloEvent: Fix cppcheck warnings.

See merge request !53727

EGammaVariableCorrection: cmake fix

See merge request !53726

LArGeoBarrel: minor code cleanup

See merge request !53731