Da Yu Tou (e0b1d21c) at 29 Mar 03:41
Added sync threads to ensure shared memory is synchronized before u...
... and 2 more commits
Da Yu Tou (1f001b15) at 28 Mar 10:55
Revereted accidental change to wrong branch.
Da Yu Tou (1dbfad1b) at 28 Mar 10:51
Used shared atomics in UT calculate number of hits.
Hi @hawu I just noticed that those are DIGI, not XDIGI samples. The test @cagapopo and I was referring to needs MC hit. I'll split that test into two:
and I'll come back to you on this in Allen!1444.
What are the DDDB and CondDDDB tags for these samples? I'll add the sample to PRConfig.
Done, I also changed max strip size default to 128. I did the same to Allen as well.
Da Yu Tou (81f4f0c7) at 27 Mar 03:48
Updated UT cluster size default to 128.
Da Yu Tou (e8fdf338) at 27 Mar 03:47
Changed UT clustering default to ADC weighting and stripMax of 128.
@hawu Maybe we can combine !3225 (closed) into this MR (or we combine my changes to !3225 (closed), doesn't matter)? I added the stripMax option to HLT2 decoding, so a small chance we get a merge conflict.
Once we combine the Moore MR, we can merge it then together with Allen!1444 and Rec!3838.
The geometry table should be indexed differently in Allen vs in HLT2. @jzhuo can correct me but he fixed the Allen UT geometry issue end of last year by rearranging the HLT2 table in Allen, so it will be ordered differently in HLT1 vs HLT2. This should not matter as long as Allen calculates the correct geometry table indices.
If you put the private sample somewhere @hawu I can test it locally with the updated test from Allen!1444.
Currently, that test does not directly compare hits between HLT1 and HLT2. However, Allen!1444 would modify this test to make sure UT decoding is the same between HLT1 and HLT2 but I am waiting for Moore!2907 and related MR to update the MC samples to newer ones.
@hawu We can add another test using the same script but using your new sample as input. Can we add this sample to RTA's EOS area @cagapopo?