diff --git a/Tracking/Acts/FaserActsKalmanFilter/src/CKF2.cxx b/Tracking/Acts/FaserActsKalmanFilter/src/CKF2.cxx index 1bdb46e54bfe78763f8f65abb49132cbc0073109..77dffaa07ee26ea2743a904480c553619a7b160b 100644 --- a/Tracking/Acts/FaserActsKalmanFilter/src/CKF2.cxx +++ b/Tracking/Acts/FaserActsKalmanFilter/src/CKF2.cxx @@ -252,11 +252,11 @@ StatusCode CKF2::execute() { ATH_MSG_WARNING("No fitted parameters at target position" << targetZposition); } - std::unique_ptr<Trk::Track> trk = m_createTrkTrackTool->createTrack(gctx, track, fittedParams, m_backwardPropagation); + std::unique_ptr<Trk::Track> trk = std::move(m_createTrkTrackTool->createTrack(gctx, track, fittedParams, m_backwardPropagation)); m_numberOfSelectedTracks++; //@todo: make the KF refit configurable - std::unique_ptr<Trk::Track> trk2 = m_kalmanFitterTool1->fit( - ctx, gctx, trk.get(), Acts::BoundVector::Zero(), m_isMC); + std::unique_ptr<Trk::Track> trk2 = std::move(m_kalmanFitterTool1->fit( + ctx, gctx, trk.get(), Acts::BoundVector::Zero(), m_isMC)); if (trk2 != nullptr) { outputTracks->push_back(std::move(trk2)); } else { diff --git a/Tracking/Acts/FaserActsKalmanFilter/src/KalmanFitterTool.cxx b/Tracking/Acts/FaserActsKalmanFilter/src/KalmanFitterTool.cxx index 380edcd19d76e544fe08ae8694e4232e68f4ea6e..6971ae7a47e6f41c39087a70d9ee90b5207d29cc 100644 --- a/Tracking/Acts/FaserActsKalmanFilter/src/KalmanFitterTool.cxx +++ b/Tracking/Acts/FaserActsKalmanFilter/src/KalmanFitterTool.cxx @@ -346,12 +346,12 @@ KalmanFitterTool::fit(const EventContext &ctx, const Acts::GeometryContext &gctx std::unique_ptr<Trk::Track> newTrack = nullptr; if (!inputTrack->measurementsOnTrack() || inputTrack->measurementsOnTrack()->size() < m_minMeasurements) { - ATH_MSG_DEBUG("Input track has no or too little measurements and cannot be fitted"); + ATH_MSG_WARNING("Input track has only " << inputTrack->measurementsOnTrack()->size() <<" measurements and cannot be fitted"); return nullptr; } if (!inputTrack->trackParameters() || inputTrack->trackParameters()->empty()) { - ATH_MSG_DEBUG("Input track has no track parameters and cannot be fitted"); + ATH_MSG_WARNING("Input track has no track parameters and cannot be fitted"); return nullptr; } @@ -420,8 +420,11 @@ KalmanFitterTool::fit(const EventContext &ctx, const Acts::GeometryContext &gctx //} else { // ATH_MSG_DEBUG("No fitted parameters for track"); //} - newTrack = m_createTrkTrackTool->createTrack(gctx, track); - } + newTrack = std::move(m_createTrkTrackTool->createTrack(gctx, track)); + } else { + ATH_MSG_WARNING("Fit failed for parameters starting at " << trackParameters.position(gctx).transpose() <<" and " << actsSls.size() <<" measurements with error" << result.error()); + } + if (m_statesWriter && !m_noDiagnostics) { StatusCode statusStatesWriterTool = m_trajectoryStatesWriterTool->write(gctx, tracks, isMC); @@ -430,7 +433,7 @@ KalmanFitterTool::fit(const EventContext &ctx, const Acts::GeometryContext &gctx StatusCode statusSummaryWriterTool = m_trajectorySummaryWriterTool->write(gctx, tracks, isMC); } - return newTrack; + return std::move(newTrack); }