I sensed that too... hope the updated code works better. I don't need to modify the flag for the standard overlay now.
Hi @tstreble I just found that with the fixes introduced in this MR, we need an additional change for the standard overlay. Without this modification, an error occurs, specifically
AttributeError: No such flag: TrackOverlay.ActiveConfig
lactated in the InDetPrepRawDataFormationConfig.py on line 40 (and presumably others). Please have a look again and see if this makes sense. Thank you!!
Jenkins please retry a build
The method I retrieve the TrackOverlay attributes is no longer working since last week. This doTrackOverlay flag is always False, so all events were sent to the MC-overlay in the hybrid approach:
The replacement ensures that the configuration is correctly set for the Track overlay workflow, and leads to a more reasonable CPU usage.
(13% of events were sent to track overlay here. Higher mu is more populated in the events I ran This percentage can increase with more events being run.)
I don't know if I'm the right person to modify this. For this kind of cleanup, I think you should open a JIRA or something.
Sorry, what do you mean? These are already in the header file.
Jenkins please retry a build
Okay, thanks Nick.
I'd close it for now unless you have more comments. I think it's a good task for a QT to check on performance (who has been assigned) and he should take care of this work.
I knew... you're following the rules correctly. It's ok we can keep it on main.