Skip to content

Use unique pointers for EventContexts

Benjamin Michael Wynne requested to merge bwynne/Gaudi_gaudi:ContextUniquePointer into master

Addressing #37 (closed)

EventContext pointers passed to the scheduler for sub-slot scheduling aren't deleted reliably. Switch to using unique pointers in the interface, and storing unique pointers for contexts within EventSlots.

Includes changes from !730 (closed) that reduced the use of EventContext pointers

Part of a larger overhaul of sub-slot scheduling including !727 (merged) and !729 (merged)

Could go further, and convert scheduler interface to use unique pointers only, but that would be a larger-scale change. Could also reduce passing of EventContext pointers between scheduler methods, like !727 (merged) but going further.

Edited by Benjamin Michael Wynne

Merge request reports