Misc fixes for GaudiMP

• improvements to GaudiMP::TESSerializer::dumpBuffer
  • simplified the loop over the objects to serialize, correctly ignoring those that do not have a dictionary.
• restore (some) non re-entrant interfaces in GaudiPython
• fix crash when FSR contains a non-KeyedContainer

Closes #87 (closed) #75 (closed)

changed milestone to %v32r2

added bug fix label

@sponce, can you check if this fixes LHCBGAUSS-1781?

FYI: @valassi, @gcorti

• [2019-09-19 18:02] Validation started with lhcb-gaudi-merge#823
• [2019-09-19 18:31] Validation started with lhcb-test-throughput2#13
• [2019-09-19 21:17] Validation started with lhcb-test-throughput2#14
• [2019-09-19 23:16] Validation started with lhcb-test-throughput2#15
• [2019-09-20 00:03] Validation started with lhcb-gaudi-head-py3#181
• [2019-09-20 00:04] Validation started with lhcb-lcg-dev4#1036
• [2019-09-20 00:04] Validation started with lhcb-sanitizers#376
• [2019-09-20 00:05] Validation started with lhcb-lcg-dev3#1026
• [2019-09-20 00:05] Validation started with lhcb-dd4hep#323
• [2019-09-20 00:05] Validation started with lhcb-test-throughput2#157
• [2019-09-20 00:09] Validation started with lhcb-run2-patches-dev4#84
• [2019-09-20 00:09] Validation started with lhcb-tdr-test#679
• [2019-09-20 00:09] Validation started with lhcb-gaudi-head#2392
• [2019-09-20 08:42] Validation started with lhcb-test-throughput2#16
• [2019-09-20 08:57] Validation started with lhcb-test-throughput2#17
• [2019-09-20 09:34] Validation started with lhcb-test-throughput2#18
• [2019-09-20 10:09] Validation started with lhcb-test-throughput2#19
• [2019-09-20 10:20] Validation started with lhcb-test-throughput2#20
• [2019-09-20 10:57] Validation started with lhcb-test-throughput2#21
• [2019-09-20 11:11] Validation started with lhcb-test-throughput2#22
• [2019-09-20 11:27] Validation started with lhcb-test-throughput2#23
• [2019-09-20 11:37] Validation started with lhcb-test-throughput2#24
• [2019-09-20 13:05] Validation started with lhcb-test-throughput2#25
• [2019-09-20 13:18] Validation started with lhcb-test-throughput2#26
• [2019-09-20 13:32] Validation started with lhcb-test-throughput2#27
• [2019-09-20 14:21] Validation started with lhcb-test-throughput2#28
• [2019-09-20 14:40] Validation started with lhcb-test-throughput2#29
• [2019-09-20 16:24] Validation started with lhcb-test-throughput2#30
• [2019-09-20 16:28] Validation started with lhcb-test-throughput2#31
• [2019-09-21 00:03] Validation started with lhcb-gaudi-head-py3#182
• [2019-09-21 00:03] Validation started with lhcb-lcg-dev4#1037
• [2019-09-21 00:03] Validation started with lhcb-lcg-dev3#1027
• [2019-09-21 00:03] Validation started with lhcb-sanitizers#377
• [2019-09-21 00:04] Validation started with lhcb-test-throughput2#158
• [2019-09-21 00:05] Validation started with lhcb-dd4hep#324
• [2019-09-21 00:07] Validation started with lhcb-tdr-test#680
• [2019-09-21 00:08] Validation started with lhcb-run2-patches-dev4#85
• [2019-09-21 00:11] Validation started with lhcb-gaudi-head#2393
• [2019-09-22 00:03] Validation started with lhcb-dd4hep#325
• [2019-09-22 00:03] Validation started with lhcb-gaudi-head-py3#183
• [2019-09-22 00:03] Validation started with lhcb-gaudi-head#2394
• [2019-09-22 00:03] Validation started with lhcb-lcg-dev3#1028
• [2019-09-22 00:04] Validation started with lhcb-lcg-dev4#1038
• [2019-09-22 00:04] Validation started with lhcb-sanitizers#378
• [2019-09-22 00:04] Validation started with lhcb-test-throughput2#159
• [2019-09-22 00:05] Validation started with lhcb-tdr-test#681
• [2019-09-22 00:08] Validation started with lhcb-run2-patches-dev4#86
• [2019-09-22 00:24] Validation started with lhcb-coverity#473
• [2019-09-23 00:03] Validation started with lhcb-gaudi-head-py3#184
• [2019-09-23 00:03] Validation started with lhcb-dd4hep#326
• [2019-09-23 00:03] Validation started with lhcb-lcg-dev3#1029
• [2019-09-23 00:04] Validation started with lhcb-sanitizers#379
• [2019-09-23 00:04] Validation started with lhcb-test-throughput2#160
• [2019-09-23 00:05] Validation started with lhcb-tdr-test#682
• [2019-09-23 00:05] Validation started with lhcb-gaudi-head#2395
• [2019-09-23 00:07] Validation started with lhcb-lcg-dev4#1039
• [2019-09-23 00:11] Validation started with lhcb-run2-patches-dev4#87
• [2019-09-23 16:47] Validation started with lhcb-dd4hep#327
• [2019-09-24 00:04] Validation started with lhcb-lcg-dev3#1030
• [2019-09-24 00:04] Validation started with lhcb-lcg-dev4#1040
• [2019-09-24 00:04] Validation started with lhcb-sanitizers#380
• [2019-09-24 00:04] Validation started with lhcb-test-throughput2#161
• [2019-09-24 00:08] Validation started with lhcb-run2-patches-dev4#88
• [2019-09-24 00:25] Validation started with lhcb-lcg-dev4#1040
• [2019-09-24 00:26] Validation started with lhcb-lcg-dev3#1030
• [2019-09-24 00:28] Validation started with lhcb-gaudi-head#2396
• [2019-09-24 01:23] Validation started with lhcb-gaudi-head-py3#185
• [2019-09-24 01:43] Validation started with lhcb-tdr-test#683
• [2019-09-24 03:12] Validation started with lhcb-dd4hep#328
• [2019-09-24 11:45] Validation started with lhcb-gaudi-head-py3#186
• [2019-09-24 11:49] Validation started with lhcb-gaudi-head-py3#187
• [2019-09-24 15:35] Validation started with lhcb-gaudi-head-py3#188
• [2019-09-25 00:02] Validation started with lhcb-gaudi-head-py3#189
• [2019-09-25 00:03] Validation started with lhcb-lcg-dev3#1031
• [2019-09-25 00:03] Validation started with lhcb-lcg-dev4#1041
• [2019-09-25 00:04] Validation started with lhcb-sanitizers#381
• [2019-09-25 00:04] Validation started with lhcb-test-throughput2#162
• [2019-09-25 00:08] Validation started with lhcb-run2-patches-dev4#89
• [2019-09-25 00:08] Validation started with lhcb-dd4hep#329
• [2019-09-25 00:10] Validation started with lhcb-gaudi-head#2397
• [2019-09-25 00:10] Validation started with lhcb-tdr-test#684

added 1 commit

• e7f7c6a2 - Remove reference to ICondDBReader in GMPBase

Compare with previous version

added 8 commits

• e7f7c6a2...06b53b72 - 4 commits from branch gaudi:master
• 6308b63e - Improvements to GaudiMP::TESSerializer::dumpBuffer
• da4ff18d - Remove reference to ICondDBReader in GMPBase
• 710844c5 - non-reentrant interfaces for GaudiPython
• a22f5c27 - GaudiMP: allow non KeyedContainer objects in FSR (ignored)

Compare with previous version

changed title from Improvements to GaudiMP::TESSerializer::dumpBuffer to Misc fixes for GaudiMP

changed the description

I tested these changes with Gauss from the lhcb-gaudi-head nightly slot.

I manage to get to the end of the processing, even though the workers hang there...

Ciao Marco, thanks a lot! Sorry no time now (and away for 1+ weeks). For the GaudiMP hanging, try disabling the stalled monitoring (LHCBGAUSS-1409) Andrea

Thanks for the tip. The hint in LHCBGAUSS-1409 actually fixes the stall and my job ends nicely.

approved this merge request

mentioned in commit aae27c2a

merged

mentioned in merge request !939 (merged)