Thanks, Ben. This looks super great and is a lot of work! My requests above are minor. Do we want to start to prepare all the wrappers and matrix files using this? (I'm not sure which wrappers you made) so we have them once this is merged? I imagine the MR will take awhile to review officially
These also need conversion to Gaudi::Property
Do you think it makes sense to move this functionality to the subrmap so that we can use it elsewhere?
Anticipating the MR comments, these all need to be changed to Gaudi::Property just like the 2D HT: https://gitlab.cern.ch/atlas/athena/-/blob/dcb19289906e54504510c963ce5a97f2d8de27b9/Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough/src/FPGATrackSimHoughTransformTool.h#L148
minor point but i guess we could make this default the same as the other one, no? [-0.001, -0.0005, 0, 0.0005, 0.001]
We don't want this configurable? (Also, did we conclude that having 5 bins is better than 1? I don't remember where the 5 comes from at this point but I know you studied it)
Sorry, it's basically !69990 (closed) but fixing our CI test (since Yannis is now away). If this doesn't go away then yes please open another ticket. Sorry for the confusion!
Hi @jmasik No this is completely unrelated. This only fixes the CI test for FPGATrackSim (plus adds in the fixes to run on our input files that was done by Yannis). The CI test fix was to just not check truth information when we run our check (since that file doesn't seem to have it), otherwise we just skip over all events. And the other fix is a bugfix to indentation that was incorrectly merged at some point recently. I don't see how this relates to https://its.cern.ch/jira/browse/ATR-29037
I dont' have access to update Yannis' branch and he's now away so I will close this in lieu of this here: !70059 (merged)
Fix for !69990