Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Open sidebar
John Apostolakis
VecGeom
Commits
fd6e7f06
Commit
fd6e7f06
authored
Aug 18, 2021
by
Andrei Gheata
Committed by
Andrei Gheata
Aug 25, 2021
Browse files
Fixed cone shape tester. Consistent Inside tolerance check for cone.
parent
611dfe82
Changes
2
Hide whitespace changes
Inline
Side-by-side
VecGeom/volumes/ConeUtilities.h
View file @
fd6e7f06
...
...
@@ -512,9 +512,9 @@ public:
// very fast check on z-height
Real_v
absz
=
Abs
(
point
[
2
]);
completelyoutside
=
absz
>
MakePlusTolerant
<
ForInside
>
(
cone
.
fDz
,
kConeTolerance
);
completelyoutside
=
absz
>
MakePlusTolerant
<
ForInside
>
(
cone
.
fDz
,
k
Half
ConeTolerance
);
if
(
ForInside
)
{
completelyinside
=
absz
<
MakeMinusTolerant
<
ForInside
>
(
cone
.
fDz
,
kConeTolerance
);
completelyinside
=
absz
<
MakeMinusTolerant
<
ForInside
>
(
cone
.
fDz
,
k
Half
ConeTolerance
);
}
if
(
vecCore
::
MaskFull
(
completelyoutside
))
{
return
;
...
...
test/shape_tester/shape_testCone.cpp
View file @
fd6e7f06
...
...
@@ -33,9 +33,7 @@ int runTester(ImplT const *shape, int npoints, bool debug, bool stat)
{
ShapeTester
<
ImplT
>
tester
;
#ifndef VECGEOM_FLOAT_PRECISION
tester
.
SetSolidTolerance
(
1.e-7
);
#endif
tester
.
SetSolidTolerance
(
vecgeom
::
kHalfConeTolerance
);
tester
.
setDebug
(
debug
);
tester
.
setStat
(
stat
);
tester
.
SetMaxPoints
(
npoints
);
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment