John Derek Chapman (f7c5a3e4) at 28 Mar 11:19
Add ISFParticle::id() method and add id argument to ISFParticle con...
... and 135 more commits
John Derek Chapman (b395c58a) at 28 Mar 11:16
MDT_Digitization: Clean-up particleGamma and chargeCalculator helpe...
... and 2 more commits
John Derek Chapman (8292c0bf) at 28 Mar 11:12
MDT_Digitization: Clean-up particleGamma and chargeCalculator helpe...
... and 4 more commits
Jenkins please retry a build
John Derek Chapman (185179e2) at 28 Mar 11:03
MDT_Digitization: Clean-up particleGamma and chargeCalculator helpe...
... and 1 more commit
I think that only some of the changes went into 24.0. See !69914 (merged) - those were swept into main in !70129 (merged)
I guess what this MR needs now is a rebase.
(OK multiple messages in parallel here.
Not for this MR, but we have a similar block in the Digitization configuration - perhaps we should share it in some common place in the future? https://gitlab.cern.ch/atlas/athena/-/blob/24.0/Simulation/Digitization/DigitizationConfig/python/DigitizationSteering.py#L217-222
John Derek Chapman (483cfd43) at 28 Mar 09:52
Migrate MuonDigitization code to use GenParticle::id rather than ba...
... and 121 more commits
Thanks - that's what I get for making changes too quickly at the end of the day. ;-)
John Derek Chapman (619fb667) at 28 Mar 09:38
Remove semi-colons
kwargs.setdefault("energyCut", 100.*MeV) # Energy cut in MeV
kwargs.setdefault("isDalek", False)
kwargs.setdefault("R", 1150.*mm) # ID outer radius
kwargs.setdefault("Z", 3490.*mm) # ID maximum Z coordiate
Jenkins please retry a build
John Derek Chapman (8d3583f4) at 27 Mar 17:08
Add CA-based configuration for the FastIDKiller
Initial version of FastIDKiller configuration - can be expanded as required.
Needed for egamma studies.
John Derek Chapman (84cd8286) at 27 Mar 17:02
Add CA-based configuration for the FastIDKiller
... and 83460 more commits
Jenkins please retry a build
The first attempt at this !69655 caused issues in the case that pile-up background HITS with intact truth information and using a barcode-based persistent were read into a pile-up digitization job. In this case there was no way for the initial HepMcParticleLink member variables of the transient hit classes generated from the persistent classes to know whether they should be linking to an event other than the first event in the McEventCollection (The hard-scatter GenEvent is always first in the McEventCollection). This meant that calls to HepMcParticleLink::id()
would return zero as the links often appear to be invalid.
This second version of the migration is less aggressive as it allows the possibility of barcode-based inputs. It avoids the issue seen in ATLSWUPGR-242 according to my local tests, but I will avoid marking the merge request as ready until we have a CI test to catch such an issue.