AthenaConfiguration: Enable flake8 build check and make python code compliant

Remove the flake8 unit test as this is now handled by the build-time
check.

Control/AthenaConfiguration/CMakeLists.txt

@@ -9,7 +9,8 @@ atlas_subdir( AthenaConfiguration )
 find_package( six )
 
 # Install files from the package:
-atlas_install_python_modules( python/*.py python/iconfTool )
+atlas_install_python_modules( python/*.py python/iconfTool 
+                              POST_BUILD_CMD ${ATLAS_FLAKE8} )
 atlas_install_scripts( share/confTool.py python/iconfTool/iconfTool )
 atlas_install_data( share/*.ref )
 
@@ -43,13 +44,6 @@ if( NOT "${CMAKE_PROJECT_NAME}" STREQUAL "AthSimulation" )
                     POST_EXEC_SCRIPT nopost.sh )
 endif()
 
-
-# Check python syntax:
-atlas_add_test( flake8
-   SCRIPT flake8 --select=ATL,F,E7,E9,W6 ${CMAKE_CURRENT_SOURCE_DIR}/python
-   POST_EXEC_SCRIPT nopost.sh )
-
-
 # Test AppendToGlobal
 atlas_add_test( appendToGlobalTest
 		SCRIPT athena.py testAppendToGlobals.py

Control/AthenaConfiguration/python/TestDefaults.py

-#Files for use in configuration unit tests
+# Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
+# Files for use in configuration unit tests
 
 from __future__ import print_function
 

Control/AthenaConfiguration/python/iconfTool/utils/serialization.py

+# Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
 import pickle