Merge branch 'cherry-pick-ccdf42bd [formerly 8e3df239]-21.3' into '21.3'

Sweeping !16595 from master to 21.3.
Cleanup Simulation/ISF/{ISF_FatrasTools,ISF_FatrasToolsID,ISF_FatrasToolsMS}

See merge request atlas/athena!16717

Former-commit-id: 0591fdc0c59467d2e5ada65f82ada37cf5cce571

Simulation/ISF/ISF_Fatras/ISF_FatrasTools/src/PhysicsValidationTool.h

@@ -30,20 +30,12 @@
 // ROOT forward declarations
 class TTree;
 
-class IIncidentSvc;
-//class AtlasDetectorID;
-
 namespace ISF {
     class ISFParticle;
 }
 
 namespace iFatras 
 {
- 
-  class IParticleDecayHelper;
-  class ITrackCreator;    
-  class ISimHitCreator;    
-    
   /** @class PhysicsValidationTool 
       
       Fatras AlgTool to validate the physics content 

Simulation/ISF/ISF_Fatras/ISF_FatrasToolsID/src/HitCreatorSilicon.h

@@ -33,18 +33,6 @@ class SCT_ID;
 class IInDetConditionsSvc;
 class StoreGateSvc;
 class TF1;
-namespace InDet {
-    class ClusterMakerTool;
-}
-
-namespace InDetDD  {
-    class SiDetectorElement;
-}
-
-namespace Trk {
-    class IRIO_OnTrackCreator; class LocalPosition;
-    class Surface;
-}
 
 namespace ISF {
     class ISFParticle;

Simulation/ISF/ISF_Fatras/ISF_FatrasToolsID/src/HitCreatorTRT.h

@@ -28,14 +28,9 @@
 #include "InDetSimEvent/TRTUncompressedHitCollection.h"
 
 class ITRT_StrawStatusSummarySvc;
-class ITRT_DriftFunctionTool;
 class TRT_ID;
 class StoreGateSvc;
 
-namespace Trk {    
-    class ITRT_ElectronPidTool;
-}
-
 namespace ISF {
     class ISFParticle;
 }

Simulation/ISF/ISF_Fatras/ISF_FatrasToolsID/src/SimHitCreatorID.h

@@ -20,19 +20,11 @@
 // Fatras
 #include "ISF_FatrasInterfaces/ISimHitCreator.h"
 
-// Tracking includes
-#include "TrkExInterfaces/ITimedExtrapolator.h"
-
 // STL
 #include <utility>
 
 class AtlasDetectorID;
 
-namespace Trk {
-  class Track;
-}
-
-
 namespace iFatras {
   
   class IHitCreator;

Simulation/ISF/ISF_Fatras/ISF_FatrasToolsMS/src/SimHitCreatorMS.h

@@ -16,7 +16,6 @@
 #include "GaudiKernel/IIncidentListener.h"
 // ISF includes
 #include "ISF_FatrasInterfaces/ISimHitCreator.h"
-//#include "ISF_FatrasInterfaces/IHitCreator.h"
 // Tracking includes
 #include "TrkParameters/TrackParameters.h"
 #include "TrkExInterfaces/ITimedExtrapolator.h"
@@ -34,8 +33,6 @@ class MdtHitIdHelper;
 class RpcHitIdHelper;
 class CscHitIdHelper;
 class TgcHitIdHelper;
-class sTgcHitIdHelper;
-class MicromegasHitIdHelper;
 
 namespace MuonGM {
   class MuonDetectorManager;
@@ -48,8 +45,6 @@ namespace Muon {
 
 namespace Trk {
   class Layer;
-  class Track;
-  class TrackingGeometry;
 }
 
 namespace ISF {
@@ -62,8 +57,6 @@ struct sTgcSimIdToOfflineId;
 namespace iFatras 
 {
 
-   class IHitCreator;
-    
   /** @class SimHitCreatorMS 
 
       A dedicated instance for Fatras sim hit creation
@@ -131,8 +124,6 @@ namespace iFatras
       RpcHitIdHelper*                      m_rpcHitIdHelper;
       CscHitIdHelper*                      m_cscHitIdHelper;
       TgcHitIdHelper*                      m_tgcHitIdHelper;
-      //sTgcHitIdHelper*                     m_sTgcHitIdHelper;
-      //MicromegasHitIdHelper*               m_mmHitIdHelper;
       MM_SimIdToOfflineId*                 m_mmOffToSimId;
       sTgcSimIdToOfflineId*                m_stgcOffToSimId;