GitLab

git-svn-id: file:///git/lcgcool.svndb/cool/tags/COOL_3_0_1@19065 4525493e-7705-40b1-a816-d608a930855b

git-svn-id: file:///git/lcgcool.svndb/cool/tags/COOL_3_0_1@19064 4525493e-7705-40b1-a816-d608a930855b

git-svn-id: file:///git/lcgcool.svndb/cool/trunk@18768 4525493e-7705-40b1-a816-d608a930855b

(fix code indentation and remove unnecessary trailing whitespaces using emacs)

In the end I decided to process also the CoolKernel API.
These changes should have no impact at all on binary compatibility.


git-svn-id: file:///git/lcgcool.svndb/cool/trunk@16413 4525493e-7705-40b1-a816-d608a930855b

Modify all source code to complete the port to gcc43
(remove 'type qualifiers on function return type' warnings).
Use the automatic sedGcc43.csh script.


git-svn-id: file:///git/lcgcool.svndb/cool/trunk@14960 4525493e-7705-40b1-a816-d608a930855b

git-svn-id: file:///git/lcgcool.svndb/cool/trunk@14439 4525493e-7705-40b1-a816-d608a930855b

(complete task #4879).


git-svn-id: file:///git/lcgcool.svndb/cool/trunk@10249 4525493e-7705-40b1-a816-d608a930855b

git-svn-id: file:///git/lcgcool.svndb/cool/trunk@10247 4525493e-7705-40b1-a816-d608a930855b

As before, setValue("") is equivalent to setNull().
Again, this is the ONLY special feature of strings.

But this time, they both result in the variable being equal to ""
and not null. Both data() and addressOfData will return values
compatible with "", while isNull() will return false.

Note in particular that wrapped attributes and attribute lists are
reinterpreted in such a way that fields are considered equal to ""
both if the corresponding attributes are null and if they are "".


git-svn-id: file:///git/lcgcool.svndb/cool/trunk@8217 4525493e-7705-40b1-a816-d608a930855b

git-svn-id: file:///git/lcgcool.svndb/cool/trunk@8214 4525493e-7705-40b1-a816-d608a930855b

Move the field() methods to private in IRecord.


git-svn-id: file:///git/lcgcool.svndb/cool/trunk@8093 4525493e-7705-40b1-a816-d608a930855b

better an exception than a runtime pure virtual method called error...


git-svn-id: file:///git/lcgcool.svndb/cool/trunk@8004 4525493e-7705-40b1-a816-d608a930855b

was commented out and not used. In the end there is no method
implemented that always throws...


git-svn-id: file:///git/lcgcool.svndb/cool/trunk@8003 4525493e-7705-40b1-a816-d608a930855b

It is enough to move it to private so that virtual=0 is not =0 anymore.


git-svn-id: file:///git/lcgcool.svndb/cool/trunk@8002 4525493e-7705-40b1-a816-d608a930855b

This has the same effect on the public interface and it allows me to keep
my chain of dependencies intact (all record implementations respect
the record specification contents).


git-svn-id: file:///git/lcgcool.svndb/cool/trunk@8001 4525493e-7705-40b1-a816-d608a930855b

can be defined as a class that only has const methods, more correctly!


git-svn-id: file:///git/lcgcool.svndb/cool/trunk@7998 4525493e-7705-40b1-a816-d608a930855b

git-svn-id: file:///git/lcgcool.svndb/cool/trunk@7992 4525493e-7705-40b1-a816-d608a930855b

record specification (the implementation of size, index and operator[]
is inlined in IRecord and delegated to IRecordSpecification). It is up
to the concrete derived class to implement field() and manage its data
(e.g. within an AttributeList) in the appropriate way, in particular to
validate data values against the relevant storage type constraints.

Remove operators from derived classes, add method field() instead.


git-svn-id: file:///git/lcgcool.svndb/cool/trunk@7896 4525493e-7705-40b1-a816-d608a930855b

The AttributeList must have AT LEAST all the fields required by the
IRecordSpecification (with the correct name and storage type), but it
may have more: it is reinterpreted according to the new specification.


git-svn-id: file:///git/lcgcool.svndb/cool/trunk@7872 4525493e-7705-40b1-a816-d608a930855b

Keep implicit conversion operator() to Attribute[List]
only in the abstract IField and IRecord classes.
Implement them in terms of attribute() and attributeList() methods.

Enclose within #ifdef COOL13 onnly some code in IField and IRecord:
the virtual attribute() and attributeList() methods = 0,
and the operators implemented in terms of them.

Keep in any case the attribute() and attributeList() methods
in all concrete classes.

In summary: if we remove backward compatibility extensions,
we would only touch the abstract base classes IField and IRecord,
which would then become AttributeList-free.
The concrete classes may remain AttributeList-aware in all cases,
since in any case they are defined as wrapper to Attribute[List]s!

2.
Move non-const methods of ConstFieldAdapter to private
(or remove them if their presence is not requested by the base class).


git-svn-id: file:///git/lcgcool.svndb/cool/trunk@7804 4525493e-7705-40b1-a816-d608a930855b

git-svn-id: file:///git/lcgcool.svndb/cool/trunk@7803 4525493e-7705-40b1-a816-d608a930855b

This makes it possible to catch additional problems at build time.


git-svn-id: file:///git/lcgcool.svndb/cool/trunk@7801 4525493e-7705-40b1-a816-d608a930855b

Replace toOutputStream by print and printValue methods.
Add operator<< consistently. Remove toString() method.

Add IField::compareValue and use it to implement operator==.


git-svn-id: file:///git/lcgcool.svndb/cool/trunk@7794 4525493e-7705-40b1-a816-d608a930855b

This is now unnecessary as the copy constructor and assignment exist.


git-svn-id: file:///git/lcgcool.svndb/cool/trunk@7767 4525493e-7705-40b1-a816-d608a930855b

These should probably be renamed and mayeb modified...
but the proof of concept works fine now.

The RecordAdapter test has many comments about what is legal and illegal.


git-svn-id: file:///git/lcgcool.svndb/cool/trunk@7753 4525493e-7705-40b1-a816-d608a930855b