New tags for 2023-as-taken and 2024-expected taking into account other geometry changes
The only difference between the geometry of 2023-as-taken
and 2024-expected
is (for now) the presence of different sizes for the shims (!124 (merged) &!128 (merged)), but we also need to put in a different thickness of the RF foils (!129 (merged))
On the other hand there are changes by other detectors to better describe the geometry, that should be picked up for both 2023 and 2024.
The fact that both periods are in the same upgrade/master
branch will require some gymnastic and discipline. This issue is to keep track of what we do and 'document' it.
We should consider upgrade/master
as the reference for 2024 and put in all changes in for it including the change in shims and prepare the tags for 2024.
We can then decide which option we prefer for 2023:
- tagging a specific commit (local or on a temporary branch) with the different side of shims for 2023 and thinner RF foils emulation
- put the changes in
upgrade/master
, tag for 2023, and revert it immediately so that we can then continue for 2024 without having to remember to do something about it
There are pros&cons to either approach. Personally I lean a bit more on 1. and I would be happy to take care of it.
The only issue is the order for merging all pending MR. Probably !128 (merged) should go in before everything else... I am checking with OPG on samples they asked for 2024 and if they need to compare them with already produced samples