lb-nightly-functions issueshttps://gitlab.cern.ch/lhcb-core/nightly-builds/lb-nightly-functions/-/issues2021-09-17T10:01:22+02:00https://gitlab.cern.ch/lhcb-core/nightly-builds/lb-nightly-functions/-/issues/16produce a usable installation even after a build failure2021-09-17T10:01:22+02:00Marco Clemencicmarco.clemencic@cern.chproduce a usable installation even after a build failureCMake, by default, requires that all build artifacts have been correctly produced when installing.
It's possible to tell CMake that a build artifact is `OPTIONAL`, but it's not easy nor correct to change all invocations of the `install`...CMake, by default, requires that all build artifacts have been correctly produced when installing.
It's possible to tell CMake that a build artifact is `OPTIONAL`, but it's not easy nor correct to change all invocations of the `install` command to use the `OPTIONAL` flag (we risk to deploy incomplete builds without noticing).
What we can do is to patch the CMake generated `cmake_install.cmake` files in the nightlies so that we can effectively turn all build artifacts to `OPTIONAL` in the special case of the nightly builds.
See lhcb-core/LbNightlyTools#98https://gitlab.cern.ch/lhcb-core/nightly-builds/lb-nightly-functions/-/issues/14Add support for CTest attachments and notes2021-07-23T18:09:18+02:00Marco Clemencicmarco.clemencic@cern.chAdd support for CTest attachments and notesCTest is able to submit [attachments](https://cmake.org/cmake/help/latest/command/ctest_test.html#attached-files) and [notes](https://cmake.org/cmake/help/latest/manual/ctest.1.html#dashboard-client) to the CDash dashboard.
We should su...CTest is able to submit [attachments](https://cmake.org/cmake/help/latest/command/ctest_test.html#attached-files) and [notes](https://cmake.org/cmake/help/latest/manual/ctest.1.html#dashboard-client) to the CDash dashboard.
We should support those special operations by uploading the *attached files* and the *notes file* to the test log directory.https://gitlab.cern.ch/lhcb-core/nightly-builds/lb-nightly-functions/-/issues/11Review the use of decode and encode of unicode strings2021-06-28T18:12:09+02:00Marco Clemencicmarco.clemencic@cern.chReview the use of decode and encode of unicode stringsIn general we cannot be sure that the stdout/stderr of the commands we call is valid unicode, so we have to protect all `bytes.decode` invocations with `errors="surrogateescape"`, and make sure that all the matching `str.encode` also use...In general we cannot be sure that the stdout/stderr of the commands we call is valid unicode, so we have to protect all `bytes.decode` invocations with `errors="surrogateescape"`, and make sure that all the matching `str.encode` also use `errors="surrogateescape"` (see https://docs.python.org/3/library/codecs.html#error-handlers)
- [ ] @clemenci started a [discussion](https://gitlab.cern.ch/lhcb-core/nightly-builds/lb-nightly-functions/-/merge_requests/54#note_4607226):
> As discussed on the chat, we cannot be sure that the output of our commands is valid unicode, so it's better to use:
> ```suggestion:-1+0
> output["stdout"] = result.stdout.decode(errors="surrogateescape")
> output["stderr"] = result.stderr.decode(errors="surrogateescape")
> ```https://gitlab.cern.ch/lhcb-core/nightly-builds/lb-nightly-functions/-/issues/10Add automatic retry of failed tests (in CMake builds)2021-03-15T12:42:23+01:00Marco Clemencicmarco.clemencic@cern.chAdd automatic retry of failed tests (in CMake builds)see lhcb-core/LbNightlyTools#89see lhcb-core/LbNightlyTools#89https://gitlab.cern.ch/lhcb-core/nightly-builds/lb-nightly-functions/-/issues/9support CMT builds2021-07-28T12:29:34+02:00Maciej Pawel Szymanskisupport CMT buildshttps://gitlab.cern.ch/lhcb-core/nightly-builds/lb-nightly-functions/-/issues/3Use SoftConfDb to get Gitlab URL of projects2021-03-15T12:41:28+01:00Marco Clemencicmarco.clemencic@cern.chUse SoftConfDb to get Gitlab URL of projectsThe following discussion from !5 should be addressed:
- [ ] @clemenci started a [discussion](https://gitlab.cern.ch/lhcb-core/nightly-builds/lb-nightly-functions/-/merge_requests/5#note_3640125):
> the default Gitlab Git URL shoul...The following discussion from !5 should be addressed:
- [ ] @clemenci started a [discussion](https://gitlab.cern.ch/lhcb-core/nightly-builds/lb-nightly-functions/-/merge_requests/5#note_3640125):
> the default Gitlab Git URL should be retrieved from SoftConfDbhttps://gitlab.cern.ch/lhcb-core/nightly-builds/lb-nightly-functions/-/issues/2Evaluate and possibly use replacement of zip command with zipfile module2022-05-25T10:01:56+02:00Marco Clemencicmarco.clemencic@cern.chEvaluate and possibly use replacement of zip command with zipfile moduleThe following discussion from !5 should be addressed:
- [ ] @clemenci started a [discussion](https://gitlab.cern.ch/lhcb-core/nightly-builds/lb-nightly-functions/-/merge_requests/5#note_3639250):
> Should we use the `zip` command ...The following discussion from !5 should be addressed:
- [ ] @clemenci started a [discussion](https://gitlab.cern.ch/lhcb-core/nightly-builds/lb-nightly-functions/-/merge_requests/5#note_3639250):
> Should we use the `zip` command or the `zipfile` module? (see 6c34b21ac)