Including or not luminosity region in beam settings for SMOG and book-keeping path convention for SMOG1, SMOG2 and SMOG+pp collisions
The following discussion from !180 (merged) should be addressed:
-
@ggrazian started a discussion: (+1 comment) Hi Gloria, I saw the message from the pipeline, but I think we could make an exception, as the change is fully backward compatible (there are no new options, just new names for the generation algorithms that are used for Beam-Gas in Gauss >=v56). These "VertexSmear" files are included in the beam configuration options for beam-gas (e.g. pNe-Beam2510GeV-0GeV-md100-2017.py), which btw I think is not a good practice (I would prefer to disentangle the beam configuration and the fiducial volume in z for the given prodution: depending on the physics goal you may want to have different fiducial volumes for different productions for the same data sample). So, if we keep the VertexSmear_* files in the beam options, they should all be modified as I did for VertexSmear_SMOG_2m.py. Or we could add files with different names for future productions (not only the VertexSmear_* files, but also the beam files... it would be a bit confusing), please tell us what you prefer
comment (@gcorti):
For the beam files it will be mandatory to have new ones with new names (that we can e.g. prepend withSim10
) because of the new Gauss() property that makes it impossible to use the same forSim09
andSim10
.
Note that what you call the beam files are not strictly speaking only about the beam itself but also the luminous region.
Regardless we can discuss if in the new files forSim10
we include the new smearing for the default configuration of the luminous region - it can always be overwritten by passing explicitly a different vertex smearing after the beam - or leave it empty and force passing it. I would see a point for the second choice if we can set everything else but the vertex smearing as the same for both SMOG1 and SMOG2 as it would allow us in the steps to 'just' change the name of the vertex smearing file. But we could also set the file for SMOG2 in the beam option and override it for SMOG1 for the step. We should also discuss the naming convention for the book-keeping path to differentiate between SMOG1, SMOG2 and SMOG2+collisions.