Checks with multiple TTrees marked 'passing' even if some fail
When running a checks on an nTuple with multiple TTrees, the default behaviour is to repeat the check for each TTree. In cases where some pass and some fail, the desired behaviour is that the whole check be marked as having failed. However, in some cases, it is still marked as true.
I believe that the reason for this is due to using result.passed |= False
in checks.py
. If the first check passes, result.passed
is set to True
, and any subsequent checks are unable to change this value since they only use |=
instead of just =
.
Work related to DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/93.