LbAPCommon merge requestshttps://gitlab.cern.ch/lhcb-dpa/analysis-productions/lbapcommon/-/merge_requests2023-03-15T11:56:40+01:00https://gitlab.cern.ch/lhcb-dpa/analysis-productions/lbapcommon/-/merge_requests/67Add check that performs 1D fits2023-03-15T11:56:40+01:00Dylan Jaide WhiteAdd check that performs 1D fitsAdds a new check type, `range_fit`, which performs an extended binned fit to data. Users can define a set of parameters, which can be used in fit component function. A handful of function types are defined for use. The full PDF is the su...Adds a new check type, `range_fit`, which performs an extended binned fit to data. Users can define a set of parameters, which can be used in fit component function. A handful of function types are defined for use. The full PDF is the sum of these.
One possible significant change in this MR is that the class `CheckResult` class is moved from `checks.py` to `checks_utils.py`. This is done to avoid circular importing, and it makes most sense for `checks` to be able to import from `checks_utils` than vice versa. This has the potential to break things elsewhere if they import `CheckResult` directly - `LbAPLocal` and `LbAnalysisProductions` appear to be fine at a glance, but other relevant repos should be checked before merging, and if needed a MR opened to fix the import of `CheckResult`.
- [x] Demonstrate a simple test fit using the Checks framework
- [x] Update YAML with a new check type, which lets users specify parameters and fit components (from a pre-defined list of functions)
- [x] Implement PDF/CDFs
- [x] Gaussian
- [x] Exponential
- [x] Polynomial
- [x] Perform fit using PDF/CDF generated from YAML
- [x] Add tests
- [x] Implement combining of fit checks
- [x] Add tests of combining of fit checksDylan Jaide WhiteDylan Jaide Whitehttps://gitlab.cern.ch/lhcb-dpa/analysis-productions/lbapcommon/-/merge_requests/66Draft: Validate expected TTrees with new default check2023-07-25T18:42:19+02:00Dylan Jaide WhiteDraft: Validate expected TTrees with new default checkAdds an `expected_ttrees` default check used for validation. Also adds a new standard check type, `ttrees_exist` (similar to `branches_exist`).
FYI @aiwiederAdds an `expected_ttrees` default check used for validation. Also adds a new standard check type, `ttrees_exist` (similar to `branches_exist`).
FYI @aiwiederDylan Jaide WhiteDylan Jaide White