Renaming of all functor collections for better consistency and to avoid clashes
Doing a browse of some bits of code to refresh myself I noticed that we're starting to have a lot of classes, helfer functions and also functors with very similar names, and we should try and be clear on what is what. As an example consider the following imports:
from PyConf.Algorithms import MCReconstructedAlg
from DaVinciMCTools import MCReconstructed
from FunTuple.functorcollections import MCReconstructed_Collection
The first / second / third import refers to an algorithm / helper class / functor collection (a function, in essence).
The name differences are small and I'm sure we can find other examples where they are even smaller. More importantly, MCReconstructed
could just be a class since we write classes in CamelCase.
In short, I'm suggesting we suffix all functor collections with FC
, so for example EventInfo
becomes EventInfoFC
, HltTisTos
becomes HltTisTosFC
(another source of confusion with the related algorithm) and MCReconstructed_Collection
becomes MCReconstructedFC
.