Boole merge requestshttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests2024-03-19T15:44:31+01:00https://gitlab.cern.ch/lhcb/Boole/-/merge_requests/520MCRichDigitsToRawBufferAlg: Use by default 64 bit stream format in dd4hep builds2024-03-19T15:44:31+01:00Christopher Rob Jonesjonesc@hep.phy.cam.ac.ukMCRichDigitsToRawBufferAlg: Use by default 64 bit stream format in dd4hep buildsUsing the realistic emulation has little practical advantage to the simpler streaming format, which we have always used (the 32 bit version) in DetDesc builds.
Currently the realistic emulation has issues due to the simulation Cond DB b...Using the realistic emulation has little practical advantage to the simpler streaming format, which we have always used (the 32 bit version) in DetDesc builds.
Currently the realistic emulation has issues due to the simulation Cond DB branches used with dd4hep do not have the correct Tel40 link conditions in place. This should be addressed as well, but this MR by passes this by switching to the 64 bit streaming version in dd4hep builds.
In addition, this format will be needed in any future Upgrade 2 productions as it is the only format that supports time information at this point. So making this the default in dd4hep builds makes sense at this time.
FYI @seaso @oheald @krepsGloria CortiGloria Cortihttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/472Remove RICH PMT emulation algorithms from run2-patches2023-12-15T20:47:10+01:00Christopher Rob Jonesjonesc@hep.phy.cam.ac.ukRemove RICH PMT emulation algorithms from run2-patchesSee discussion in lhcb/Boole!471
FYI @cattanemSee discussion in lhcb/Boole!471
FYI @cattanemhttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/487Rich add 64bit streaming support2023-07-24T10:57:45+02:00Christopher Rob Jonesjonesc@hep.phy.cam.ac.ukRich add 64bit streaming supportGoes with lhcb/LHCb!4166. See discussion there for details.Goes with lhcb/LHCb!4166. See discussion there for details.Christopher Rob Jonesjonesc@hep.phy.cam.ac.ukZehua XuErika De LuciaChristopher Rob Jonesjonesc@hep.phy.cam.ac.ukhttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/484Various RICH improvements for DD4HEP support2023-06-15T10:01:25+02:00Christopher Rob Jonesjonesc@hep.phy.cam.ac.ukVarious RICH improvements for DD4HEP support - Add temporary workaround to fallback to 'Copy' PMT response model with DD4HEP
- Handle more gracefully encoding issues due to incompatible geometries between Gauss and Boole.
See lhcb/Boole#16 for more details. - Add temporary workaround to fallback to 'Copy' PMT response model with DD4HEP
- Handle more gracefully encoding issues due to incompatible geometries between Gauss and Boole.
See lhcb/Boole#16 for more details.https://gitlab.cern.ch/lhcb/Boole/-/merge_requests/404RICH monitoring tuning2022-10-07T16:27:39+02:00Bartosz MaleckiRICH monitoring tuningMinor updates in the RICH monitoring histograms (typo fix in histogram name and tuning of the histogram ranges).Minor updates in the RICH monitoring histograms (typo fix in histogram name and tuning of the histogram ranges).Sebastien PonceBartosz MaleckiSebastien Poncehttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/381Make MCRichDigitsToRawBufferAlg functional2022-10-07T16:26:39+02:00Christopher Rob Jonesjonesc@hep.phy.cam.ac.ukMake MCRichDigitsToRawBufferAlg functionalMakes MCRichDigitsToRawBufferAlg (almost) functional in order to adapt to changes introduced in lhcb/LHCb!3421 and fix the dd4hep builds (tests still fail, but they do anyway in master so...)
I say almost, as Boole still requires algori...Makes MCRichDigitsToRawBufferAlg (almost) functional in order to adapt to changes introduced in lhcb/LHCb!3421 and fix the dd4hep builds (tests still fail, but they do anyway in master so...)
I say almost, as Boole still requires algorithms that emulate the RawBanks to fill a single RawEvent object, which is not something allowed in the functional framework as input arguments are const. I therefore have to cast this away in order to fill the RICH banks.
Eventually Boole will need to be updated to change how it creates the RawEvent, to remove the need for this, but that is well beyond the scope of this MR.https://gitlab.cern.ch/lhcb/Boole/-/merge_requests/409Set the RICH SourceID detector bits correctly with the 'streaming' format2022-09-19T13:24:56+02:00Christopher Rob Jonesjonesc@hep.phy.cam.ac.ukSet the RICH SourceID detector bits correctly with the 'streaming' formatCloses lhcb/Boole#11
Requires lhcb/LHCb!3766Closes lhcb/Boole#11
Requires lhcb/LHCb!3766Rosen MatevRosen Matevhttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/382Default to the real RICH data format2022-08-08T09:58:34+02:00Christopher Rob Jonesjonesc@hep.phy.cam.ac.ukDefault to the real RICH data formatRequires lhcb/LHCb!3718Requires lhcb/LHCb!3718https://gitlab.cern.ch/lhcb/Boole/-/merge_requests/372RICH Preparations for DD4Hep support2021-12-17T14:50:31+01:00Christopher Rob Jonesjonesc@hep.phy.cam.ac.ukRICH Preparations for DD4Hep supportSee description in lhcb/LHCb!3355See description in lhcb/LHCb!3355Alexandre Brea RodriguezAlexandre Brea Rodriguezhttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/340Update DB tags in RICH tests for new cable mappings2021-06-24T10:01:30+02:00Christopher Rob Jonesjonesc@hep.phy.cam.ac.ukUpdate DB tags in RICH tests for new cable mappingsAdapts to lhcb-conddb/SIMCOND!148 and requires lhcb/LHCb!3061Adapts to lhcb-conddb/SIMCOND!148 and requires lhcb/LHCb!3061Marco CattaneoMarco Cattaneohttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/309RICH - SIN model updates.2020-10-28T10:02:28+01:00Bartosz MaleckiRICH - SIN model updates.Update the SIN model:
- use SIN *ratio* instead of *probability* (following the improved SIN model)
- improve SIN hits time simulation
- scale the occupancies stored in the conditions DB for the SIN simulation to the current (run-time) n...Update the SIN model:
- use SIN *ratio* instead of *probability* (following the improved SIN model)
- improve SIN hits time simulation
- scale the occupancies stored in the conditions DB for the SIN simulation to the current (run-time) nu.
Needs lhcb/LHCb!2806.
To see the effects of the improved SIN model, has to be run with lhcb-conddb/SIMCOND!117. If the SIN *ratio* information is not available (e.g. in the previous SIMCOND versions), SIN simulation is disabled and a debug info is given.Marco CattaneoMarco Cattaneohttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/289RICH add realistic data formats2020-10-27T18:58:55+01:00Christopher Rob Jonesjonesc@hep.phy.cam.ac.ukRICH add realistic data formatsAdds support for encoding a realistic RICH PMT data format, using new readout mappings added in lhcb-conddb/SIMCOND!115
Default RICH data format is not changed, the currently used 'RichSmartID streaming' format is still the default, for...Adds support for encoding a realistic RICH PMT data format, using new readout mappings added in lhcb-conddb/SIMCOND!115
Default RICH data format is not changed, the currently used 'RichSmartID streaming' format is still the default, for now.
Requires lhcb/LHCb!2664https://gitlab.cern.ch/lhcb/Boole/-/merge_requests/280Updates to RICH: time gate simulation and monitoring for SIN.2020-08-04T09:26:20+02:00Bartosz MaleckiUpdates to RICH: time gate simulation and monitoring for SIN.Updates to RICH monitoring for signal-induced noise contribution.
Also includes changes needed for time gate simulation using detailed time information for all deposit types (including SIN and spillover).
Needs lhcb/LHCb!2581.Updates to RICH monitoring for signal-induced noise contribution.
Also includes changes needed for time gate simulation using detailed time information for all deposit types (including SIN and spillover).
Needs lhcb/LHCb!2581.https://gitlab.cern.ch/lhcb/Boole/-/merge_requests/288fix some clang10 warnings2020-08-04T09:23:00+02:00Christopher Rob Jonesjonesc@hep.phy.cam.ac.ukfix some clang10 warningshttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/286Remove RICH HPD specific code2020-06-30T13:36:18+02:00Christopher Rob Jonesjonesc@hep.phy.cam.ac.ukRemove RICH HPD specific codeExtension of lhcb/LHCb!2636Extension of lhcb/LHCb!2636Christopher Rob Jonesjonesc@hep.phy.cam.ac.ukChristopher Rob Jonesjonesc@hep.phy.cam.ac.ukhttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/278Update references to follow !2722020-05-05T08:42:36+02:00Marco CattaneoUpdate references to follow !272https://gitlab.cern.ch/lhcb/Boole/-/merge_requests/272RICH PMT readout time info2020-05-05T08:42:07+02:00Bartosz MaleckiRICH PMT readout time infoIntroduce realistic readout time info in Boole (time of acquisition, time-over-threshold). Time-related values are global RICH parameters and are read from the DB. Then a time gate is applied on this realistic values.
Also a general c...Introduce realistic readout time info in Boole (time of acquisition, time-over-threshold). Time-related values are global RICH parameters and are read from the DB. Then a time gate is applied on this realistic values.
Also a general cleanup of the PMT digitization algorithm is provided, so that there are no more hard-coded parameters used by the algorithm (all relavant values are read from the DB).
This MR needs updates in:
- LHCb (lhcb/LHCb!2481)
and also is related to updates in (but Boole will still run without them):
- SIMCOND (lhcb-conddb/SIMCOND!75)
- DDDB (lhcb-conddb/DDDB!36).
This MR is compatible with older DB tags. Minor impact on PID performance can be seen, due to improved implementation of the readout time window (changes are almost negligible).Sajan EasoChristopher Rob Jonesjonesc@hep.phy.cam.ac.ukMarco CattaneoBartosz MaleckiSajan Easohttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/259add possibility to use PMT channel-level properties from SIMCOND2020-01-31T08:51:58+01:00Bartosz Maleckiadd possibility to use PMT channel-level properties from SIMCONDUse channel-level properties in the digitization process (e.g. gain, threshold, SIN probability). This can be set by an option and the default behavior is not changed. Needs lhcb/LHCb!2353, lhcb-conddb/DDDB!36 and lhcb-conddb/SIMCOND!75 ...Use channel-level properties in the digitization process (e.g. gain, threshold, SIN probability). This can be set by an option and the default behavior is not changed. Needs lhcb/LHCb!2353, lhcb-conddb/DDDB!36 and lhcb-conddb/SIMCOND!75 to access the SIMCOND conditions with channel properties. Also adds an option to include SIN in the simulation, using the channel-level properties.
This MR is backward-compatible, i.e. will work with older DB tags. No difference in PID performance is expected.Sajan EasoChristopher Rob Jonesjonesc@hep.phy.cam.ac.ukSajan Easohttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/257Update references to new style for all tests, and follow changes due !2472020-01-18T10:16:24+01:00Marco CattaneoUpdate references to new style for all tests, and follow changes due !247https://gitlab.cern.ch/lhcb/Boole/-/merge_requests/247Use more realistic pixel gain (based on tested MaPMTs).2020-01-18T10:15:48+01:00Bartosz MaleckiUse more realistic pixel gain (based on tested MaPMTs).This MR introduces an updated implementation of pixel gain in the digitization of the Rich response. New values are based on results from ~70k pixels from tested MaPMTs. A slight improvement in PID performance is expected.This MR introduces an updated implementation of pixel gain in the digitization of the Rich response. New values are based on results from ~70k pixels from tested MaPMTs. A slight improvement in PID performance is expected.Christopher Rob Jonesjonesc@hep.phy.cam.ac.ukChristopher Rob Jonesjonesc@hep.phy.cam.ac.uk