Boole merge requestshttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests2023-07-07T08:46:51+02:00https://gitlab.cern.ch/lhcb/Boole/-/merge_requests/460FT Crosstalk implementation bug fix2023-07-07T08:46:51+02:00Emmy GabrielFT Crosstalk implementation bug fixBug was found when two or more crosstalk photons are generated.
Goes with reference update in !492Bug was found when two or more crosstalk photons are generated.
Goes with reference update in !492https://gitlab.cern.ch/lhcb/Boole/-/merge_requests/384Draft: Scifi bias correction2023-07-06T17:02:06+02:00Zehua XuDraft: Scifi bias correctionThe SciFi cluster position bias is fixed.
Might be urgent.
https://indico.cern.ch/event/1129289/contributions/4780395/attachments/2407253/4118590/SciFi_cluster_bias.pdf
also related to: https://gitlab.cern.ch/lhcb/Rec/-/issues/234
als...The SciFi cluster position bias is fixed.
Might be urgent.
https://indico.cern.ch/event/1129289/contributions/4780395/attachments/2407253/4118590/SciFi_cluster_bias.pdf
also related to: https://gitlab.cern.ch/lhcb/Rec/-/issues/234
also related to: https://gitlab.cern.ch/lhcb/LHCb/-/tree/SciFi_cluster_bias_fix_zehuahttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/445Muon background no m1 fix2023-02-16T11:52:59+01:00Alessia SattaMuon background no m1 fixFew fixes for no M1 simulation. Using the code without this fixes
1) M2 low energy was not added
2) in M3 M4 M5 the wrong parametherizations were uses (M3 uses M2, M4 uses M3 and M5 uses M4)
3) in flat background addition wrong number of...Few fixes for no M1 simulation. Using the code without this fixes
1) M2 low energy was not added
2) in M3 M4 M5 the wrong parametherizations were uses (M3 uses M2, M4 uses M3 and M5 uses M4)
3) in flat background addition wrong number of hits were added
Please not that the code on this branch does not allow the simulation with M1 anymore.https://gitlab.cern.ch/lhcb/Boole/-/merge_requests/438Draft: FT - Fix doubly defined ADC thresholds2022-12-08T15:46:02+01:00Emmy GabrielDraft: FT - Fix doubly defined ADC thresholdsThe SciFi ADC thresholds were doubly defined ( FTSipmTool.h and FTClusterCreator.h). Now, they are always taken from FTSipmTool.h.The SciFi ADC thresholds were doubly defined ( FTSipmTool.h and FTClusterCreator.h). Now, they are always taken from FTSipmTool.h.Gloria CortiMichal KrepsAdam DavisErika De LuciaGloria Cortihttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/424Make time and gain shifts configurable for FT2022-12-08T15:34:14+01:00Louis Henrylouis.henry@cern.chMake time and gain shifts configurable for FTThe option to configure time shifts and gain shifts as advertised got systematically overwritten by the CondDB. This should fix it, associated with a warning.
@jheuel @emgabrieThe option to configure time shifts and gain shifts as advertised got systematically overwritten by the CondDB. This should fix it, associated with a warning.
@jheuel @emgabriehttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/411MCTrackInfo: fix filling of acceptance bits and VP multiplicity2022-09-15T11:13:04+02:00Rosen MatevMCTrackInfo: fix filling of acceptance bits and VP multiplicity- Add counters to BuildMCTrackInfo (to make sure that the following fixes work)
- Fix off-by-one bug in FT MCTrackInfo acceptance bits
- Use full range in MCTrackInfo for VP digit multiplicity
Related to #10
/cc @ldufour- Add counters to BuildMCTrackInfo (to make sure that the following fixes work)
- Fix off-by-one bug in FT MCTrackInfo acceptance bits
- Use full range in MCTrackInfo for VP digit multiplicity
Related to #10
/cc @ldufourRosen MatevRosen Matevhttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/391Avoid errors from MCTrackInfo without UT2022-06-04T00:41:32+02:00Xiaofan HuAvoid errors from MCTrackInfo without UTForcing buildMCTrackInfo.WithUT to be always False, in order to prevent the error
> RuntimeError: Need one of TT or UT to build MCTrackInfo
or
> BuildMCTrackInfo:: Exception throw: get():: No valid data at 'Raw/UT/Clusters' StatusCode=FA...Forcing buildMCTrackInfo.WithUT to be always False, in order to prevent the error
> RuntimeError: Need one of TT or UT to build MCTrackInfo
or
> BuildMCTrackInfo:: Exception throw: get():: No valid data at 'Raw/UT/Clusters' StatusCode=FAILURE
related to LHCBGAUSS-2571https://gitlab.cern.ch/lhcb/Boole/-/merge_requests/350fix reference of genfsr test2021-08-18T16:58:57+02:00Gerhard Ravenfix reference of genfsr testrequired ever since the bug fix in LHCb!3137 was merged...required ever since the bug fix in LHCb!3137 was merged...Marco CattaneoGiovanni CavalleroMarco Cattaneohttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/325follow LHCb!2852: add const to UT2020-12-12T19:28:58+01:00Gerhard Ravenfollow LHCb!2852: add const to UTadd some `const`add some `const`https://gitlab.cern.ch/lhcb/Boole/-/merge_requests/252use UT versions of ST code for UT2020-02-28T12:59:25+01:00Gerhard Ravenuse UT versions of ST code for UTRequires reference files update, see !252 Requires reference files update, see !252 Marco CattaneoMarco Cattaneohttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/258Update references to follow !2522020-02-28T12:57:30+01:00Marco CattaneoUpdate references to follow !252Marco CattaneoMarco Cattaneohttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/182Fix untested StatusCode in LumiTool2018-11-08T22:31:45+01:00Marco CattaneoFix untested StatusCode in LumiToolhttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/183RichReadout : Fix clang errors in RichPixel.h2018-11-08T22:31:23+01:00Christopher Rob Jonesjonesc@hep.phy.cam.ac.ukRichReadout : Fix clang errors in RichPixel.hHopefully addresses
https://lhcb-nightlies.cern.ch/logs/build/nightly/lhcb-lcg-dev3/703/x86_64-centos7-clang60-opt/Boole/Hopefully addresses
https://lhcb-nightlies.cern.ch/logs/build/nightly/lhcb-lcg-dev3/703/x86_64-centos7-clang60-opt/Boole/https://gitlab.cern.ch/lhcb/Boole/-/merge_requests/176Clean up RichReadout memory management2018-11-07T14:16:21+01:00Christopher Rob Jonesjonesc@hep.phy.cam.ac.ukClean up RichReadout memory managementAddresses a minor memory leak on application exit, found by leak sanitizer.
```
==2559==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 1 byte(s) in 1 object(s) allocated from:
#0 0x7f5eb3108898 in operator new(unsigned ...Addresses a minor memory leak on application exit, found by leak sanitizer.
```
==2559==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 1 byte(s) in 1 object(s) allocated from:
#0 0x7f5eb3108898 in operator new(unsigned long) /mnt/build/jenkins/workspace/lcg_contrib_release/LABEL/centos7/build/contrib/gcc-8.1.0/src/gcc/8.1.0/libsanitizer/lsan/lsan_interceptors.cc:229
#1 0x7f5e8c79733f in Rich::MC::Digi::DetailedFrontEndResponse::initialize() /workspace/build/BOOLE/BOOLE_HEAD/Rich/RichReadout/src/component/RichDetailedFrontEndResponse.cpp:62
```
Fixing it required overhauling the memory management to use shared and unique pointers as required throughout.
FYI @seaso @bmalecki