Boole merge requestshttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests2024-02-03T18:58:10+01:00https://gitlab.cern.ch/lhcb/Boole/-/merge_requests/535Disable tests which cannot work in DD4hep mode2024-02-03T18:58:10+01:00Sebastien PonceDisable tests which cannot work in DD4hep modehttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/529fixed warnings for C++202023-12-16T10:47:58+01:00Sebastien Poncefixed warnings for C++20https://gitlab.cern.ch/lhcb/Boole/-/merge_requests/520MCRichDigitsToRawBufferAlg: Use by default 64 bit stream format in dd4hep builds2024-03-19T15:44:31+01:00Christopher Rob Jonesjonesc@hep.phy.cam.ac.ukMCRichDigitsToRawBufferAlg: Use by default 64 bit stream format in dd4hep buildsUsing the realistic emulation has little practical advantage to the simpler streaming format, which we have always used (the 32 bit version) in DetDesc builds.
Currently the realistic emulation has issues due to the simulation Cond DB b...Using the realistic emulation has little practical advantage to the simpler streaming format, which we have always used (the 32 bit version) in DetDesc builds.
Currently the realistic emulation has issues due to the simulation Cond DB branches used with dd4hep do not have the correct Tel40 link conditions in place. This should be addressed as well, but this MR by passes this by switching to the 64 bit streaming version in dd4hep builds.
In addition, this format will be needed in any future Upgrade 2 productions as it is the only format that supports time information at this point. So making this the default in dd4hep builds makes sense at this time.
FYI @seaso @oheald @krepsGloria CortiGloria Cortihttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/512Use sim10/run3-ideal tag by default for dd4hep conditions2023-09-03T11:25:18+02:00Rosen MatevUse sim10/run3-ideal tag by default for dd4hep conditionsThis makes the tests independent from master which is not
appropriate for running Boole on MC.
In particular, it fixes the boole-Muon test that fails on dd4hep as of https://lhcb-nightlies.web.cern.ch/nightly/lhcb-master/2147 (since the ...This makes the tests independent from master which is not
appropriate for running Boole on MC.
In particular, it fixes the boole-Muon test that fails on dd4hep as of https://lhcb-nightlies.web.cern.ch/nightly/lhcb-master/2147 (since the Muon alignment on master changed).
Also, fix FT test for dd4hep (ported from !496), thanks to @zexu . This test will be using a dedicated condition version until `sim10/run3-ideal` supports the FT.https://gitlab.cern.ch/lhcb/Boole/-/merge_requests/451Update Calo and Muon dd4hep refs, and symlink others ot detdesc2023-02-13T16:11:34+01:00Rosen MatevUpdate Calo and Muon dd4hep refs, and symlink others ot detdescThe Calo and Muon references are updated for the dd4hep tests since the tests do not have fundamental issues and the numbers are similar to those from detdesc.
For the rest, this is similar to what was done in https://gitlab.cern.ch/lh...The Calo and Muon references are updated for the dd4hep tests since the tests do not have fundamental issues and the numbers are similar to those from detdesc.
For the rest, this is similar to what was done in https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2082
> As it stands, we have two copies of the references, the detdesc and the default (dd4hep) ones. Most of the dd4hep tests are failing for more fundamental reasons so we can't update the references there and follow developments (and updates to the detdesc refs).
>
> With this MR, for the time being, we avoid forking the references by having the default (dd4hep) be symlinks to the detdesc ones.
Follows up on https://gitlab.cern.ch/lhcb/Boole/-/merge_requests/447 which forked the detdesc and dd4hep references.
/cc @edelucia @gcavalle @gcorti @sponce @jonrobRosen MatevRosen Matevhttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/439Added VPClusterEffSimDQ to make LHCbPR histograms2023-03-04T01:33:59+01:00David HutchcroftAdded VPClusterEffSimDQ to make LHCbPR histogramsAdded VPRetinaFullClusterDecoder and VPClusterEffSimDQ to MoniVPSeq, needs https://gitlab.cern.ch/lhcb/Lbcom/-/merge_requests/644 also to provide the algorithms.
This also turns on RootHistogramSink to write out the new style histograms...Added VPRetinaFullClusterDecoder and VPClusterEffSimDQ to MoniVPSeq, needs https://gitlab.cern.ch/lhcb/Lbcom/-/merge_requests/644 also to provide the algorithms.
This also turns on RootHistogramSink to write out the new style histograms. The old style output is removed, the histogram file name and content are the same, with one exception where some CALO histograms are unweighted in the sink output, that had errors in the old method. The values look the same but the means changed a bit.
Note there is a MR to Gaudi, https://gitlab.cern.ch/gaudi/Gaudi/-/merge_requests/1426 which fixes the problem with the unhelpful log file entries when using RootHistogramSink instead of RootHistCnv::PersSvc as the output histogram converter. We can not turn off HistogramPersistancySvc as the Muon system uses that to read the background histograms. The histogram files are fine without this change, the log file is just inconsistent with the code behaviour in an unhelpful way.Rosen MatevErika De LuciaRosen Matevhttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/431Dropped direct usage of Gaudi::Functional algorithms in Boole algorithms2022-11-03T17:08:33+01:00Sebastien PonceDropped direct usage of Gaudi::Functional algorithms in Boole algorithmshttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/425Modernization of Rich code to get rid of acquireTool2022-10-25T16:19:26+02:00Sebastien PonceModernization of Rich code to get rid of acquireToolMCRichDigitSummaryAlg and RichSignal have been fully modernized
This MR was created on top of !420 and thus can only be merged after itMCRichDigitSummaryAlg and RichSignal have been fully modernized
This MR was created on top of !420 and thus can only be merged after ithttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/420RICH digitisation clean-up2022-10-25T11:46:02+02:00Bartosz MaleckiRICH digitisation clean-upRemove parts of the RICH digitisation code that are not Run3-specific.
This is a preparatory work for the code modernisations and migration to DD4HEP.
FYI @seaso @jonrobRemove parts of the RICH digitisation code that are not Run3-specific.
This is a preparatory work for the code modernisations and migration to DD4HEP.
FYI @seaso @jonrobBartosz MaleckiBartosz Maleckihttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/416Change default options to better work with DD4hep builds2022-10-07T16:27:00+02:00Marco Clemencicmarco.clemencic@cern.chChange default options to better work with DD4hep builds- add IOVProducer to BooleInitSeq if in DD4hep mode
- use GeometryVersion=trunk and CondtionsVersion=master as we do not have stable tags yet- add IOVProducer to BooleInitSeq if in DD4hep mode
- use GeometryVersion=trunk and CondtionsVersion=master as we do not have stable tags yetRosen MatevRosen Matevhttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/411MCTrackInfo: fix filling of acceptance bits and VP multiplicity2022-09-15T11:13:04+02:00Rosen MatevMCTrackInfo: fix filling of acceptance bits and VP multiplicity- Add counters to BuildMCTrackInfo (to make sure that the following fixes work)
- Fix off-by-one bug in FT MCTrackInfo acceptance bits
- Use full range in MCTrackInfo for VP digit multiplicity
Related to #10
/cc @ldufour- Add counters to BuildMCTrackInfo (to make sure that the following fixes work)
- Fix off-by-one bug in FT MCTrackInfo acceptance bits
- Use full range in MCTrackInfo for VP digit multiplicity
Related to #10
/cc @ldufourRosen MatevRosen Matevhttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/409Set the RICH SourceID detector bits correctly with the 'streaming' format2022-09-19T13:24:56+02:00Christopher Rob Jonesjonesc@hep.phy.cam.ac.ukSet the RICH SourceID detector bits correctly with the 'streaming' formatCloses lhcb/Boole#11
Requires lhcb/LHCb!3766Closes lhcb/Boole#11
Requires lhcb/LHCb!3766Rosen MatevRosen Matevhttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/407Clean up FT info in MCTrackInfo2022-09-19T13:24:57+02:00Louis Henrylouis.henry@cern.chClean up FT info in MCTrackInfoMostly superceded by !411.
Makes the namings and conventions more explicit.Mostly superceded by !411.
Makes the namings and conventions more explicit.Rosen MatevRosen Matevhttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/406Clean up tests and update sample/tags2022-09-12T09:26:58+02:00Rosen MatevClean up tests and update sample/tagsBehaviour changes:
- Remove extra VP (superpixel) banks when writing MDF data
Test cleanups and improvements
- Update tests to use a recent sim sample and tags (see LHCBGAUSS-2635)
- Remove redundant Rich-RealDataFormat test
- Reduce nu...Behaviour changes:
- Remove extra VP (superpixel) banks when writing MDF data
Test cleanups and improvements
- Update tests to use a recent sim sample and tags (see LHCBGAUSS-2635)
- Remove redundant Rich-RealDataFormat test
- Reduce number of events used for dump-vp-rawbank test
- Replace xdigi reprocessing test with two tests (first produce, then reprocess)
- Remove boolesys test (subset of boole-upgrade-baseline)
- Remove xdst tests (to be restored when we can produce dsts)
- Remove obsolete VPRetinaCluster tests (now default behaviour)
- Add tests to dump and check raw data (e.g. source ID conformance to Online specs)
- Update references
Needs lhcb-datapkg/PRConfig!254
/cc @edelucia @gcavalle @gcorti @kreps @cattanem @jonrobRosen MatevRosen Matevhttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/404RICH monitoring tuning2022-10-07T16:27:39+02:00Bartosz MaleckiRICH monitoring tuningMinor updates in the RICH monitoring histograms (typo fix in histogram name and tuning of the histogram ranges).Minor updates in the RICH monitoring histograms (typo fix in histogram name and tuning of the histogram ranges).Sebastien PonceBartosz MaleckiSebastien Poncehttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/389Refactored Muon{Background,Digitization,DigitChecker} to work with both DetDe...2022-10-31T11:04:16+01:00Marco Clemencicmarco.clemencic@cern.chRefactored Muon{Background,Digitization,DigitChecker} to work with both DetDesc and DD4hep- refactored and cleaned up
- removed unused code
- made most methods const
- wrapped all detector related cache to a dedicated class instance
- fixed some multi-threading issues
Requires lhcb/LHCb!3596 lhcb/LHCb!3636 lhcb/Detector!219 ...- refactored and cleaned up
- removed unused code
- made most methods const
- wrapped all detector related cache to a dedicated class instance
- fixed some multi-threading issues
Requires lhcb/LHCb!3596 lhcb/LHCb!3636 lhcb/Detector!219 lhcb/Detector!204 lhcb/LHCb!3649 gaudi/Gaudi!1343
Partially addresses #9
Note that I had to partially revert d9f974923dd150f1876628615e668893ea6b8311 because without Boole configurables we cannot even try to start the tests.Rosen MatevAlessandro ScarabottoRosen Matevhttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/382Default to the real RICH data format2022-08-08T09:58:34+02:00Christopher Rob Jonesjonesc@hep.phy.cam.ac.ukDefault to the real RICH data formatRequires lhcb/LHCb!3718Requires lhcb/LHCb!3718https://gitlab.cern.ch/lhcb/Boole/-/merge_requests/374simplify interaction with LinkManager2022-01-19T15:23:32+01:00Gerhard Ravensimplify interaction with LinkManageravoid needing `friend` access to `LinkManager`, and having to rely on implementation details of `LinkManager`avoid needing `friend` access to `LinkManager`, and having to rely on implementation details of `LinkManager`Rosen MatevMarco CattaneoRosen Matevhttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/366FT new crosstalk model2022-09-19T13:24:59+02:00Emmy GabrielFT new crosstalk modelThe direct and delayed crosstalk model for the scifi is changed from a poisson distribution to a power law model following studies by Blake Leverington (details [here](https://indico.cern.ch/event/960125/contributions/4130563/attachments...The direct and delayed crosstalk model for the scifi is changed from a poisson distribution to a power law model following studies by Blake Leverington (details [here](https://indico.cern.ch/event/960125/contributions/4130563/attachments/2152589/3630094/Crosstalk%20simulation.pdf))Rosen MatevRosen Matevhttps://gitlab.cern.ch/lhcb/Boole/-/merge_requests/335SciFi simulation effective noise model2022-09-19T13:24:59+02:00Emmy GabrielSciFi simulation effective noise model- Updated effective noise model
- Update electronics response functions
- Some values in the simulation are updated
- Added FTClusterTuple ('old' FTClusterTuple is now FTLiteClusterTuple)
Details in attached presentation: [2021-04-19-M...- Updated effective noise model
- Update electronics response functions
- Some values in the simulation are updated
- Added FTClusterTuple ('old' FTClusterTuple is now FTLiteClusterTuple)
Details in attached presentation: [2021-04-19-MR.pdf](/uploads/1ca1ffac2a2268da454f6a08624d433a/2021-04-19-MR.pdf)Rosen MatevGiovanni CavalleroEmmy GabrielRosen Matev