From b5d264803ba10887775643d6b5c3b3b6c8e0c00d Mon Sep 17 00:00:00 2001 From: Xiaofan Hu Date: Fri, 6 May 2022 08:39:30 +0200 Subject: [PATCH 1/4] fixing errors from MCTrackInfo without UT --- Digi/Boole/python/Boole/Configuration.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Digi/Boole/python/Boole/Configuration.py b/Digi/Boole/python/Boole/Configuration.py index 2d259898..27126079 100755 --- a/Digi/Boole/python/Boole/Configuration.py +++ b/Digi/Boole/python/Boole/Configuration.py @@ -521,8 +521,9 @@ class Boole(LHCbConfigurableUser): else: raise RuntimeError("Need VP to build MCTrackInfo") - if "UT" in linkDets: - buildMCTrackInfo.WithUT = True + if True: + # To make buildMCTrackInfo.WithUT always False. It used to be True if "UT" in linkDets + buildMCTrackInfo.WithUT = False else: raise RuntimeError("Need one of TT or UT to build MCTrackInfo") -- GitLab From 49769b0292bfe0db52b476ff707a93e429d03d3c Mon Sep 17 00:00:00 2001 From: Xiaofan Hu Date: Mon, 9 May 2022 11:43:14 +0200 Subject: [PATCH 2/4] replace the RuntimeError from buildMCTrackInfo.WithUT with warning --- Digi/Boole/python/Boole/Configuration.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/Digi/Boole/python/Boole/Configuration.py b/Digi/Boole/python/Boole/Configuration.py index 27126079..aeb8bd7c 100755 --- a/Digi/Boole/python/Boole/Configuration.py +++ b/Digi/Boole/python/Boole/Configuration.py @@ -32,9 +32,9 @@ class Boole(LHCbConfigurableUser): "DATA": ['Data'], "MUON": ['Muon'] }, - "DetectorDigi": ['VP', 'UT', 'FT', 'Rich', 'Calo', 'Muon'], - "DetectorLink": ['VP', 'UT', 'FT', 'Tr', 'Rich', 'Calo', 'Muon'], - "DetectorMoni": ['VP', 'UT', 'FT', 'Rich', 'Calo', 'Muon', 'MC'], + "DetectorDigi": ['VP', 'FT', 'Rich', 'Calo', 'Muon'], + "DetectorLink": ['VP', 'FT', 'Tr', 'Rich', 'Calo', 'Muon'], + "DetectorMoni": ['VP', 'FT', 'Rich', 'Calo', 'Muon', 'MC'], "EvtMax": -1, "SkipEvents": 0, "UseSpillover": False, @@ -521,11 +521,11 @@ class Boole(LHCbConfigurableUser): else: raise RuntimeError("Need VP to build MCTrackInfo") - if True: - # To make buildMCTrackInfo.WithUT always False. It used to be True if "UT" in linkDets - buildMCTrackInfo.WithUT = False + if "UT" in linkDets: + buildMCTrackInfo.WithUT = True else: - raise RuntimeError("Need one of TT or UT to build MCTrackInfo") + buildMCTrackInfo.WithUT = False + log.warning("no UT to build MCTrackInfo") if "FT" in linkDets: buildMCTrackInfo.WithFT = True -- GitLab From 8d65e2da2eaf96d88f3b79d10f0d483ec37d01ae Mon Sep 17 00:00:00 2001 From: Xiaofan Hu Date: Fri, 27 May 2022 11:27:58 +0200 Subject: [PATCH 3/4] revert previous changes --- Digi/Boole/python/Boole/Configuration.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/Digi/Boole/python/Boole/Configuration.py b/Digi/Boole/python/Boole/Configuration.py index aeb8bd7c..2d259898 100755 --- a/Digi/Boole/python/Boole/Configuration.py +++ b/Digi/Boole/python/Boole/Configuration.py @@ -32,9 +32,9 @@ class Boole(LHCbConfigurableUser): "DATA": ['Data'], "MUON": ['Muon'] }, - "DetectorDigi": ['VP', 'FT', 'Rich', 'Calo', 'Muon'], - "DetectorLink": ['VP', 'FT', 'Tr', 'Rich', 'Calo', 'Muon'], - "DetectorMoni": ['VP', 'FT', 'Rich', 'Calo', 'Muon', 'MC'], + "DetectorDigi": ['VP', 'UT', 'FT', 'Rich', 'Calo', 'Muon'], + "DetectorLink": ['VP', 'UT', 'FT', 'Tr', 'Rich', 'Calo', 'Muon'], + "DetectorMoni": ['VP', 'UT', 'FT', 'Rich', 'Calo', 'Muon', 'MC'], "EvtMax": -1, "SkipEvents": 0, "UseSpillover": False, @@ -524,8 +524,7 @@ class Boole(LHCbConfigurableUser): if "UT" in linkDets: buildMCTrackInfo.WithUT = True else: - buildMCTrackInfo.WithUT = False - log.warning("no UT to build MCTrackInfo") + raise RuntimeError("Need one of TT or UT to build MCTrackInfo") if "FT" in linkDets: buildMCTrackInfo.WithFT = True -- GitLab From 6d73ec321d77cc644de2d312d1549b5881a89ea6 Mon Sep 17 00:00:00 2001 From: Xiaofan Hu Date: Wed, 1 Jun 2022 10:19:52 +0200 Subject: [PATCH 4/4] keep the change of warning --- Digi/Boole/python/Boole/Configuration.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Digi/Boole/python/Boole/Configuration.py b/Digi/Boole/python/Boole/Configuration.py index 2d259898..82047d88 100755 --- a/Digi/Boole/python/Boole/Configuration.py +++ b/Digi/Boole/python/Boole/Configuration.py @@ -524,7 +524,8 @@ class Boole(LHCbConfigurableUser): if "UT" in linkDets: buildMCTrackInfo.WithUT = True else: - raise RuntimeError("Need one of TT or UT to build MCTrackInfo") + buildMCTrackInfo.WithUT = False + log.warning("No UT to build MCTrackInfo") if "FT" in linkDets: buildMCTrackInfo.WithFT = True -- GitLab