[HltEfficiencyChecker]: Restore HLT1 True Sim efficiencies
Note: HltEfficiencyChecker is being moved from MooreAnalysis to DaVinci in !1005 (merged). This issue only becomes relevant to DaVinci once that is merged
- MooreAnalysis!116 (merged) removed tupling from HLT1 in HltEfficiencyChecker if no events were selected. This was because, in that chain of MRs, this error appeared:
HltSelReportsDecoder_3ce0f8f9 ERROR HltSelRepRawBank : sub-bank index out of range in HltSelRepRawBank
HltSelReportsDecoder_3ce0f8f9 ERROR Maximum number of errors ( 'ErrorMax':1) reached.
HLTControlFlowMgr FATAL Event failed in Node FunTupleBase_MCParticles/MCFunTuple : Error in algorithm execute
- This error is related to reading of sel reports to compute Hlt1 True Sim efficiencies.
- Migrating to FunTuple (MooreAnalysis!122 (merged)) hasn't made this go away, and we need the control flow in HltEfficiencyChecker to go back to
NONLAZY_AND
, i.e. tupling for every event regardless of whether triggers fired. Therefore in MooreAnalysis!122 (merged) I won't put back true sim efficiencies for HLT1. - The error should be further investigated to put back these efficiencies. Normal, "DEC" efficiencies for HLT1 will be fine and available to the user.