DaVinci merge requestshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests2022-05-31T09:09:46+02:00https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/701DaVinciDependencies.cmake: remove dependency on legacy package TurboStreamProd2022-05-31T09:09:46+02:00Eduardo RodriguesDaVinciDependencies.cmake: remove dependency on legacy package TurboStreamProdEduardo RodriguesEduardo Rodrigueshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/516DaVinci job structure with PyConf2021-04-21T16:18:14+02:00Maurizio MartinelliDaVinci job structure with PyConfPrepared a DaVinci job configuration with PyConf following the structure outlined in #2.
Together with the changes in the configuration, also an example is provided.
Further work on DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/iss...Prepared a DaVinci job configuration with PyConf following the structure outlined in #2.
Together with the changes in the configuration, also an example is provided.
Further work on DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/48.
Closes https://gitlab.cern.ch/lhcb/DaVinci/-/issues/2.https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/631davinci script - adding create_options_template command2022-01-31T13:48:18+01:00Davide Fazzinidavinci script - adding create_options_template commandImproving the `davinci` script with two new features:
- possibility to use shortcuts instead of the full name when calling an option via command line \
(e.g. `-i` instead of `--inputfiledb`)
- new command `create_option_templates` for ...Improving the `davinci` script with two new features:
- possibility to use shortcuts instead of the full name when calling an option via command line \
(e.g. `-i` instead of `--inputfiledb`)
- new command `create_option_templates` for creating a template of the two options files that are usually used in a DaVinci job:
- `./run davinci create-options-template job -f test_jobopt_template.yaml` (for the joboptfile)
- `./run davinci create-options-template data -f test_inputdb_template.yaml -k key_template` (for the inputfiledb)
The new command allows also to fill the template interactively (via the `-i` argument) asking the user to insert the value for each option. \
In addition, some unit tests are added to verify the correct behavior of the new features.
Addresses #27.
Work on DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/180.Patrick KoppenburgDavide FazziniPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/766Delete obsoleted Phys/DaVinci/options/jobOptions-Example.* files2022-10-10T11:19:28+02:00Eduardo RodriguesDelete obsoleted Phys/DaVinci/options/jobOptions-Example.* filesEduardo RodriguesEduardo Rodrigueshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/730DV change default raw_event_format to 0.52022-10-10T11:45:28+02:00Abhijit MathadDV change default raw_event_format to 0.5See https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3687 (to be tested with this also).See https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3687 (to be tested with this also).Nicole SkidmoreNicole Skidmorehttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/531Excluding python module path from QMtest validation2021-04-22T11:14:19+02:00Davide FazziniExcluding python module path from QMtest validationExcluding from QM test validation, the line printed when importing python module in DaVinci since it depends on the install area.Excluding from QM test validation, the line printed when importing python module in DaVinci since it depends on the install area.Davide FazziniDavide Fazzinihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/660Finalize unit test coverage2023-05-23T16:14:08+02:00Davide FazziniFinalize unit test coverageUpdating python unit tests reaching 100% coverage.
Work on grand DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/179.Updating python unit tests reaching 100% coverage.
Work on grand DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/179.Patrick KoppenburgDavide FazziniPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/722Finish migration of tests to use lbexec2022-07-14T21:53:32+02:00Chris BurrFinish migration of tests to use lbexecFinished the work started in https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/709.
For reference - related to DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/180.Finished the work started in https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/709.
For reference - related to DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/180.Chris BurrChris Burrhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/755Fix a cyclic import among 2 config related files2022-10-10T11:49:40+02:00Eduardo RodriguesFix a cyclic import among 2 config related filesI started by getting rid of the `Configuration.py` file that has at this moment a single function used in a single file, namely `config.py`. In moving the one function over I noticed that the former file imported 2 functions from the lat...I started by getting rid of the `Configuration.py` file that has at this moment a single function used in a single file, namely `config.py`. In moving the one function over I noticed that the former file imported 2 functions from the latter, and the latter imported the one function in the former. This was an ugly cyclic import, in a way. All simplified and fixed here :).Eduardo RodriguesEduardo Rodrigueshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/505Fixes of a test and many Flake8 warnings2021-02-26T16:15:45+01:00Eduardo RodriguesFixes of a test and many Flake8 warningsFixes a test following big MR https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/499 and gets rid of a whole bunch of Flake8 warnings one would get if switching linting for all Python files, which can be tested with
`flake8 --exclude ...Fixes a test following big MR https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/499 and gets rid of a whole bunch of Flake8 warnings one would get if switching linting for all Python files, which can be tested with
`flake8 --exclude '*.opts.py' --select=F,E71,E9,W1,W6 `find Phys/DaVinci -name '*.py'``.
Better only switch on the linting for all Python files once we converge on what PyConf & co business to keep, I guess, as otherwise there would be quite a few more things to fix.
Addressing partially https://gitlab.cern.ch/lhcb-dpa/project/-/issues/89.
FYI @dfazzini, @mamartin and @pkoppenb.Eduardo RodriguesEduardo Rodrigueshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1033Fix .gitlab-ci.yml for the build to work with LCG 1052024-02-13T16:57:28+01:00Eduardo RodriguesFix .gitlab-ci.yml for the build to work with LCG 105Indeed better to fix the failing build asap and this bit part of https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1029 would take longer to merge. This can go in asap to fix the builds.Indeed better to fix the failing build asap and this bit part of https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1029 would take longer to merge. This can go in asap to fix the builds.Eduardo RodriguesEduardo Rodrigueshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/602Fix issue for reading hlt2 files2021-12-14T09:20:39+01:00Davide FazziniFix issue for reading hlt2 filesFix issue related to the wrong unpacking of the hlt2 mc particles and vertices. To be merged together to LHCb!3352.
A new qmtest is added for reading a hlt2 .dst and creating a tuple with FunTuple.
Work on DPA task https://gitlab.cern.c...Fix issue related to the wrong unpacking of the hlt2 mc particles and vertices. To be merged together to LHCb!3352.
A new qmtest is added for reading a hlt2 .dst and creating a tuple with FunTuple.
Work on DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/180. Somewhat related to https://gitlab.cern.ch/lhcb-dpa/project/-/issues/179.Davide FazziniDavide Fazzinihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/506Fix Phys/DaVinci for Python 32021-04-21T16:17:53+02:00Eduardo RodriguesFix Phys/DaVinci for Python 3FYI @dfazzini.FYI @dfazzini.Eduardo RodriguesEduardo Rodrigueshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/644Fix typo in jobOptions-Example.py2022-02-04T16:59:16+01:00Eduardo RodriguesFix typo in jobOptions-Example.pyDoes this mean that this file is not tested anywhere @dfazzini?Does this mean that this file is not tested anywhere @dfazzini?Eduardo RodriguesPatrick KoppenburgEduardo Rodrigueshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/995Follow https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4356 and https://git...2023-12-07T10:43:50+01:00Abhijit MathadFollow https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4356 and https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/1022To be tested with: https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4356 and https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/1022To be tested with: https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4356 and https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/1022Abhijit MathadAbhijit Mathadhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1061Follow https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4496 (Remove data_ty...2024-03-26T10:00:02+01:00Abhijit MathadFollow https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4496 (Remove data_type option)
Test with: https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4496, https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3209, https://gitlab.cern.ch/lhcb-datapkg/AppConfig/-/merge_requests/233
Closes https://gitlab.cern.ch/lhcb/DaVinci/-...
Test with: https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4496, https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3209, https://gitlab.cern.ch/lhcb-datapkg/AppConfig/-/merge_requests/233
Closes https://gitlab.cern.ch/lhcb/DaVinci/-/issues/176Abhijit MathadAbhijit Mathadhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/735Follow lbexec changes2022-10-10T11:45:07+02:00Chris BurrFollow lbexec changesGoes alongside https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3725Goes alongside https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3725Chris BurrChris Burrhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/497Follow snake_case naming conventions rather than camelCase2021-01-28T19:16:09+01:00Eduardo RodriguesFollow snake_case naming conventions rather than camelCaseI noticed that we're not really following what seems to be the preferred naming conventions for upgrade code, hence this MR to improve on that from the onset. This is just a few first changes to make sure everyone is happy - @pkoppenb an...I noticed that we're not really following what seems to be the preferred naming conventions for upgrade code, hence this MR to improve on that from the onset. This is just a few first changes to make sure everyone is happy - @pkoppenb and @dfazzini.
I'm profiting from the occasion to make the main configuration functions available from the top level, to run as `gaudirun.py DaVinci:data` rather than `gaudirun.py DaVinci.ConfigurationUpgrade:data`, as agreed.
Hopefully we can converge here and have it all merged for Monday for the hackathon.Patrick KoppenburgDavide FazziniPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1045Follow-up from https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/44042024-03-05T19:20:08+01:00Eduardo RodriguesFollow-up from https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4404FYI @graven and @eleckste.
While at it I believe I got rid of some trivial failures sitting there in other platforms since a while.FYI @graven and @eleckste.
While at it I believe I got rid of some trivial failures sitting there in other platforms since a while.Eduardo RodriguesEduardo Rodrigueshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1013Follow up on particle PV pointer, offline PV unbiasing example2024-03-22T16:00:46+01:00Wouter Hulsbergenwouterh@nikhef.nlFollow up on particle PV pointer, offline PV unbiasing exampleTo go with LHCb!4299, Rec!3665, Moore!2658
Example of PV unbiasing, using PV constraints in DTF.
Closing Moore#608To go with LHCb!4299, Rec!3665, Moore!2658
Example of PV unbiasing, using PV constraints in DTF.
Closing Moore#608