DaVinci merge requestshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests2020-08-07T11:45:19+02:00https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/394Add TurboStream and StrippingStream properties2020-08-07T11:45:19+02:00Michael Thomas AlexanderAdd TurboStream and StrippingStream propertiesPort of !379 from run2-patches to master.
@erodrigu - slightly later than promised, but here it is.Port of !379 from run2-patches to master.
@erodrigu - slightly later than promised, but here it is.https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/397Updated configuration to run on Upgrade data types only2020-08-07T11:48:13+02:00Maurizio MartinelliUpdated configuration to run on Upgrade data types onlyChanged default list of datatypes and added a legacy list for pointing the user to older releases.
Can be completed by further cleaning up of instructions to correctly configure Run1-2 detectors.Changed default list of datatypes and added a legacy list for pointing the user to older releases.
Can be completed by further cleaning up of instructions to correctly configure Run1-2 detectors.Maurizio MartinelliPatrick KoppenburgMaurizio Martinellihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/402Removed most option files and added some new2020-08-07T11:49:24+02:00Patrick KoppenburgRemoved most option files and added some newI removed all option files in Phys/DaVinci that cannot run any more. They were inherited from a time when tests did not exist. I added a test file with K*mumu from Mark Whitehead. That should probably become a test.I removed all option files in Phys/DaVinci that cannot run any more. They were inherited from a time when tests did not exist. I added a test file with K*mumu from Mark Whitehead. That should probably become a test.Eduardo RodriguesPatrick KoppenburgEduardo Rodrigueshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/408Remove L0 to Hlt conversion2020-08-07T11:46:42+02:00Patrick KoppenburgRemove L0 to Hlt conversionTisTos requires L0 banks to be converted to Hlt DecReports and SelReports. This is no longer needed in Run 3.TisTos requires L0 banks to be converted to Hlt DecReports and SelReports. This is no longer needed in Run 3.Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/432Skeleton of the new configuration for the Upgrade2020-12-10T16:15:52+01:00Davide FazziniSkeleton of the new configuration for the UpgradeImplementation of a new skeleton configuration file for the run-3 DaVinci application exploiting the GaudiConfig2 framework.
Note that only a subset of what is needed wil lbe put here. Subsequent PRs will complete the full design, which ...Implementation of a new skeleton configuration file for the run-3 DaVinci application exploiting the GaudiConfig2 framework.
Note that only a subset of what is needed wil lbe put here. Subsequent PRs will complete the full design, which requires also developments on the Gaudi side.
See issue https://gitlab.cern.ch/lhcb-dpa/project/-/issues/48.
DaVinci job with Upgrade configuration can be run using the following command lines:
- `./run gaudirun.py DaVinci.Configuration:mc` (for MC files)
- `./run gaudirun.py DaVinci.Configuration:data` (for data files)Patrick KoppenburgDavide FazziniPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/446Move instantiation of LoKi service from Phys to DaVinci2020-11-03T16:36:52+01:00Eduardo RodriguesMove instantiation of LoKi service from Phys to DaVinciDepends on https://gitlab.cern.ch/lhcb/Phys/-/merge_requests/808.
Relates to DPA work see https://gitlab.cern.ch/lhcb-dpa/project/-/issues/48.Depends on https://gitlab.cern.ch/lhcb/Phys/-/merge_requests/808.
Relates to DPA work see https://gitlab.cern.ch/lhcb-dpa/project/-/issues/48.https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/458Further move bits from AnalysisConf to the DaVinci configurable2020-11-10T11:36:56+01:00Eduardo RodriguesFurther move bits from AnalysisConf to the DaVinci configurableDepends on https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/713.Depends on https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/713.Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/469Move remnant functionality in AnalysisConf to the DaVinci configurable2020-11-15T17:51:16+01:00Eduardo RodriguesMove remnant functionality in AnalysisConf to the DaVinci configurableSee related PR https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/722.
With this PR AnalysisConf in Analysis is gone.See related PR https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/722.
With this PR AnalysisConf in Analysis is gone.Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/474Adapted to (semi)functional (Un)PackCaloHypo2020-11-21T17:15:13+01:00Sebastien PonceAdapted to (semi)functional (Un)PackCaloHypoGoes together with LHCb!2836, Rec!2266 and Moore!666Goes together with LHCb!2836, Rec!2266 and Moore!666https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/497Follow snake_case naming conventions rather than camelCase2021-01-28T19:16:09+01:00Eduardo RodriguesFollow snake_case naming conventions rather than camelCaseI noticed that we're not really following what seems to be the preferred naming conventions for upgrade code, hence this MR to improve on that from the onset. This is just a few first changes to make sure everyone is happy - @pkoppenb an...I noticed that we're not really following what seems to be the preferred naming conventions for upgrade code, hence this MR to improve on that from the onset. This is just a few first changes to make sure everyone is happy - @pkoppenb and @dfazzini.
I'm profiting from the occasion to make the main configuration functions available from the top level, to run as `gaudirun.py DaVinci:data` rather than `gaudirun.py DaVinci.ConfigurationUpgrade:data`, as agreed.
Hopefully we can converge here and have it all merged for Monday for the hackathon.Patrick KoppenburgDavide FazziniPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/499Implementation of advanced features in Upgrade Configurable2021-02-25T09:59:18+01:00Davide FazziniImplementation of advanced features in Upgrade ConfigurableImplementing advanced features in DaVinci Configurable for Upgrade.
List of the new features:
- enabling the possibility to pass arguments from the command line
- adding a new DaVinci property for passing the python file containing the u...Implementing advanced features in DaVinci Configurable for Upgrade.
List of the new features:
- enabling the possibility to pass arguments from the command line
- adding a new DaVinci property for passing the python file containing the user algorithms
- adding the configuration of unpacking and MC association for simulated samples;
(for the moment it is implemented similarly to the old configuration, it will be updated in a future MR. See https://gitlab.cern.ch/lhcb-dpa/project/-/issues/63)
- adding functions for propagating the FSRs
- getting rid of the GaudiSequences
- implement the Moore selection framework
- adding a few extra useful functions
Further addressing https://gitlab.cern.ch/lhcb-dpa/project/-/issues/48.Eduardo RodriguesPatrick KoppenburgDavide FazziniEduardo Rodrigueshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/502Proof-of-concept for how to use PyConf to configure DaVinci2021-02-24T13:45:35+01:00Maurizio MartinelliProof-of-concept for how to use PyConf to configure DaVinciUse PyConf to configure DaVinci. The code relies on many lines written by the HLT group.
This proof-of-concept will serve as a good and reasonably solid starting point.Use PyConf to configure DaVinci. The code relies on many lines written by the HLT group.
This proof-of-concept will serve as a good and reasonably solid starting point.Eduardo RodriguesPatrick KoppenburgEduardo Rodrigueshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/505Fixes of a test and many Flake8 warnings2021-02-26T16:15:45+01:00Eduardo RodriguesFixes of a test and many Flake8 warningsFixes a test following big MR https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/499 and gets rid of a whole bunch of Flake8 warnings one would get if switching linting for all Python files, which can be tested with
`flake8 --exclude ...Fixes a test following big MR https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/499 and gets rid of a whole bunch of Flake8 warnings one would get if switching linting for all Python files, which can be tested with
`flake8 --exclude '*.opts.py' --select=F,E71,E9,W1,W6 `find Phys/DaVinci -name '*.py'``.
Better only switch on the linting for all Python files once we converge on what PyConf & co business to keep, I guess, as otherwise there would be quite a few more things to fix.
Addressing partially https://gitlab.cern.ch/lhcb-dpa/project/-/issues/89.
FYI @dfazzini, @mamartin and @pkoppenb.Eduardo RodriguesEduardo Rodrigueshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/506Fix Phys/DaVinci for Python 32021-04-21T16:17:53+02:00Eduardo RodriguesFix Phys/DaVinci for Python 3FYI @dfazzini.FYI @dfazzini.Eduardo RodriguesEduardo Rodrigueshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/507Adapt PyConf API to snake_case convention2021-03-02T18:19:08+01:00Eduardo RodriguesAdapt PyConf API to snake_case conventionDepends on https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/2948.
Relates to https://gitlab.cern.ch/lhcb-dpa/project/-/issues/89.Depends on https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/2948.
Relates to https://gitlab.cern.ch/lhcb-dpa/project/-/issues/89.Eduardo RodriguesPatrick KoppenburgEduardo Rodrigueshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/508DaVinci based on PyConf - work on structure, enhancements, new modules2021-04-21T16:17:29+02:00Eduardo RodriguesDaVinci based on PyConf - work on structure, enhancements, new modulesVarious files introduced, others reworked a bit. FYI @mamartin and @dfazzini.
Lots taken/adapted from Moore's code and dependents.
Work related to DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/48.Various files introduced, others reworked a bit. FYI @mamartin and @dfazzini.
Lots taken/adapted from Moore's code and dependents.
Work related to DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/48.Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/514Integration of PyConf in the new DaVinci configuration2021-04-21T16:18:03+02:00Davide FazziniIntegration of PyConf in the new DaVinci configurationIntegrate the PyConf control flow in the new DaVinci configuration.
Work related to DPA's master task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/48.Integrate the PyConf control flow in the new DaVinci configuration.
Work related to DPA's master task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/48.Davide FazziniDavide Fazzinihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/516DaVinci job structure with PyConf2021-04-21T16:18:14+02:00Maurizio MartinelliDaVinci job structure with PyConfPrepared a DaVinci job configuration with PyConf following the structure outlined in #2.
Together with the changes in the configuration, also an example is provided.
Further work on DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/iss...Prepared a DaVinci job configuration with PyConf following the structure outlined in #2.
Together with the changes in the configuration, also an example is provided.
Further work on DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/48.
Closes https://gitlab.cern.ch/lhcb/DaVinci/-/issues/2.https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/531Excluding python module path from QMtest validation2021-04-22T11:14:19+02:00Davide FazziniExcluding python module path from QMtest validationExcluding from QM test validation, the line printed when importing python module in DaVinci since it depends on the install area.Excluding from QM test validation, the line printed when importing python module in DaVinci since it depends on the install area.Davide FazziniDavide Fazzinihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/535Simplify user algs functions2021-07-01T16:10:45+02:00Davide FazziniSimplify user algs functionsSimplify how the user algorithms are imported in a DaVinci job: the responsibility of the creating dedicated DV nodes is moved from the user to DaVinci.
Improve the way how the LHCbConfigurableUser dependencies are handled and imported ...Simplify how the user algorithms are imported in a DaVinci job: the responsibility of the creating dedicated DV nodes is moved from the user to DaVinci.
Improve the way how the LHCbConfigurableUser dependencies are handled and imported in Gaudi application.\
Implement the possibility to import configurables from both the old and the new Gaudi framework.
Work on DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/48.Patrick KoppenburgDavide FazziniPatrick Koppenburg