DaVinci merge requestshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests2024-03-08T16:23:51+01:00https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1039Add Functor Collection with Charged Calo Information2024-03-08T16:23:51+01:00Albert Lopez HuertasAdd Functor Collection with Charged Calo InformationThis Functor Collection contains all the variables related to Charged Calo Information, including also PID variables from Calo, used in electron analyses.
FYI: @cmarinbe @lcalefic @pvidrier @palaguarThis Functor Collection contains all the variables related to Charged Calo Information, including also PID variables from Calo, used in electron analyses.
FYI: @cmarinbe @lcalefic @pvidrier @palaguarAlbert Lopez HuertasAlbert Lopez Huertashttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1022Move FunTuple to DaVinci2024-02-13T16:57:48+01:00Abhijit MathadMove FunTuple to DaVinciMoving FunTuple to DV.
Test with: https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/1049Moving FunTuple to DV.
Test with: https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/1049Abhijit MathadAbhijit Mathadhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1018Update hlt2 line for the veloSP integration test2024-01-29T12:00:26+01:00Davide FazziniUpdate hlt2 line for the veloSP integration testFix the option file for the final step of the veloSP integration test. This MR updates the corresponding Hlt2 line for retrieving the particles for the final tuples, since the previous location is now empty.Fix the option file for the final step of the veloSP integration test. This MR updates the corresponding Hlt2 line for retrieving the particles for the final tuples, since the previous location is now empty.Eduardo RodriguesDavide FazziniEduardo Rodrigueshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1000OriginFlag functor for FT2024-01-29T11:44:03+01:00Sara CelaniOriginFlag functor for FTUpdated the DaVinci options for Flavour Tagging variables to check that the new OriginFlag functor (which should give the true origin of the tagging particles) works.
To be tested with: [lhcb/Rec!3651](https://gitlab.cern.ch/lhcb/Rec/-...Updated the DaVinci options for Flavour Tagging variables to check that the new OriginFlag functor (which should give the true origin of the tagging particles) works.
To be tested with: [lhcb/Rec!3651](https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3651) and https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/1043Abhijit MathadPeilian LiAbhijit Mathadhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/995Follow https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4356 and https://git...2023-12-07T10:43:50+01:00Abhijit MathadFollow https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4356 and https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/1022To be tested with: https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4356 and https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/1022To be tested with: https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4356 and https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/1022Abhijit MathadAbhijit Mathadhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/991Resolve "Update DV configuration for Turbo with `persistreco =True`"2024-01-22T12:36:10+01:00Davide FazziniResolve "Update DV configuration for Turbo with `persistreco =True`"Closes #134Closes #134Davide FazziniDavide Fazzinihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/990Resolve "Follow-up from "Test service to write luminosity information to TTre...2023-12-07T10:47:31+01:00Edoardo FranzosoResolve "Follow-up from "Test service to write luminosity information to TTree when reading from FSRs""Update test to validate the lumi tree creation when no events pass the DV selection.
Depends on [https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4344](https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4344).
Closes #136Update test to validate the lumi tree creation when no events pass the DV selection.
Depends on [https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4344](https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4344).
Closes #136Abhijit MathadEdoardo FranzosoAbhijit Mathadhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/987Update xgen input file location2023-10-27T13:49:50+02:00Davide FazziniUpdate xgen input file locationUpdate the test input file locations from `/eos/lhcb/wg/dpa/wp3/testDV_read_xgen/` and `/eos/lhcb/wg/dpa/wp3/NovemberFEST/` into `/eos/lhcb/wg/dpa/wp3/tests/`.
Relates to #95.Update the test input file locations from `/eos/lhcb/wg/dpa/wp3/testDV_read_xgen/` and `/eos/lhcb/wg/dpa/wp3/NovemberFEST/` into `/eos/lhcb/wg/dpa/wp3/tests/`.
Relates to #95.Davide FazziniDavide Fazzinihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/986Add an extra check for []CC in the decay descriptor of FunTuple2024-01-22T12:41:27+01:00Jiahui ZhuoAdd an extra check for []CC in the decay descriptor of FunTupleAddressing the issue https://gitlab.cern.ch/lhcb/Analysis/-/issues/47#note_7219259
This MR adds a DaVinci test for https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/1018
To be tested with: https://gitlab.cern.ch/lhcb/Rec/-/merge_re...Addressing the issue https://gitlab.cern.ch/lhcb/Analysis/-/issues/47#note_7219259
This MR adds a DaVinci test for https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/1018
To be tested with: https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3637 https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/1018
Solve the issue: https://gitlab.cern.ch/lhcb/Analysis/-/issues/47#note_7219259
FYI: @pkoppenb @erodrigu @amathadJiahui ZhuoJiahui Zhuohttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/985Fix example for spruced data2023-10-27T13:49:50+02:00Davide FazziniFix example for spruced dataRemove unused option file: `option_davinci_tupling_from_data.py` and `example_data/Spruce_Run251342.yaml` in DaVinciExamples.
The file `option_davinci_tupling_from_data.py` was a copy of `option_davinci_tupling_from_raw_data.py` running ...Remove unused option file: `option_davinci_tupling_from_data.py` and `example_data/Spruce_Run251342.yaml` in DaVinciExamples.
The file `option_davinci_tupling_from_data.py` was a copy of `option_davinci_tupling_from_raw_data.py` running over a spruced line instead of a Hlt2 line. However the related input file was simulation and not real data.
Replacing the codes with a more updated working and tested example.
Fixing also the doc string of the [option_davinci_tupling_from_raw_data.py](https://gitlab.cern.ch/lhcb/DaVinci/-/blob/master/DaVinciExamples/python/DaVinciExamples/tupling/option_davinci_tupling_from_raw_data.py) script, reporting the usage of the `Spruce_Run251342.yaml` option file while using the `Run255620.yaml` script in the related qmtest [test_davinci_tupling_from_raw_data.qmt](https://gitlab.cern.ch/lhcb/DaVinci/-/blob/master/DaVinciExamples/tests/qmtest/tupling.qms/test_davinci_tupling_from_raw_data.qmt).
Closes #139.Davide FazziniDavide Fazzinihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/981DV Tutorials and Examples pages now have a link to "Running DaVinci" section2023-10-13T15:44:26+02:00Maurizio MartinelliDV Tutorials and Examples pages now have a link to "Running DaVinci" sectionFollowing issue https://gitlab.cern.ch/lhcb/DaVinci/-/issues/150, the automatic documentation is modified to link "Running DaVinci" section.
In that section now also opening a `bash` shell with DaVinci environment is documented.Following issue https://gitlab.cern.ch/lhcb/DaVinci/-/issues/150, the automatic documentation is modified to link "Running DaVinci" section.
In that section now also opening a `bash` shell with DaVinci environment is documented.Maurizio MartinelliMaurizio Martinellihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/979Remove evt_pre_filters from the DaVinci options2023-10-05T14:04:34+02:00Davide FazziniRemove evt_pre_filters from the DaVinci optionsRemove the `evt_pre_filters` option since it is not compatible with the ThOr functors, as reported in #115.
Closes https://gitlab.cern.ch/lhcb/DaVinci/-/issues/115.Remove the `evt_pre_filters` option since it is not compatible with the ThOr functors, as reported in #115.
Closes https://gitlab.cern.ch/lhcb/DaVinci/-/issues/115.Abhijit MathadDavide FazziniAbhijit Mathadhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/978Fix the integration test on tuple from turbo with veloSP2023-10-05T14:05:56+02:00Davide FazziniFix the integration test on tuple from turbo with veloSPFix the integration test "Tupling_veloSP.TupleFromTurbo". Failure reported in LHCbIntegrationTests#5.
Closes LHCbIntegrationTests#5.Fix the integration test "Tupling_veloSP.TupleFromTurbo". Failure reported in LHCbIntegrationTests#5.
Closes LHCbIntegrationTests#5.Davide FazziniDavide Fazzinihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/975Fix documentation in tupling_relation_isovariables2023-09-28T14:24:07+02:00Tommaso Fulghesutommaso.fulghesu@cern.chFix documentation in tupling_relation_isovariablesFollowing [this thread](https://mattermost.web.cern.ch/lhcb/pl/3d8n7exo4tr4imcfbh76gma9bo ) in DPA WP3 mattermost channel (thanks @lugrazet for spotting the issue), hot fix to the documentation to avoid further similar issues in the future!Following [this thread](https://mattermost.web.cern.ch/lhcb/pl/3d8n7exo4tr4imcfbh76gma9bo ) in DPA WP3 mattermost channel (thanks @lugrazet for spotting the issue), hot fix to the documentation to avoid further similar issues in the future!Tommaso Fulghesutommaso.fulghesu@cern.chTommaso Fulghesutommaso.fulghesu@cern.chhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/970Add `[]CC` support to SubstitutePID tool2023-12-07T10:49:00+01:00Jiahui ZhuoAdd `[]CC` support to SubstitutePID toolhttps://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3581 Added the `[]CC` support to SubstitutePID tool, so we adapt the DaVinci tests for it.
Need to be tested with: https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4286 https://gitlab.ce...https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3581 Added the `[]CC` support to SubstitutePID tool, so we adapt the DaVinci tests for it.
Need to be tested with: https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4286 https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3581
FIY: @pkoppenb @amathad @erodriguJiahui ZhuoJiahui Zhuohttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/948Add options file for LHCbIntegrationTest2023-09-26T09:17:01+02:00Jordy Butterjordy.butter@cern.chAdd options file for LHCbIntegrationTestThis MR contains an options file for a simple flavour tagging integrationtest.
Link to corresponding MR:
- Integration test for Flavour Tagging variables (@jobutter https://gitlab.cern.ch/lhcb/LHCbIntegrationTests/-/merge_requests/45)
...This MR contains an options file for a simple flavour tagging integrationtest.
Link to corresponding MR:
- Integration test for Flavour Tagging variables (@jobutter https://gitlab.cern.ch/lhcb/LHCbIntegrationTests/-/merge_requests/45)
Let me know if the options file needs any changes. Thanks in advance!Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/937Test service to write luminosity information to TTree when reading from FSRs2023-09-12T09:52:06+02:00Elena GraveriniTest service to write luminosity information to TTree when reading from FSRsRelates to https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4174 and depends on and LHCb!4270 https://gitlab.cern.ch/lhcb/LHCb/-/issues/32 being dealt with.
Tagging @clemenci @nskidmor @erodrigu and luminosity people @fferrari @elniel...Relates to https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4174 and depends on and LHCb!4270 https://gitlab.cern.ch/lhcb/LHCb/-/issues/32 being dealt with.
Tagging @clemenci @nskidmor @erodrigu and luminosity people @fferrari @elniel @edallocc
What works:
- Unit test for service works fine (LHCb!4174 - test FileSummaryRecord.read_lumi_to_tree)
- Service `LHCb__FSR__LumiFSRtoTTree` is correctly invoked in test `DaVinciExamples.tupling.test_davinci_tupling_with_lumi_from_spruce` included in this MR
What does not: ➞ **ALL FIXED**
- `m_outputFiles` is not populated (https://gitlab.cern.ch/lhcb/LHCb/-/blob/egraveri_LumiFSRtoTTree/Kernel/FileSummaryRecord/src/mod/LumiFSRtoTTree.cpp#L68)
- Looks like incident `CONNECTED_OUTPUT` is not recognised?
- Can @clemenci look into this please?
TODOs: ➞ **ALL DONE**
- Test reference output to be adjusted when it runs w/o issue
- Add extra dst with different run number to inputs (@nskidmor)
- Toggle debug printouts offElena GraveriniEdoardo FranzosoElena Graverinihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/935Add a hash to avoid test failing2023-07-06T15:38:22+02:00Patrick KoppenburgAdd a hash to avoid test failingAddress test failure https://lhcb-nightlies.web.cern.ch/nightly/lhcb-master/2074/DaVinci/x86_64_v2-centos7-gcc12-dbg/testsAddress test failure https://lhcb-nightlies.web.cern.ch/nightly/lhcb-master/2074/DaVinci/x86_64_v2-centos7-gcc12-dbg/testsPatrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/930Update isolation DaVinciExample2023-08-07T10:41:29+02:00Tommaso Fulghesutommaso.fulghesu@cern.chUpdate isolation DaVinciExampleUpdate `option_davinci_tupling_relation_isovariables.py` and related qmt test to provide a concrete and more complete example that shows how to get the track isolation variables extra particles (long tracks and neutrals) saved in TES loc...Update `option_davinci_tupling_relation_isovariables.py` and related qmt test to provide a concrete and more complete example that shows how to get the track isolation variables extra particles (long tracks and neutrals) saved in TES location of the output file from the Hlt2 line `Hlt2RD_BdToKstTauMu_KstToKPi_TauTo3Pi_OS` implemented in https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2147.
The following example is planned to be extended by adding vertex isolation variables.
Since it is using another dst input, it should also address the issue presented [here](https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2418#note_6866800)
NEEDS: https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3444, https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/996
TODO:
- [x] move the input file b_to_ksttaumu.dst and the tck manifest file to a more proper location
- [x] update qmt test and complete exampleTommaso Fulghesutommaso.fulghesu@cern.chTommaso Fulghesutommaso.fulghesu@cern.chhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/923Remove duplicated raw data option file2023-07-12T13:37:11+02:00Davide FazziniRemove duplicated raw data option fileRemove `Run255620-Hlt2.yaml` option file since it is just a copy of `Run255620.yaml`. The only difference was the name of the output file that is now moved in the .qmt file of interest and passed with the `extra_options_yaml` keyword.Remove `Run255620-Hlt2.yaml` option file since it is just a copy of `Run255620.yaml`. The only difference was the name of the output file that is now moved in the .qmt file of interest and passed with the `extra_options_yaml` keyword.Davide FazziniDavide Fazzini