DaVinci merge requestshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests2023-07-24T10:57:45+02:00https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/897test rec_summary functor2023-07-24T10:57:45+02:00Samuel Belintest rec_summary functorTesting the RECSUMMARY_INFO functor in the test AllFunctors.py
Test to validate the functor added in merge request https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3332
Needs lhcb/Rec!3509
Merged into relevant branch of https://gitlab....Testing the RECSUMMARY_INFO functor in the test AllFunctors.py
Test to validate the functor added in merge request https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3332
Needs lhcb/Rec!3509
Merged into relevant branch of https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/926RTA/2023.07.31Samuel BelinSamuel Belinhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1063Fix for the merge of the genfsr2024-03-29T12:35:36+01:00Davide FazziniFix for the merge of the genfsrTemporary fix to the merging of the GenFSRs until the migration of the new FSRs.\
Following a discussion with @clemenci (see [here](https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1058#note_7795091)).Temporary fix to the merging of the GenFSRs until the migration of the new FSRs.\
Following a discussion with @clemenci (see [here](https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1058#note_7795091)).Davide FazziniDavide Fazzinihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1062Draft: Review content of functor collections2024-03-29T11:24:58+01:00Anfeng LiDraft: Review content of functor collectionssee https://gitlab.cern.ch/lhcb/DaVinci/-/issues/168
- [x] fix missing names in `__all__`
- [x] improvement of `MCHierarchy`
- [x] improvement of `MCReconstructible`
- [x] remove redundant information in `Kinematics`, `MCKinematics`, `D...see https://gitlab.cern.ch/lhcb/DaVinci/-/issues/168
- [x] fix missing names in `__all__`
- [x] improvement of `MCHierarchy`
- [x] improvement of `MCReconstructible`
- [x] remove redundant information in `Kinematics`, `MCKinematics`, `DecayTreeFitterResults`, `MCReconstructible`Anfeng LiAnfeng Lihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1052Draft: HLT1 SelReport fix for TrueSim efficiency studies2024-03-25T12:11:12+01:00Volodymyr Svintozelskyivolodymyr.svintozelskyi@cern.chDraft: HLT1 SelReport fix for TrueSim efficiency studiesCurrent MR addresses the issue #162.
It re-enables the HLT1 TrueSim efficiency algorithm and ensures the fetching of correct `SelReport`. Additionally, the decoding of the SelRep raw bank for the case when no event was triggered is fixed...Current MR addresses the issue #162.
It re-enables the HLT1 TrueSim efficiency algorithm and ensures the fetching of correct `SelReport`. Additionally, the decoding of the SelRep raw bank for the case when no event was triggered is fixed with the linked MR LHCb!4497. Therefore, these allow the tracking efficiency studies of HLT1 lines, which is crucial for upcoming downstream and faraway (viz. T-Track) studies.
However, after fixing issues as explained above, it became clear, that one has to fix also the bug hidden in `HltTrueSimEffAlg` and related to calo truth matching. The bug is caused by the existence of calo `LHCbIDs` in the `SelReport` output, for which the algorithm is not prepared. As a temporary solution, one may ignore those `LHCbIDs`, as described in a linked MR (Rec!3801).
Goes with Rec!3801, LHCb!4497.
FYI: @jzhuo @adeoyang @amathad @erodriguhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1049Draft: Make reconstruction objects accessible from spruced dst2024-03-22T18:17:42+01:00Davide FazziniDraft: Make reconstruction objects accessible from spruced dstFollowing [discussion](https://mattermost.web.cern.ch/lhcb/pl/j9t5yxwrxbybmdjs6zd5hhxreh) on DPA WP3 Mattermost channel.
Fix reconstruction binding for spruce case.
To be merged with Moore!3185.Following [discussion](https://mattermost.web.cern.ch/lhcb/pl/j9t5yxwrxbybmdjs6zd5hhxreh) on DPA WP3 Mattermost channel.
Fix reconstruction binding for spruce case.
To be merged with Moore!3185.Davide FazziniDavide Fazzinihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1042Draft: Replacing get functions for reconstruction in DaVinci tests2024-03-20T17:40:02+01:00Davide FazziniDraft: Replacing get functions for reconstruction in DaVinci testsReplacing some of the `get_*`functions used in the DaVinci tests with the corresponding `make_*` version if available.
This replacement is done only for tests using Hlt2 or Turbo samples since at the moment is not possible reading the sp...Replacing some of the `get_*`functions used in the DaVinci tests with the corresponding `make_*` version if available.
This replacement is done only for tests using Hlt2 or Turbo samples since at the moment is not possible reading the sprucing output from the `make_*` function implemented in Moore (the current `get_*` functions are in PyConf).
Related to DaVinci#172.Davide FazziniDavide Fazzinihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1040New functors for estimation of helicity angle2024-03-25T11:53:17+01:00Volodymyr Svintozelskyivolodymyr.svintozelskyi@cern.chNew functors for estimation of helicity angleGoes with lhcb/Rec!3770Goes with lhcb/Rec!3770Volodymyr Svintozelskyivolodymyr.svintozelskyi@cern.chVolodymyr Svintozelskyivolodymyr.svintozelskyi@cern.chhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1039Add Functor Collection with Charged Calo Information2024-03-08T16:23:51+01:00Albert Lopez HuertasAdd Functor Collection with Charged Calo InformationThis Functor Collection contains all the variables related to Charged Calo Information, including also PID variables from Calo, used in electron analyses.
FYI: @cmarinbe @lcalefic @pvidrier @palaguarThis Functor Collection contains all the variables related to Charged Calo Information, including also PID variables from Calo, used in electron analyses.
FYI: @cmarinbe @lcalefic @pvidrier @palaguarAlbert Lopez HuertasAlbert Lopez Huertashttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1022Move FunTuple to DaVinci2024-02-13T16:57:48+01:00Abhijit MathadMove FunTuple to DaVinciMoving FunTuple to DV.
Test with: https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/1049Moving FunTuple to DV.
Test with: https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/1049Abhijit MathadAbhijit Mathadhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1018Update hlt2 line for the veloSP integration test2024-01-29T12:00:26+01:00Davide FazziniUpdate hlt2 line for the veloSP integration testFix the option file for the final step of the veloSP integration test. This MR updates the corresponding Hlt2 line for retrieving the particles for the final tuples, since the previous location is now empty.Fix the option file for the final step of the veloSP integration test. This MR updates the corresponding Hlt2 line for retrieving the particles for the final tuples, since the previous location is now empty.Eduardo RodriguesDavide FazziniEduardo Rodrigueshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1017Get LHC Information with FunTuple2024-03-27T07:42:31+01:00Tommaso Fulghesutommaso.fulghesu@cern.chGet LHC Information with FunTupleNEEDS: https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/418, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3519
Get the LHC event information (FillNumber, LHCbInternalClock, LHC Energy) using the new functorcollection `LHCInfo`
...NEEDS: https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/418, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3519
Get the LHC event information (FillNumber, LHCbInternalClock, LHC Energy) using the new functorcollection `LHCInfo`
TODO:
- [x] Update qmt test (& ref file)Tommaso Fulghesutommaso.fulghesu@cern.chTommaso Fulghesutommaso.fulghesu@cern.chhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1000OriginFlag functor for FT2024-01-29T11:44:03+01:00Sara CelaniOriginFlag functor for FTUpdated the DaVinci options for Flavour Tagging variables to check that the new OriginFlag functor (which should give the true origin of the tagging particles) works.
To be tested with: [lhcb/Rec!3651](https://gitlab.cern.ch/lhcb/Rec/-...Updated the DaVinci options for Flavour Tagging variables to check that the new OriginFlag functor (which should give the true origin of the tagging particles) works.
To be tested with: [lhcb/Rec!3651](https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3651) and https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/1043Abhijit MathadPeilian LiAbhijit Mathadhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/995Follow https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4356 and https://git...2023-12-07T10:43:50+01:00Abhijit MathadFollow https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4356 and https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/1022To be tested with: https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4356 and https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/1022To be tested with: https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4356 and https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/1022Abhijit MathadAbhijit Mathadhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/991Resolve "Update DV configuration for Turbo with `persistreco =True`"2024-01-22T12:36:10+01:00Davide FazziniResolve "Update DV configuration for Turbo with `persistreco =True`"Closes #134Closes #134Davide FazziniDavide Fazzinihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/990Resolve "Follow-up from "Test service to write luminosity information to TTre...2023-12-07T10:47:31+01:00Edoardo FranzosoResolve "Follow-up from "Test service to write luminosity information to TTree when reading from FSRs""Update test to validate the lumi tree creation when no events pass the DV selection.
Depends on [https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4344](https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4344).
Closes #136Update test to validate the lumi tree creation when no events pass the DV selection.
Depends on [https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4344](https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4344).
Closes #136Abhijit MathadEdoardo FranzosoAbhijit Mathadhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/987Update xgen input file location2023-10-27T13:49:50+02:00Davide FazziniUpdate xgen input file locationUpdate the test input file locations from `/eos/lhcb/wg/dpa/wp3/testDV_read_xgen/` and `/eos/lhcb/wg/dpa/wp3/NovemberFEST/` into `/eos/lhcb/wg/dpa/wp3/tests/`.
Relates to #95.Update the test input file locations from `/eos/lhcb/wg/dpa/wp3/testDV_read_xgen/` and `/eos/lhcb/wg/dpa/wp3/NovemberFEST/` into `/eos/lhcb/wg/dpa/wp3/tests/`.
Relates to #95.Davide FazziniDavide Fazzinihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/986Add an extra check for []CC in the decay descriptor of FunTuple2024-01-22T12:41:27+01:00Jiahui ZhuoAdd an extra check for []CC in the decay descriptor of FunTupleAddressing the issue https://gitlab.cern.ch/lhcb/Analysis/-/issues/47#note_7219259
This MR adds a DaVinci test for https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/1018
To be tested with: https://gitlab.cern.ch/lhcb/Rec/-/merge_re...Addressing the issue https://gitlab.cern.ch/lhcb/Analysis/-/issues/47#note_7219259
This MR adds a DaVinci test for https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/1018
To be tested with: https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3637 https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/1018
Solve the issue: https://gitlab.cern.ch/lhcb/Analysis/-/issues/47#note_7219259
FYI: @pkoppenb @erodrigu @amathadJiahui ZhuoJiahui Zhuohttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/985Fix example for spruced data2023-10-27T13:49:50+02:00Davide FazziniFix example for spruced dataRemove unused option file: `option_davinci_tupling_from_data.py` and `example_data/Spruce_Run251342.yaml` in DaVinciExamples.
The file `option_davinci_tupling_from_data.py` was a copy of `option_davinci_tupling_from_raw_data.py` running ...Remove unused option file: `option_davinci_tupling_from_data.py` and `example_data/Spruce_Run251342.yaml` in DaVinciExamples.
The file `option_davinci_tupling_from_data.py` was a copy of `option_davinci_tupling_from_raw_data.py` running over a spruced line instead of a Hlt2 line. However the related input file was simulation and not real data.
Replacing the codes with a more updated working and tested example.
Fixing also the doc string of the [option_davinci_tupling_from_raw_data.py](https://gitlab.cern.ch/lhcb/DaVinci/-/blob/master/DaVinciExamples/python/DaVinciExamples/tupling/option_davinci_tupling_from_raw_data.py) script, reporting the usage of the `Spruce_Run251342.yaml` option file while using the `Run255620.yaml` script in the related qmtest [test_davinci_tupling_from_raw_data.qmt](https://gitlab.cern.ch/lhcb/DaVinci/-/blob/master/DaVinciExamples/tests/qmtest/tupling.qms/test_davinci_tupling_from_raw_data.qmt).
Closes #139.Davide FazziniDavide Fazzinihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/981DV Tutorials and Examples pages now have a link to "Running DaVinci" section2023-10-13T15:44:26+02:00Maurizio MartinelliDV Tutorials and Examples pages now have a link to "Running DaVinci" sectionFollowing issue https://gitlab.cern.ch/lhcb/DaVinci/-/issues/150, the automatic documentation is modified to link "Running DaVinci" section.
In that section now also opening a `bash` shell with DaVinci environment is documented.Following issue https://gitlab.cern.ch/lhcb/DaVinci/-/issues/150, the automatic documentation is modified to link "Running DaVinci" section.
In that section now also opening a `bash` shell with DaVinci environment is documented.Maurizio MartinelliMaurizio Martinellihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/979Remove evt_pre_filters from the DaVinci options2023-10-05T14:04:34+02:00Davide FazziniRemove evt_pre_filters from the DaVinci optionsRemove the `evt_pre_filters` option since it is not compatible with the ThOr functors, as reported in #115.
Closes https://gitlab.cern.ch/lhcb/DaVinci/-/issues/115.Remove the `evt_pre_filters` option since it is not compatible with the ThOr functors, as reported in #115.
Closes https://gitlab.cern.ch/lhcb/DaVinci/-/issues/115.Abhijit MathadDavide FazziniAbhijit Mathad