DaVinci merge requestshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests2022-05-30T15:54:39+02:00https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/659adding examples for ALLPV{X,Y,Z} and BPV{X,Y,Z} functors2022-05-30T15:54:39+02:00Lukas Caleficeadding examples for ALLPV{X,Y,Z} and BPV{X,Y,Z} functorsThis MR is adding the ALLPV and BPV functors to the DaVinci examples with all available functors.
Functors were merged by https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2683
superseeding https://gitlab.cern.ch/lhcb/Rec/-/merge_request...This MR is adding the ALLPV and BPV functors to the DaVinci examples with all available functors.
Functors were merged by https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2683
superseeding https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2745, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2748
FYI: @amathadPatrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1049Draft: Make reconstruction objects accessible from spruced dst2024-03-22T18:17:42+01:00Davide FazziniDraft: Make reconstruction objects accessible from spruced dstFollowing [discussion](https://mattermost.web.cern.ch/lhcb/pl/j9t5yxwrxbybmdjs6zd5hhxreh) on DPA WP3 Mattermost channel.
Fix reconstruction binding for spruce case.
To be merged with Moore!3185.Following [discussion](https://mattermost.web.cern.ch/lhcb/pl/j9t5yxwrxbybmdjs6zd5hhxreh) on DPA WP3 Mattermost channel.
Fix reconstruction binding for spruce case.
To be merged with Moore!3185.Davide FazziniDavide Fazzinihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/933Extend F.VALUE_OR for more input types2023-07-11T21:08:37+02:00Jiahui ZhuoExtend F.VALUE_OR for more input typesAdd the DaVinci test for https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3489
Need to be test with https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3489
FYI: @graven @amathad @tfulghes @pkoppenb @erodriguAdd the DaVinci test for https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3489
Need to be test with https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3489
FYI: @graven @amathad @tfulghes @pkoppenb @erodriguJiahui ZhuoJiahui Zhuohttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/897test rec_summary functor2023-07-24T10:57:45+02:00Samuel Belintest rec_summary functorTesting the RECSUMMARY_INFO functor in the test AllFunctors.py
Test to validate the functor added in merge request https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3332
Needs lhcb/Rec!3509
Merged into relevant branch of https://gitlab....Testing the RECSUMMARY_INFO functor in the test AllFunctors.py
Test to validate the functor added in merge request https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3332
Needs lhcb/Rec!3509
Merged into relevant branch of https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/926RTA/2023.07.31Samuel BelinSamuel Belinhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/839DaVinci example to show how to get charged particles in a DaVinci script2023-05-30T09:29:24+02:00Guillaume Max Pietrzykguillaume.pietrzyk@cern.chDaVinci example to show how to get charged particles in a DaVinci scriptSimple example showing how to get charged particles in a DaVinci script.
This script was suggested by Sascha.
Workaround for https://gitlab.cern.ch/lhcb/DaVinci/-/issues/99Simple example showing how to get charged particles in a DaVinci script.
This script was suggested by Sascha.
Workaround for https://gitlab.cern.ch/lhcb/DaVinci/-/issues/99Sascha StahlSascha Stahlhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/801Draft: Resolve "Follow-up from "Removing python modules duplicated from Moore""2023-02-17T17:43:24+01:00Davide FazziniDraft: Resolve "Follow-up from "Removing python modules duplicated from Moore""Closes #68Closes #68Davide FazziniDavide Fazzinihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/792Add Position closest to beam to all functors test2022-11-25T07:14:34+01:00Patrick KoppenburgAdd Position closest to beam to all functors testAdded position of state closest to beam as per discussion https://mattermost.web.cern.ch/lhcb/pl/fka4kzeqj3y7tfkohq3aqwwbgr involving @graven @mstahl
Requires https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3885 (for completeness; th...Added position of state closest to beam as per discussion https://mattermost.web.cern.ch/lhcb/pl/fka4kzeqj3y7tfkohq3aqwwbgr involving @graven @mstahl
Requires https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3885 (for completeness; this is already merged).
I am not sure it's very useful as it does the same as REFERENCEPOINT, but it's an example of something that should work. Hence good as a test, not necessarily as an example.
Superseded by !793 .Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/746Follow-up MR from https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/916 ...2022-09-19T13:24:57+02:00Abhijit MathadFollow-up MR from https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/916 adding to exclusionsWith the introduction of new run3 decay finder, all of the tests pass except these three:
- DaVinciExamples.tupling.test_davinci_tupling_array_taggers (Failed)
- DaVinciExamples.tupling.test_example-tupling-basic-run-mc (Failed)
- DaV...With the introduction of new run3 decay finder, all of the tests pass except these three:
- DaVinciExamples.tupling.test_davinci_tupling_array_taggers (Failed)
- DaVinciExamples.tupling.test_example-tupling-basic-run-mc (Failed)
- DaVinciTests.davinci.test_davinci_funtuple_array (Failed)
The `ROOT` files are made correctly but the validator is now catching a new warning that is being thrown. The new warnings are:
```
WARNING: found factory loki_functor_3493811357, but of wrong type: instead of LoKi::Functor<LHCb::ProtoParticle const*, bool>* (*)(LoKi::Context&&)
WARNING: found factory loki_functor_3361120277, but of wrong type: instead of LoKi::Functor<LHCb::Event::v1::Track const*, bool>* (*)(LoKi::Context&&)
```
These warnings are just out of the blue since I am not even using `LoKi`. I am not really sure of their source. I have seen them sometimes building Moore, perhaps they are harmless?
This MR includes these warnings in DV exclusions.
To tested with: https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3091 and https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/916Abhijit MathadSacha BarreAbhijit Mathadhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/658Draft: Lock options.simulation when using run-mc or run-data2022-05-20T16:38:08+02:00Sascha StahlDraft: Lock options.simulation when using run-mc or run-dataAt the moment it is possible to change the option `simulation` when using run-mc or run-data in a user script. This would prevent people from doing it.At the moment it is possible to change the option `simulation` when using run-mc or run-data in a user script. This would prevent people from doing it.Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/610Simplify unpacking/decoding for DV2021-12-17T12:34:09+01:00Nicole SkidmoreSimplify unpacking/decoding for DVSee https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3303 and https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/1137 currently in testing.
* The [`reading` module](https://gitlab.cern.ch/lhcb/LHCb/-/blob/8cb09245f717470e0ea41c35e81f6e...See https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3303 and https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/1137 currently in testing.
* The [`reading` module](https://gitlab.cern.ch/lhcb/LHCb/-/blob/8cb09245f717470e0ea41c35e81f6e817d8d7970/GaudiConf/python/GaudiConf/reading.py) has been significantly simplified and DV should make use of this. See changes of this MR
* With the advent of using `RawBank::Views` the output RawEvent of the sprucing is no longer at `DAQ/RawEvent`, `reading` functions take care of this however the test files DV are using need to be updated. Please let me know what kind of test files you require and I can produce these on the new stack.
**Note** there is quite a lot of reformatting that has happened automatically in this MR.
I would like this large MR (Moore, LHCb) to go in before xmas and obviously I require DV to pass before this can happen :)Eduardo RodriguesPatrick KoppenburgDavide FazziniNicole SkidmoreEduardo Rodrigueshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/590WIP: Add BKGCAT to FunTuple2022-01-21T15:01:11+01:00Patrick KoppenburgWIP: Add BKGCAT to FunTupleTest to check https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2621Test to check https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2621Patrick KoppenburgPatrick Koppenburg