DaVinci merge requestshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests2024-03-28T13:03:32+01:00https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1062Draft: Review content of functor collections2024-03-28T13:03:32+01:00Anfeng LiDraft: Review content of functor collectionssee https://gitlab.cern.ch/lhcb/DaVinci/-/issues/168
- [x] fix missing names in `__all__`
- [x] improvement of `MCHierarchy`
- [x] improvement of `MCReconstructible`
- [x] remove redundant information in `Kinematics`, `MCKinematics`, `D...see https://gitlab.cern.ch/lhcb/DaVinci/-/issues/168
- [x] fix missing names in `__all__`
- [x] improvement of `MCHierarchy`
- [x] improvement of `MCReconstructible`
- [x] remove redundant information in `Kinematics`, `MCKinematics`, `DecayTreeFitterResults`, `MCReconstructible`Anfeng LiAnfeng Lihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1052Draft: HLT1 SelReport fix for TrueSim efficiency studies2024-03-25T12:11:12+01:00Volodymyr Svintozelskyivolodymyr.svintozelskyi@cern.chDraft: HLT1 SelReport fix for TrueSim efficiency studiesCurrent MR addresses the issue #162.
It re-enables the HLT1 TrueSim efficiency algorithm and ensures the fetching of correct `SelReport`. Additionally, the decoding of the SelRep raw bank for the case when no event was triggered is fixed...Current MR addresses the issue #162.
It re-enables the HLT1 TrueSim efficiency algorithm and ensures the fetching of correct `SelReport`. Additionally, the decoding of the SelRep raw bank for the case when no event was triggered is fixed with the linked MR LHCb!4497. Therefore, these allow the tracking efficiency studies of HLT1 lines, which is crucial for upcoming downstream and faraway (viz. T-Track) studies.
However, after fixing issues as explained above, it became clear, that one has to fix also the bug hidden in `HltTrueSimEffAlg` and related to calo truth matching. The bug is caused by the existence of calo `LHCbIDs` in the `SelReport` output, for which the algorithm is not prepared. As a temporary solution, one may ignore those `LHCbIDs`, as described in a linked MR (Rec!3801).
Goes with Rec!3801, LHCb!4497.
FYI: @jzhuo @adeoyang @amathad @erodriguhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1042Draft: Replacing get functions for reconstruction in DaVinci tests2024-03-20T17:40:02+01:00Davide FazziniDraft: Replacing get functions for reconstruction in DaVinci testsReplacing some of the `get_*`functions used in the DaVinci tests with the corresponding `make_*` version if available.
This replacement is done only for tests using Hlt2 or Turbo samples since at the moment is not possible reading the sp...Replacing some of the `get_*`functions used in the DaVinci tests with the corresponding `make_*` version if available.
This replacement is done only for tests using Hlt2 or Turbo samples since at the moment is not possible reading the sprucing output from the `make_*` function implemented in Moore (the current `get_*` functions are in PyConf).
Related to DaVinci#172.Davide FazziniDavide Fazzinihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1040New functors for estimation of helicity angle2024-03-25T11:53:17+01:00Volodymyr Svintozelskyivolodymyr.svintozelskyi@cern.chNew functors for estimation of helicity angleGoes with lhcb/Rec!3770Goes with lhcb/Rec!3770Volodymyr Svintozelskyivolodymyr.svintozelskyi@cern.chVolodymyr Svintozelskyivolodymyr.svintozelskyi@cern.chhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/955Draft: DV example for storing output of charged isolation MVA (xGBoost) output2024-03-20T18:04:23+01:00Abhijit MathadDraft: DV example for storing output of charged isolation MVA (xGBoost) outputDV example to compute the output of the MVA classifier (xGBoost) for charged track isolation.
Higher values of MVA classifier output indicate that the charged track is less isolated and is more likely to be associated to be coming from t...DV example to compute the output of the MVA classifier (xGBoost) for charged track isolation.
Higher values of MVA classifier output indicate that the charged track is less isolated and is more likely to be associated to be coming from the same decay vertex as the B0. For more details see [presentation](https://indico.cern.ch/event/1234758/#sc-1-4-ml-based-charged-isolat)
To-do:
- [ ] Update the example with full list of observables. (Currently only subset used for testing).
- [ ] Add qmt test.
To be tested with: https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3550Julian Garcia PardinasAbhijit MathadLuca HartmanJulian Garcia Pardinashttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/944Example for new functors introduced in https://gitlab.cern.ch/lhcb/Rec/-/merg...2024-03-25T13:17:51+01:00Simone CapelliExample for new functors introduced in https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3527To be tested with: https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/944 , https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3527 and https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4383/
Test the functors defined in Rec (https://gi...To be tested with: https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/944 , https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3527 and https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4383/
Test the functors defined in Rec (https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3527).Abhijit MathadSimone CapelliAbhijit Mathadhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/909Adding more DaVinci example to MCReconstructible and MCReconstructed tools fo...2024-03-20T17:28:08+01:00Jiahui ZhuoAdding more DaVinci example to MCReconstructible and MCReconstructed tools for MCParticles from reconstructed particleFollowing the discussion at https://gitlab.cern.ch/lhcb/Rec/-/issues/283#note_6663944, this merge request will add an additional example/test for the `MCReconstructible` and `MCReconstructed` tool to validate their functionality with MCP...Following the discussion at https://gitlab.cern.ch/lhcb/Rec/-/issues/283#note_6663944, this merge request will add an additional example/test for the `MCReconstructible` and `MCReconstructed` tool to validate their functionality with MCParticles from truth matching.
FYI: @amathad @pkoppenb @ldufour @erodriguJiahui ZhuoJiahui Zhuohttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/715Draft: Add test for writing dst with DaVinci2024-03-20T18:03:33+01:00Davide FazziniDraft: Add test for writing dst with DaVinciAdd a test checking DaVinci can run a selection algorithm and persist the candidates in a new .dst file.
Closes https://gitlab.cern.ch/lhcb-dpa/project/-/issues/238Add a test checking DaVinci can run a selection algorithm and persist the candidates in a new .dst file.
Closes https://gitlab.cern.ch/lhcb-dpa/project/-/issues/238Davide FazziniDavide Fazzinihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1063Draft: fix for the merge of the genfsr2024-03-28T19:23:46+01:00Davide FazziniDraft: fix for the merge of the genfsrTemporary fix to the merging of the GenFSRs until the migration of the new FSRs.\
Following a discussion with @clemenci (see [here](https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1058#note_7795091)).Temporary fix to the merging of the GenFSRs until the migration of the new FSRs.\
Following a discussion with @clemenci (see [here](https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1058#note_7795091)).Davide FazziniDavide Fazzinihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1017Get LHC Information with FunTuple2024-03-27T07:42:31+01:00Tommaso Fulghesutommaso.fulghesu@cern.chGet LHC Information with FunTupleNEEDS: https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/418, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3519
Get the LHC event information (FillNumber, LHCbInternalClock, LHC Energy) using the new functorcollection `LHCInfo`
...NEEDS: https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/418, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3519
Get the LHC event information (FillNumber, LHCbInternalClock, LHC Energy) using the new functorcollection `LHCInfo`
TODO:
- [x] Update qmt test (& ref file)Tommaso Fulghesutommaso.fulghesu@cern.chTommaso Fulghesutommaso.fulghesu@cern.ch