DaVinci merge requestshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests2021-06-24T17:03:23+02:00https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/425Remove use of L0Conf2021-06-24T17:03:23+02:00Patrick KoppenburgRemove use of L0ConfL0Conf will be obsoleted and is not needed in DaVinci options. Removed from DaVinci-Example.py and options run in DaVinciTests.
Need OK from @dfazziniL0Conf will be obsoleted and is not needed in DaVinci options. Removed from DaVinci-Example.py and options run in DaVinciTests.
Need OK from @dfazziniEduardo RodriguesDorothea Vom BruchEduardo Rodrigueshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/431Cleaning DV configuration for Upgrade2021-06-24T17:02:01+02:00Davide FazziniCleaning DV configuration for UpgradeCleaning up DaVinci configuration in order to be ready for moving to GaudiConf2.Cleaning up DaVinci configuration in order to be ready for moving to GaudiConf2.Patrick KoppenburgDavide FazziniPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/498Remove tagging tests until revision is done2021-02-04T17:53:10+01:00Patrick KoppenburgRemove tagging tests until revision is doneThe tagging test can no longer run as it depends on TaggingChecker which was removed in https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/747. See https://gitlab.cern.ch/lhcb/Analysis/-/issues/6 for tagging revision.The tagging test can no longer run as it depends on TaggingChecker which was removed in https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/747. See https://gitlab.cern.ch/lhcb/Analysis/-/issues/6 for tagging revision.Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/500Update CI to run formatting and linting2021-02-18T18:32:01+01:00Eduardo RodriguesUpdate CI to run formatting and lintingJust as done for Analysis.Just as done for Analysis.Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/501Remove obsolete tesla2021-06-24T17:00:49+02:00Patrick KoppenburgRemove obsolete teslaTesla is obsolete for Run 3. RIP.
cc @gligorov
See Phys!871.Tesla is obsolete for Run 3. RIP.
cc @gligorov
See Phys!871.Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/503Print DecayTree test2021-02-21T15:27:05+01:00Patrick KoppenburgPrint DecayTree testAdded a test of PrintDecayTree https://gitlab.cern.ch/lhcb/Phys/-/merge_requests/865/ .
Now used as a DaVinci().UserAlgorithm . To be modernized with new configuration.
Also changed the copyright of all files and removed old 2010 test...Added a test of PrintDecayTree https://gitlab.cern.ch/lhcb/Phys/-/merge_requests/865/ .
Now used as a DaVinci().UserAlgorithm . To be modernized with new configuration.
Also changed the copyright of all files and removed old 2010 test files.Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/521Add test for reading a Moore DST2021-06-24T16:59:03+02:00Patrick KoppenburgAdd test for reading a Moore DSTAdd a test to read a file from Moore, https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/770. It's D->KK.
WIP as it requires https://gitlab.cern.ch/lhcb-datapkg/PRConfig/-/merge_requests/172 to be deployed (at least on nightlies)Add a test to read a file from Moore, https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/770. It's D->KK.
WIP as it requires https://gitlab.cern.ch/lhcb-datapkg/PRConfig/-/merge_requests/172 to be deployed (at least on nightlies)Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/540Rename histos file2021-06-24T16:57:59+02:00Patrick KoppenburgRename histos fileRename Histogram output files from DVHistos.root to something user-defined.Rename Histogram output files from DVHistos.root to something user-defined.Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/539Update tupling example including LoKi and now ThOr functors2021-05-21T14:35:12+02:00Abhijit MathadUpdate tupling example including LoKi and now ThOr functorsThis MR depends of https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/792 and https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2420 and https://gitlab.cern.ch/lhcb/Phys/-/merge_requests/930.
FYI: @mamartin
Relates to DPA task https...This MR depends of https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/792 and https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2420 and https://gitlab.cern.ch/lhcb/Phys/-/merge_requests/930.
FYI: @mamartin
Relates to DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/113.Abhijit MathadAbhijit Mathadhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/542Simplified PyConf DaVinci configuration2021-05-25T16:33:30+02:00Maurizio MartinelliSimplified PyConf DaVinci configurationWorking on the simplification of DaVinci configuration using PyConf.
Now run_davinci takes a single list of nodes as input.
Still wondering the best user experience when running multiple selections, currently using DVHelper to prepare th...Working on the simplification of DaVinci configuration using PyConf.
Now run_davinci takes a single list of nodes as input.
Still wondering the best user experience when running multiple selections, currently using DVHelper to prepare the nodes.
Tupling test file updated to create two tuples from different selections on the same dataset.
Work on DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/48.
~~Not to be merged before https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/539~~ ~~decided to merge this first~~
Needs https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/539.
Needs Analysis!792 to avoid error from FunTuple.Eduardo RodriguesPatrick KoppenburgEduardo Rodrigueshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/546Avoid compression sizes in tests and fix wrong space2021-06-24T16:57:47+02:00Patrick KoppenburgAvoid compression sizes in tests and fix wrong spacetest_example-tupling-basic.qmt contains byte sizes in the validator. These depend on compiler and ROOT version. Thus removed.test_example-tupling-basic.qmt contains byte sizes in the validator. These depend on compiler and ROOT version. Thus removed.https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/538Fix DaVinci tests2021-06-05T21:11:52+02:00Patrick KoppenburgFix DaVinci testsNew tests of ThOr functors. Also adapted those that rely on https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/791 (hence needs this MR).
Other tests are also fixed to match what is going on in lhcb-run3-cleanupNew tests of ThOr functors. Also adapted those that rely on https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/791 (hence needs this MR).
Other tests are also fixed to match what is going on in lhcb-run3-cleanupPatrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/535Simplify user algs functions2021-07-01T16:10:45+02:00Davide FazziniSimplify user algs functionsSimplify how the user algorithms are imported in a DaVinci job: the responsibility of the creating dedicated DV nodes is moved from the user to DaVinci.
Improve the way how the LHCbConfigurableUser dependencies are handled and imported ...Simplify how the user algorithms are imported in a DaVinci job: the responsibility of the creating dedicated DV nodes is moved from the user to DaVinci.
Improve the way how the LHCbConfigurableUser dependencies are handled and imported in Gaudi application.\
Implement the possibility to import configurables from both the old and the new Gaudi framework.
Work on DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/48.Patrick KoppenburgDavide FazziniPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/550Adapt to ThOr functor and algorithm naming changes2021-06-30T13:28:00+02:00Alex PearceAdapt to ThOr functor and algorithm naming changesFollows the changes in Rec!2456 and Phys!945. Relevant here are changes to some test options:
- `MASS` functor no longer needs to be given mass hypotheses.
- Combiner changes:
- Property names are different (`Comb12Cut` -> `Combinatio...Follows the changes in Rec!2456 and Phys!945. Relevant here are changes to some test options:
- `MASS` functor no longer needs to be given mass hypotheses.
- Combiner changes:
- Property names are different (`Comb12Cut` -> `CombinationCut`).
- Accepts a single decay descriptor.
- Accepts one input container per child.
I also took the liberty of making a few clean-ups (moving imports to the top of the file, removing unused imports) and updated the test reference. Note that the number of accepted candidates has not changed.
Requires Rec!2456 and Phys!945. Related to Moore!862 and MooreAnalysis!39.Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/552Advanced Tupling test: Do not rely on a reference file2021-07-01T16:11:58+02:00Patrick KoppenburgAdvanced Tupling test: Do not rely on a reference fileAdvanced Tupling test: Do not rely on a reference file as some lines appear in different order depending on platform. cc @dfazzini
Avoids random test failures as in https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/535Advanced Tupling test: Do not rely on a reference file as some lines appear in different order depending on platform. cc @dfazzini
Avoids random test failures as in https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/535Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/558Update the tuple examples2021-07-08T14:06:47+02:00Abhijit MathadUpdate the tuple examplesThis MR updates all the tuple examples following this https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/797.
FYI @dfazzini and @mferrill .This MR updates all the tuple examples following this https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/797.
FYI @dfazzini and @mferrill .Abhijit MathadAbhijit Mathadhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/554Remove DecayTreeTuple2021-08-19T16:52:35+02:00Patrick KoppenburgRemove DecayTreeTupleTentative implementation of lhcb-dpa/project#7 . Removal of all DecayTreeTuple tests.
Requires https://gitlab.cern.ch/lhcb/Castelao/-/merge_requests/110
Goes along with LHCb!3117 and Analysis!802 and Phys!961Tentative implementation of lhcb-dpa/project#7 . Removal of all DecayTreeTuple tests.
Requires https://gitlab.cern.ch/lhcb/Castelao/-/merge_requests/110
Goes along with LHCb!3117 and Analysis!802 and Phys!961Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/549Adapt test to ProbNN functors2021-10-22T14:52:33+02:00Patrick KoppenburgAdapt test to ProbNN functorsAdapt tests to include ProbNN functors. Requires https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2471Adapt tests to include ProbNN functors. Requires https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2471Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/577Adding missing features for correctly reading a spruced file2021-11-26T12:50:42+01:00Davide FazziniAdding missing features for correctly reading a spruced fileIntegrating DaVinci!573 with the addition of:
- ***UnpackRawEvent*** for correctly retrieving the ODIN raw locations (see https://gitlab.cern.ch/lhcb-dpa/project/-/issues/154)
- ***SpruceDecReports*** adding a dedicated decoder for s...Integrating DaVinci!573 with the addition of:
- ***UnpackRawEvent*** for correctly retrieving the ODIN raw locations (see https://gitlab.cern.ch/lhcb-dpa/project/-/issues/154)
- ***SpruceDecReports*** adding a dedicated decoder for spruced lines decision
- ***evt_pre_filters*** DV option, allowing the user to run the job on a reduced number of entries (see https://gitlab.cern.ch/lhcb/DaVinci/-/issues/9)
- ***add_filters*** checking if the spruced line corresponding to FunTuple input location fired (see https://gitlab.cern.ch/lhcb/DaVinci/-/issues/6#note_4795459)
Finally, a new qmtest is added to verify the correct functioning of all these new features.
Needs Moore!998.Davide FazziniDavide Fazzinihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/569Test for DecayTreeFitterAlg2021-11-24T08:32:28+01:00Patrick KoppenburgTest for DecayTreeFitterAlgTest for DecayTreeFitterAlg and subsequent functors. Based on https://gitlab.cern.ch/lhcb/Phys/-/merge_requests/970 and https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2504Test for DecayTreeFitterAlg and subsequent functors. Based on https://gitlab.cern.ch/lhcb/Phys/-/merge_requests/970 and https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2504Patrick KoppenburgPatrick Koppenburg