DaVinci merge requestshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests2023-03-08T17:57:31+01:00https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/656Add additional functors to example-tupling-AllFunctors.py2023-03-08T17:57:31+01:00Gerhard RavenAdd additional functors to example-tupling-AllFunctors.pywith Rec!2709, various functors now work -- so added them to example-tupling-AllFunctors.py
must be merged _after_ (or together with) Rec!2709with Rec!2709, various functors now work -- so added them to example-tupling-AllFunctors.py
must be merged _after_ (or together with) Rec!2709Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/805Update option file for lhcb integration tests2023-02-08T20:19:15+01:00Davide FazziniUpdate option file for lhcb integration testsUpdate option files for testing the turbo/spruce steps in the LHCbIntegration Moore-DaVinci chain.
To be merged with lhcb/LHCbIntegrationTests!28.Update option files for testing the turbo/spruce steps in the LHCbIntegration Moore-DaVinci chain.
To be merged with lhcb/LHCbIntegrationTests!28.Davide FazziniDavide Fazzinihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/782Test on EMTF data2022-11-24T09:49:22+01:00Patrick KoppenburgTest on EMTF dataFirst options running on early data. Run 251342. Most of the code by @nskidmor, and the data as well. cc @erodrigu
To do:
- [x] Test options and data
- [x] qmtest
Note that PROBNN_D and PROBNN_MU presently returns nan.
BPVLTIME some...First options running on early data. Run 251342. Most of the code by @nskidmor, and the data as well. cc @erodrigu
To do:
- [x] Test options and data
- [x] qmtest
Note that PROBNN_D and PROBNN_MU presently returns nan.
BPVLTIME sometimes gets the right solution, sometimes nan and sometimes nonsense. Reported as https://gitlab.cern.ch/lhcb/Rec/-/issues/421.Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/733Adapt to LHCb!3528 - Enforce use of an encoding/decoding key (TCK) in all Hlt...2022-10-10T11:48:48+02:00Gerhard RavenAdapt to LHCb!3528 - Enforce use of an encoding/decoding key (TCK) in all Hlt encoders/decoders, do not use online-reserved bits in SourceID, remove explicit mention of 'packed' locations, enable 'stable' persist reco locationsnecessary changes to adapt to LHCb!3528necessary changes to adapt to LHCb!3528Eduardo RodriguesPatrick KoppenburgEduardo Rodrigueshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/711DaVinci to depend on Moore2022-10-10T11:44:53+02:00Patrick KoppenburgDaVinci to depend on MooreTrying to see what happens if DaVinci depends on Moore, following a BBQ discussion with @dfazzini . Implements https://gitlab.cern.ch/lhcb/Rec/-/issues/353 option 2.
The follow-up MR removing duplications between DaVinci and Moore is !700.Trying to see what happens if DaVinci depends on Moore, following a BBQ discussion with @dfazzini . Implements https://gitlab.cern.ch/lhcb/Rec/-/issues/353 option 2.
The follow-up MR removing duplications between DaVinci and Moore is !700.Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/688updated all functors test2022-05-30T15:53:24+02:00Patrick Koppenburgupdated all functors testUpdated test of all functors following release v60r3
Needs https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3549 and https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/884Updated test of all functors following release v60r3
Needs https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3549 and https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/884Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/692For truth matching make Spruce as the default root_in_tes2022-05-10T17:59:04+02:00Abhijit MathadFor truth matching make Spruce as the default root_in_tesDriven by this [discussion](https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/688#note_5548301), the MR has following changes:
- Change the default `root_in_tes` to be `Spruce`.
- The `configured_MCTruthAndBkgCatAlg` takes `process`...Driven by this [discussion](https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/688#note_5548301), the MR has following changes:
- Change the default `root_in_tes` to be `Spruce`.
- The `configured_MCTruthAndBkgCatAlg` takes `process` as input, instead of `root_in_tes`. The `root_in_tes` is set internally depending on `process`.Abhijit MathadAbhijit Mathadhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/654Storing event info (trigger and odin) with FunTuple2022-03-07T08:41:15+01:00Abhijit MathadStoring event info (trigger and odin) with FunTupleThe example here shows how the trigger and event-info can be added into FunTuple.
To be tested with: https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2747, https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/1367 and https://gitlab.cer...The example here shows how the trigger and event-info can be added into FunTuple.
To be tested with: https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2747, https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/1367 and https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/867.
Note the MR also closes https://gitlab.cern.ch/lhcb/DaVinci/-/issues/41 and closes https://gitlab.cern.ch/lhcb/DaVinci/-/issues/36.Abhijit MathadAbhijit Mathadhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/641Modernize xgen test2022-02-18T17:53:32+01:00Patrick KoppenburgModernize xgen testUse ThOr functors as much as possible in example. Add a description so users can use the example to test decay files. The goal is to advertise this at https://gitlab.cern.ch/lhcb-datapkg/Gen/DecFiles/blob/master/CONTRIBUTING.md .
More f...Use ThOr functors as much as possible in example. Add a description so users can use the example to test decay files. The goal is to advertise this at https://gitlab.cern.ch/lhcb-datapkg/Gen/DecFiles/blob/master/CONTRIBUTING.md .
More functors can be added as required by the simulation project. Please comment here.
Related to but not (yet) dependent on https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/846Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/625Use DTFAlg in DecayTreeFitter example2022-01-31T13:48:21+01:00Patrick KoppenburgUse DTFAlg in DecayTreeFitter exampleUse wrapper suggested by @amathad in https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2676#note_5148356 in DecayTreeFitter tupling example.
Draft because type of vertex container not yet solved.
Needs https://gitlab.cern.ch/lhcb/Rec/-...Use wrapper suggested by @amathad in https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2676#note_5148356 in DecayTreeFitter tupling example.
Draft because type of vertex container not yet solved.
Needs https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2676 and https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3354Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/617Checks for ERROR and FATAL in all tests2022-01-31T13:48:19+01:00Patrick KoppenburgChecks for ERROR and FATAL in all testsAddresses https://gitlab.cern.ch/lhcb/DaVinci/-/issues/25
More checks for FATAL and ERROR are added in all tests.
Needs https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/842Addresses https://gitlab.cern.ch/lhcb/DaVinci/-/issues/25
More checks for FATAL and ERROR are added in all tests.
Needs https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/842Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/594Test of all functors2021-12-14T11:25:50+01:00Patrick KoppenburgTest of all functorsTest of all Thor functors that work (or not) in FunTuple.
Those that do not work are listed in https://gitlab.cern.ch/lhcb/Rec/-/issues/245Test of all Thor functors that work (or not) in FunTuple.
Those that do not work are listed in https://gitlab.cern.ch/lhcb/Rec/-/issues/245Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/599Adding test for run DaVinci with gaudirun.py2021-12-14T10:37:18+01:00Davide FazziniAdding test for run DaVinci with gaudirun.pyAdding qmtest for running a DaVinci job with the whole configuration by means of gaudirun.py.
Related to https://gitlab.cern.ch/lhcb-dpa/project/-/issues/132.
Work towards DPA WP3 test suite https://gitlab.cern.ch/lhcb-dpa/project/-/is...Adding qmtest for running a DaVinci job with the whole configuration by means of gaudirun.py.
Related to https://gitlab.cern.ch/lhcb-dpa/project/-/issues/132.
Work towards DPA WP3 test suite https://gitlab.cern.ch/lhcb-dpa/project/-/issues/179.Davide FazziniDavide Fazzinihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/577Adding missing features for correctly reading a spruced file2021-11-26T12:50:42+01:00Davide FazziniAdding missing features for correctly reading a spruced fileIntegrating DaVinci!573 with the addition of:
- ***UnpackRawEvent*** for correctly retrieving the ODIN raw locations (see https://gitlab.cern.ch/lhcb-dpa/project/-/issues/154)
- ***SpruceDecReports*** adding a dedicated decoder for s...Integrating DaVinci!573 with the addition of:
- ***UnpackRawEvent*** for correctly retrieving the ODIN raw locations (see https://gitlab.cern.ch/lhcb-dpa/project/-/issues/154)
- ***SpruceDecReports*** adding a dedicated decoder for spruced lines decision
- ***evt_pre_filters*** DV option, allowing the user to run the job on a reduced number of entries (see https://gitlab.cern.ch/lhcb/DaVinci/-/issues/9)
- ***add_filters*** checking if the spruced line corresponding to FunTuple input location fired (see https://gitlab.cern.ch/lhcb/DaVinci/-/issues/6#note_4795459)
Finally, a new qmtest is added to verify the correct functioning of all these new features.
Needs Moore!998.Davide FazziniDavide Fazzinihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/569Test for DecayTreeFitterAlg2021-11-24T08:32:28+01:00Patrick KoppenburgTest for DecayTreeFitterAlgTest for DecayTreeFitterAlg and subsequent functors. Based on https://gitlab.cern.ch/lhcb/Phys/-/merge_requests/970 and https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2504Test for DecayTreeFitterAlg and subsequent functors. Based on https://gitlab.cern.ch/lhcb/Phys/-/merge_requests/970 and https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2504Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/549Adapt test to ProbNN functors2021-10-22T14:52:33+02:00Patrick KoppenburgAdapt test to ProbNN functorsAdapt tests to include ProbNN functors. Requires https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2471Adapt tests to include ProbNN functors. Requires https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2471Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/554Remove DecayTreeTuple2021-08-19T16:52:35+02:00Patrick KoppenburgRemove DecayTreeTupleTentative implementation of lhcb-dpa/project#7 . Removal of all DecayTreeTuple tests.
Requires https://gitlab.cern.ch/lhcb/Castelao/-/merge_requests/110
Goes along with LHCb!3117 and Analysis!802 and Phys!961Tentative implementation of lhcb-dpa/project#7 . Removal of all DecayTreeTuple tests.
Requires https://gitlab.cern.ch/lhcb/Castelao/-/merge_requests/110
Goes along with LHCb!3117 and Analysis!802 and Phys!961Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/558Update the tuple examples2021-07-08T14:06:47+02:00Abhijit MathadUpdate the tuple examplesThis MR updates all the tuple examples following this https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/797.
FYI @dfazzini and @mferrill .This MR updates all the tuple examples following this https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/797.
FYI @dfazzini and @mferrill .Abhijit MathadAbhijit Mathadhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/552Advanced Tupling test: Do not rely on a reference file2021-07-01T16:11:58+02:00Patrick KoppenburgAdvanced Tupling test: Do not rely on a reference fileAdvanced Tupling test: Do not rely on a reference file as some lines appear in different order depending on platform. cc @dfazzini
Avoids random test failures as in https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/535Advanced Tupling test: Do not rely on a reference file as some lines appear in different order depending on platform. cc @dfazzini
Avoids random test failures as in https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/535Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/535Simplify user algs functions2021-07-01T16:10:45+02:00Davide FazziniSimplify user algs functionsSimplify how the user algorithms are imported in a DaVinci job: the responsibility of the creating dedicated DV nodes is moved from the user to DaVinci.
Improve the way how the LHCbConfigurableUser dependencies are handled and imported ...Simplify how the user algorithms are imported in a DaVinci job: the responsibility of the creating dedicated DV nodes is moved from the user to DaVinci.
Improve the way how the LHCbConfigurableUser dependencies are handled and imported in Gaudi application.\
Implement the possibility to import configurables from both the old and the new Gaudi framework.
Work on DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/48.Patrick KoppenburgDavide FazziniPatrick Koppenburg