DaVinci merge requestshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests2022-10-10T11:45:28+02:00https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/730DV change default raw_event_format to 0.52022-10-10T11:45:28+02:00Abhijit MathadDV change default raw_event_format to 0.5See https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3687 (to be tested with this also).See https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3687 (to be tested with this also).Nicole SkidmoreNicole Skidmorehttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/729Store information from RecSummary (nTracks, nPVs)2022-10-10T11:46:15+02:00Abhijit MathadStore information from RecSummary (nTracks, nPVs)Test for functor reading `RecSummary`. Closes https://gitlab.cern.ch/lhcb/Rec/-/issues/366
To be tested with: https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3033Test for functor reading `RecSummary`. Closes https://gitlab.cern.ch/lhcb/Rec/-/issues/366
To be tested with: https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3033Abhijit MathadAbhijit Mathadhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/728Update References for: Detector!244 based on lhcb-master-mr/50762022-07-18T09:18:36+02:00Software for LHCbUpdate References for: Detector!244 based on lhcb-master-mr/5076https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/727Couple of fixes for Sphinx documentation2022-07-15T14:04:51+02:00Eduardo RodriguesCouple of fixes for Sphinx documentationFYI @cburr ... I did not find a way to please linkcheck for URLs with anchors, hence went for a workaround for now. Any better idea? I did not find one online, funny enough.
While at it I got rid of the one warning.FYI @cburr ... I did not find a way to please linkcheck for URLs with anchors, hence went for a workaround for now. Any better idea? I did not find one online, funny enough.
While at it I got rid of the one warning.Eduardo RodriguesEduardo Rodrigueshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/726Debugging docs CI job failure2022-07-15T11:51:45+02:00Chris BurrDebugging docs CI job failureThe docs CI is failing due to a change in the CERN CI runners. This merge request contains a workaround but I hope there can be a central fix instead.
See https://cern.service-now.com/service-portal?id=ticket&table=incident&n=INC3184843The docs CI is failing due to a change in the CERN CI runners. This merge request contains a workaround but I hope there can be a central fix instead.
See https://cern.service-now.com/service-portal?id=ticket&table=incident&n=INC3184843Chris BurrChris Burrhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/725Tests for flight distance and IP wrt all pvs2022-07-25T12:04:44+02:00Abhijit MathadTests for flight distance and IP wrt all pvsAdd tests for new functors in https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3017
To be tested with: https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3017Add tests for new functors in https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3017
To be tested with: https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3017Abhijit MathadAbhijit Mathadhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/724Update documentation for lbexec2022-07-15T12:12:08+02:00Chris BurrUpdate documentation for lbexecThe only commit to review here is 55d61da92ce1dffebba27eda9d0667c1b8e5881a, the rest are covered by !722.
The most notable changes other than replacing `davinci`-specific documentation with `lbexec`-specific documentaton:
* I tried to ...The only commit to review here is 55d61da92ce1dffebba27eda9d0667c1b8e5881a, the rest are covered by !722.
The most notable changes other than replacing `davinci`-specific documentation with `lbexec`-specific documentaton:
* I tried to include python code from the test files rather than hard coding it so it's more likely to work (even if the text might become outdated). In particular this fixes several outdated examples. As part of this I reformatted a couple of the examples to make them be more reasonably auto-formatted.
* I use `autodoc_pydantic` to automatically document the `Options` class.
All of this documentation could definitely be improved however I think this is a good enough start.
For reference - related to DPA tasks https://gitlab.cern.ch/lhcb-dpa/project/-/issues/102 and https://gitlab.cern.ch/lhcb-dpa/project/-/issues/180.Chris BurrChris Burrhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/723Remove davinci command2022-08-02T11:24:53+02:00Chris BurrRemove davinci commandBuilds upon !722 to remove the davinci command entirely.
For reference - related to DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/180.Builds upon !722 to remove the davinci command entirely.
For reference - related to DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/180.Chris BurrEduardo RodriguesChris Burrhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/722Finish migration of tests to use lbexec2022-07-14T21:53:32+02:00Chris BurrFinish migration of tests to use lbexecFinished the work started in https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/709.
For reference - related to DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/180.Finished the work started in https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/709.
For reference - related to DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/180.Chris BurrChris Burrhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/721Follows Rec!29592022-07-13T18:01:34+02:00Tommaso Fulghesutommaso.fulghesu@cern.chFollows Rec!2959Follows changes on MAP_INPUT and MAP_INPUT_ARRAY from https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2959Follows changes on MAP_INPUT and MAP_INPUT_ARRAY from https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2959Tommaso Fulghesutommaso.fulghesu@cern.chTommaso Fulghesutommaso.fulghesu@cern.chhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/720Invalid value handling in nTuples2022-07-25T12:04:45+02:00Abhijit MathadInvalid value handling in nTuplesCloses https://gitlab.cern.ch/lhcb/DaVinci/-/issues/58.
The MR makes changes to option files so that invalid value for integer functors are passed by the user when there is no entry in the relations table. For floating point number a `...Closes https://gitlab.cern.ch/lhcb/DaVinci/-/issues/58.
The MR makes changes to option files so that invalid value for integer functors are passed by the user when there is no entry in the relations table. For floating point number a `nan` is tupled.
To be tested with: https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/902, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2992
FYI: @chasseAbhijit MathadAbhijit Mathadhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/719DaVinci website organisation2022-09-01T15:04:03+02:00Maurizio MartinelliDaVinci website organisationI would like to discuss in this mr how to organise the DaVinci website, create the relevant sections and fill them with basic information.
My initial proposal is to have three main sections
- DaVinci User Guide
- DaVinci Tutorials
- ...I would like to discuss in this mr how to organise the DaVinci website, create the relevant sections and fill them with basic information.
My initial proposal is to have three main sections
- DaVinci User Guide
- DaVinci Tutorials
- DaVinci API
Any suggestion?
Work on DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/102.Eduardo RodriguesMaurizio MartinelliEduardo Rodrigueshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/717Update conf.py2022-06-30T10:09:32+02:00Eduardo RodriguesUpdate conf.pyEduardo RodriguesEduardo Rodrigueshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/716Thor functors for MCTrackInfo2022-09-19T13:24:58+02:00Jiahui ZhuoThor functors for MCTrackInfoThis MR continues from https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/707, which is accidentally merged and reverted.
Description: In this MR will create a helper for the usage of new functors created in https://gitlab.cern.ch/lhc...This MR continues from https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/707, which is accidentally merged and reverted.
Description: In this MR will create a helper for the usage of new functors created in https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2979, and add an example to DaVinci.
TO-DO List:
- [x] Create the helper for MCP2MCTrackInfo, which will get the MCTrackInfo to each MC Particle
- [x] Create the helper for MCP2Track, which will associate each MC Particle to a reconstructed track.
- [x] Add examples
- [x] Add test to examples
- [x] Fix the comments from https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/707
- [x] Change the example for new MCP2Track Algorithm.
FYI: @amathad @ldufour @pkoppenb @sstahl @chasse @erodrigu
This MR require: https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/1759 https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2979, https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/898Abhijit MathadPatrick KoppenburgJiahui ZhuoAbhijit Mathadhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/714Add fix for reading files with eosuser prefix2022-06-23T13:21:41+02:00Davide FazziniAdd fix for reading files with eosuser prefixFix for reading correctly files with the EOS prefix `root://eosuser.cern.ch//`.Fix for reading correctly files with the EOS prefix `root://eosuser.cern.ch//`.Davide FazziniDavide Fazzinihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/713Test usage of F.CHILD with F.MAP_INPUT with DTF2022-08-02T11:23:05+02:00Abhijit MathadTest usage of F.CHILD with F.MAP_INPUT with DTFTest of issue https://gitlab.cern.ch/lhcb/Rec/-/issues/359 with DTF. The MR also contains clean-up on hlt2 example.
Tested with: https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2976Test of issue https://gitlab.cern.ch/lhcb/Rec/-/issues/359 with DTF. The MR also contains clean-up on hlt2 example.
Tested with: https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2976Abhijit MathadAbhijit Mathadhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/712Revert "Merge branch 'jzhuo_FunTuple_MCRec' into 'master'"2022-06-21T10:02:42+02:00Sebastien PonceRevert "Merge branch 'jzhuo_FunTuple_MCRec' into 'master'"This reverts merge request !707This reverts merge request !707https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/711DaVinci to depend on Moore2022-10-10T11:44:53+02:00Patrick KoppenburgDaVinci to depend on MooreTrying to see what happens if DaVinci depends on Moore, following a BBQ discussion with @dfazzini . Implements https://gitlab.cern.ch/lhcb/Rec/-/issues/353 option 2.
The follow-up MR removing duplications between DaVinci and Moore is !700.Trying to see what happens if DaVinci depends on Moore, following a BBQ discussion with @dfazzini . Implements https://gitlab.cern.ch/lhcb/Rec/-/issues/353 option 2.
The follow-up MR removing duplications between DaVinci and Moore is !700.Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/710Documentation for v61r02022-06-10T13:37:37+02:00Patrick KoppenburgDocumentation for v61r0New version v61r0 for LHCb week on DPA stackNew version v61r0 for LHCb week on DPA stackPatrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/709Convert tutorials and debugging examples to use lbexec2022-07-14T17:02:12+02:00Chris BurrConvert tutorials and debugging examples to use lbexecDraft for now as it requires https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3618 for the tests to pass.
The tupling part of `DaVinciExamples` still needs to be done but I think there is enough here to justify reviewing.
Work related...Draft for now as it requires https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3618 for the tests to pass.
The tupling part of `DaVinciExamples` still needs to be done but I think there is enough here to justify reviewing.
Work related to DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/102.