DaVinci merge requestshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests2021-01-28T19:16:09+01:00https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/497Follow snake_case naming conventions rather than camelCase2021-01-28T19:16:09+01:00Eduardo RodriguesFollow snake_case naming conventions rather than camelCaseI noticed that we're not really following what seems to be the preferred naming conventions for upgrade code, hence this MR to improve on that from the onset. This is just a few first changes to make sure everyone is happy - @pkoppenb an...I noticed that we're not really following what seems to be the preferred naming conventions for upgrade code, hence this MR to improve on that from the onset. This is just a few first changes to make sure everyone is happy - @pkoppenb and @dfazzini.
I'm profiting from the occasion to make the main configuration functions available from the top level, to run as `gaudirun.py DaVinci:data` rather than `gaudirun.py DaVinci.ConfigurationUpgrade:data`, as agreed.
Hopefully we can converge here and have it all merged for Monday for the hackathon.Patrick KoppenburgDavide FazziniPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/496Removal of many obsolete doc-related files2021-01-11T09:43:15+01:00Eduardo RodriguesRemoval of many obsolete doc-related filesRelated to the clean-up campaign see https://gitlab.cern.ch/lhcb-dpa/project/-/issues/18.
@pkoppenb, nothing but totally trivial things that I thought we could get rid of, while I was browsing the repository. The less irrelevant files w...Related to the clean-up campaign see https://gitlab.cern.ch/lhcb-dpa/project/-/issues/18.
@pkoppenb, nothing but totally trivial things that I thought we could get rid of, while I was browsing the repository. The less irrelevant files we have the better.Patrick KoppenburgPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/494Fix tests for PrintDecayTree modernisation2020-12-20T09:27:15+01:00Patrick KoppenburgFix tests for PrintDecayTree modernisationChanges of test options and references due to https://gitlab.cern.ch/lhcb/Phys/-/merge_requests/865 and https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/741.Changes of test options and references due to https://gitlab.cern.ch/lhcb/Phys/-/merge_requests/865 and https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/741.Lorenzo PicaLorenzo Picahttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/493Add release notes template2020-12-17T10:59:34+01:00Marco CattaneoAdd release notes templatehttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/487Fix formatting of reference block for test_davinci_initialise test2020-12-16T10:25:15+01:00Marco CattaneoFix formatting of reference block for test_davinci_initialise test(cherry picked from commit af398f8007cd40c442a08588eb162c082015cf5b)(cherry picked from commit af398f8007cd40c442a08588eb162c082015cf5b)https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/489Update tagging efficiency test for tagging changes on this branch2020-12-16T10:25:00+01:00Marco CattaneoUpdate tagging efficiency test for tagging changes on this branchhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/490Remove Tesla, not supported on this branch2020-12-16T10:22:55+01:00Marco CattaneoRemove Tesla, not supported on this branchhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/492Add copyright and copyright chwck2020-12-16T10:21:54+01:00Marco CattaneoAdd copyright and copyright chwckhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/491Remove Tesla, not supported on this branch2020-12-16T10:21:54+01:00Marco CattaneoRemove Tesla, not supported on this branchhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/488Add the release notes template2020-12-14T18:13:08+01:00Marco CattaneoAdd the release notes templatehttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/486Remove DaVinciTransporter and LoKiFitters, moved back to Phys2020-12-13T19:41:46+01:00Marco CattaneoRemove DaVinciTransporter and LoKiFitters, moved back to PhysTo be merged with Phys!855To be merged with Phys!855https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/485Remove CVS keywords2020-12-13T10:59:51+01:00Marco CattaneoRemove CVS keywordshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/483Remove OSX linkopts, not supported on this branch2020-12-12T17:22:38+01:00Marco CattaneoRemove OSX linkopts, not supported on this branchhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/484Fix fsrs and io tests in 2018-patches2020-12-12T14:19:44+01:00Alison Maria Tullyalison.tully@cern.chFix fsrs and io tests in 2018-patcheshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/432Skeleton of the new configuration for the Upgrade2020-12-10T16:15:52+01:00Davide FazziniSkeleton of the new configuration for the UpgradeImplementation of a new skeleton configuration file for the run-3 DaVinci application exploiting the GaudiConfig2 framework.
Note that only a subset of what is needed wil lbe put here. Subsequent PRs will complete the full design, which ...Implementation of a new skeleton configuration file for the run-3 DaVinci application exploiting the GaudiConfig2 framework.
Note that only a subset of what is needed wil lbe put here. Subsequent PRs will complete the full design, which requires also developments on the Gaudi side.
See issue https://gitlab.cern.ch/lhcb-dpa/project/-/issues/48.
DaVinci job with Upgrade configuration can be run using the following command lines:
- `./run gaudirun.py DaVinci.Configuration:mc` (for MC files)
- `./run gaudirun.py DaVinci.Configuration:data` (for data files)Patrick KoppenburgDavide FazziniPatrick Koppenburghttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/482To ignore GenericParticle2PVRelator warnings in stderr2020-12-07T14:58:13+01:00Nicole SkidmoreTo ignore GenericParticle2PVRelator warnings in stderrThis should make the qmt tests ignore the warnings
```
WARNING: requesting factory via old name 'GenericParticle2PVRelator__p2PVWithIPChi2_OfflineDistanceCalculatorName_'use 'GenericParticle2PVRelator<_p2PVWithIPChi2, OfflineDistanceCa...This should make the qmt tests ignore the warnings
```
WARNING: requesting factory via old name 'GenericParticle2PVRelator__p2PVWithIPChi2_OfflineDistanceCalculatorName_'use 'GenericParticle2PVRelator<_p2PVWithIPChi2, OfflineDistanceCalculatorName>' instead
```
in the stderr.
Fixes S21(r1) nightliesAlison Maria Tullyalison.tully@cern.chNicole SkidmoreAlison Maria Tullyalison.tully@cern.chhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/468Fix remaining stripping-related tests in stripping21-patches nightlies2020-12-07T14:58:13+01:00Alison Maria Tullyalison.tully@cern.chFix remaining stripping-related tests in stripping21-patches nightlieshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/480cmt changes (2013-patches)2020-12-07T14:00:31+01:00Nicole Skidmorecmt changes (2013-patches)Cleanup of cmt files. See https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/479 for details on how this helps run qmt tests.Cleanup of cmt files. See https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/479 for details on how this helps run qmt tests.Alison Maria Tullyalison.tully@cern.chMark SmithAlison Maria Tullyalison.tully@cern.chhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/481Remove WIN32 build directives2020-12-04T09:00:42+01:00Marco CattaneoRemove WIN32 build directiveshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/479cmt changes2020-12-03T10:04:44+01:00Nicole Skidmorecmt changesThese changes should allow you to run qmt tests individually. You need a change to the set up too
```
lbn-install --verbose --projects DaVinci --platforms x86_64-slc6-gcc48-opt --dest $TMPDIR/lhcb-stripping21-firstpass-patches/390 lhcb-...These changes should allow you to run qmt tests individually. You need a change to the set up too
```
lbn-install --verbose --projects DaVinci --platforms x86_64-slc6-gcc48-opt --dest $TMPDIR/lhcb-stripping21-firstpass-patches/390 lhcb-stripping21-firstpass-patches 390
lb-dev --nightly-base $TMPDIR --nightly lhcb-stripping21-firstpass-patches/390 -c x86_64-slc6-gcc48-opt DaVinci/stripping21-firstpass-patches
cd DaVinciDev_stripping21-firstpass-patches/
git lb-use DaVinci
git lb-checkout DaVinci/<branch> DaVinciTests
git lb-checkout DaVinci/<branch> Phys
make
. build_env.sh
lb-set-platform $platform
cd DaVinciTests/cmt
cmt TestPackage --html-output ../../html stripping.test_stripping21_collision12_reco14
```
Back in ```DaVinciDev_stripping21-firstpass-patches/html``` you will now see the test results
```
[nskidmor@lxplus723 stripping.test_stripping21_collision12_reco14]$ pwd
/afs/cern.ch/user/n/nskidmor/work/Stripping/MeganTheeStallion/DaVinciDev_stripping21-firstpass-patches/html/stripping.test_stripping21_collision12_reco14
[nskidmor@lxplus723 stripping.test_stripping21_collision12_reco14]$ ls
ExecTest.exit_code ExecTest.stderr GaudiTest.environment GaudiTest.output_reference qmtest.end_time qmtest.target
ExecTest.expected_stderr ExecTest.stdout GaudiTest.Histos.expected qmtest.cause qmtest.start_time summary.json
```
```ExecTest.stderr``` and ```ExecTest.stdout``` are the useful ones :)Alison Maria Tullyalison.tully@cern.chAlison Maria Tullyalison.tully@cern.ch