DaVinci merge requestshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests2024-03-28T13:03:32+01:00https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1062Draft: Review content of functor collections2024-03-28T13:03:32+01:00Anfeng LiDraft: Review content of functor collectionssee https://gitlab.cern.ch/lhcb/DaVinci/-/issues/168
- [x] fix missing names in `__all__`
- [x] improvement of `MCHierarchy`
- [x] improvement of `MCReconstructible`
- [x] remove redundant information in `Kinematics`, `MCKinematics`, `D...see https://gitlab.cern.ch/lhcb/DaVinci/-/issues/168
- [x] fix missing names in `__all__`
- [x] improvement of `MCHierarchy`
- [x] improvement of `MCReconstructible`
- [x] remove redundant information in `Kinematics`, `MCKinematics`, `DecayTreeFitterResults`, `MCReconstructible`Anfeng LiAnfeng Lihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1056Remove obsolete use of upfront_reconstruction, upfront_decoder.bind, and get_...2024-03-28T10:51:49+01:00Gerhard RavenRemove obsolete use of upfront_reconstruction, upfront_decoder.bind, and get_hlt_reports.bind- Remove now unnecessary explicit configuration of unpacking as part of the controlflow, and rely on automated dataflow instead.
- Remove now unnecessary upfront_decoder.global_bind
- Remove unnecessary get_hlt_reports.bind
Has to go to...- Remove now unnecessary explicit configuration of unpacking as part of the controlflow, and rely on automated dataflow instead.
- Remove now unnecessary upfront_decoder.global_bind
- Remove unnecessary get_hlt_reports.bind
Has to go together with Moore!3117 and LHCb!4463.Gerhard RavenGerhard Ravenhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1038Following changes in Moore!29072024-03-28T04:33:23+01:00Miroslav Saurmiroslav.saur@cern.chFollowing changes in Moore!2907Following partial migration and renaming of `RecoConf.hlt1_tracking -> RecoConf.legacy_rec_hlt1_tracking` and `RecoConf.hlt1_muonid -> RecoConf.muonid`
Part of the set: Moore!2907 lhcb-datapkg/PRConfig!386 MooreOnline!326 Alignment!458 ...Following partial migration and renaming of `RecoConf.hlt1_tracking -> RecoConf.legacy_rec_hlt1_tracking` and `RecoConf.hlt1_muonid -> RecoConf.muonid`
Part of the set: Moore!2907 lhcb-datapkg/PRConfig!386 MooreOnline!326 Alignment!458 Panoptes!317 DaVinci!1038
FYI: @rjhunterMiroslav Saurmiroslav.saur@cern.chMiroslav Saurmiroslav.saur@cern.chhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1057Draft: TAU -> CTAU renaming2024-03-27T17:54:32+01:00Andrea Villaandrea.villa@cern.chDraft: TAU -> CTAU renamingDecayTreeFitter variable `TAU` is actually computing c*tau, so it needs to be renamed to `CTAU`.
Once https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3815 is merged, it can be also changed in the `DecayTreeFitterResults` functor collec...DecayTreeFitter variable `TAU` is actually computing c*tau, so it needs to be renamed to `CTAU`.
Once https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3815 is merged, it can be also changed in the `DecayTreeFitterResults` functor collections in this MRhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1002Ported all tests to IOAlg2024-03-27T16:02:06+01:00Sebastien PoncePorted all tests to IOAlgPart of set of MR LHCb!2993 Rec!2735 Allen!1370 Moore!927 DaVinci!1002 Panoptes!304 Alignment!439 MooreOnline!325 lhcb-datapkg/PRConfig!388
Depends on gaudi/Gaudi!1197 gaudi/Gaudi!1523 gaudi/Gaudi!1526Part of set of MR LHCb!2993 Rec!2735 Allen!1370 Moore!927 DaVinci!1002 Panoptes!304 Alignment!439 MooreOnline!325 lhcb-datapkg/PRConfig!388
Depends on gaudi/Gaudi!1197 gaudi/Gaudi!1523 gaudi/Gaudi!1526https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1047Add test for track refitting2024-03-27T10:50:28+01:00Laurent DufourAdd test for track refittingAdds the needed DaVinci test for the integration test for HLT2 -> Sprucing -> track refitting in DaVinci, see https://gitlab.cern.ch/lhcb/LHCbIntegrationTests/-/merge_requests/60.
Relies on:
- https://gitlab.cern.ch/lhcb/Moore/-/merge_...Adds the needed DaVinci test for the integration test for HLT2 -> Sprucing -> track refitting in DaVinci, see https://gitlab.cern.ch/lhcb/LHCbIntegrationTests/-/merge_requests/60.
Relies on:
- https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2754
- https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3708
- https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4364
- https://gitlab.cern.ch/lhcb/Alignment/-/merge_requests/440Anfeng LiAnfeng Lihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1017Get LHC Information with FunTuple2024-03-27T07:42:31+01:00Tommaso Fulghesutommaso.fulghesu@cern.chGet LHC Information with FunTupleNEEDS: https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/418, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3519
Get the LHC event information (FillNumber, LHCbInternalClock, LHC Energy) using the new functorcollection `LHCInfo`
...NEEDS: https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/418, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3519
Get the LHC event information (FillNumber, LHCbInternalClock, LHC Energy) using the new functorcollection `LHCInfo`
TODO:
- [x] Update qmt test (& ref file)Tommaso Fulghesutommaso.fulghesu@cern.chTommaso Fulghesutommaso.fulghesu@cern.chhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1059required binds to use standard_particles2024-03-26T13:27:10+01:00Sevda Esenrequired binds to use standard_particlesFollows LHCb!4494 Add necessary binds to be able to use standard_particles.Follows LHCb!4494 Add necessary binds to be able to use standard_particles.Abhijit MathadDavide FazziniAbhijit Mathadhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/944Example for new functors introduced in https://gitlab.cern.ch/lhcb/Rec/-/merg...2024-03-25T13:17:51+01:00Simone CapelliExample for new functors introduced in https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3527To be tested with: https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/944 , https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3527 and https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4383/
Test the functors defined in Rec (https://gi...To be tested with: https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/944 , https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3527 and https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4383/
Test the functors defined in Rec (https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3527).Abhijit MathadSimone CapelliAbhijit Mathadhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1052Draft: HLT1 SelReport fix for TrueSim efficiency studies2024-03-25T12:11:12+01:00Volodymyr Svintozelskyivolodymyr.svintozelskyi@cern.chDraft: HLT1 SelReport fix for TrueSim efficiency studiesCurrent MR addresses the issue #162.
It re-enables the HLT1 TrueSim efficiency algorithm and ensures the fetching of correct `SelReport`. Additionally, the decoding of the SelRep raw bank for the case when no event was triggered is fixed...Current MR addresses the issue #162.
It re-enables the HLT1 TrueSim efficiency algorithm and ensures the fetching of correct `SelReport`. Additionally, the decoding of the SelRep raw bank for the case when no event was triggered is fixed with the linked MR LHCb!4497. Therefore, these allow the tracking efficiency studies of HLT1 lines, which is crucial for upcoming downstream and faraway (viz. T-Track) studies.
However, after fixing issues as explained above, it became clear, that one has to fix also the bug hidden in `HltTrueSimEffAlg` and related to calo truth matching. The bug is caused by the existence of calo `LHCbIDs` in the `SelReport` output, for which the algorithm is not prepared. As a temporary solution, one may ignore those `LHCbIDs`, as described in a linked MR (Rec!3801).
Goes with Rec!3801, LHCb!4497.
FYI: @jzhuo @adeoyang @amathad @erodriguhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1040New functors for estimation of helicity angle2024-03-25T11:53:17+01:00Volodymyr Svintozelskyivolodymyr.svintozelskyi@cern.chNew functors for estimation of helicity angleGoes with lhcb/Rec!3770Goes with lhcb/Rec!3770Volodymyr Svintozelskyivolodymyr.svintozelskyi@cern.chVolodymyr Svintozelskyivolodymyr.svintozelskyi@cern.chhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/997Draft: Read SMOG condition via functors2024-03-25T11:00:29+01:00Saverio MarianiDraft: Read SMOG condition via functorsTest for functors reading SMOG conditions through DeLHCb
Depends on https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/421, https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4359, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3658...Test for functors reading SMOG conditions through DeLHCb
Depends on https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/421, https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4359, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3658, https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/1024
Successfully tested on simulation and on [DV test data](https://gitlab.cern.ch/lhcb/DaVinci/-/blob/master/DaVinciExamples/example_data/Run255620.yaml?ref_type=heads) specifying a [custom CondDB branch](https://gitlab.cern.ch/lhcb-conddb/lhcb-conditions-database/-/compare/AlignmentV12_2023_06_22...samarian_test_smog_functor_2?from_project_id=104349&straight=false)
cc @tfulghes @amathadSaverio MarianiSaverio Marianihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1048Draft: add a file with options that set up the flavour tagging2024-03-21T11:18:19+01:00Claire ProuveDraft: add a file with options that set up the flavour taggingGoes with https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3141Goes with https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3141https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1025Draft: TopoSV functor collection2024-03-20T18:19:48+01:00Lorenzo PicaDraft: TopoSV functor collectionMR implements a new functor collection, containing candidate-based variables related to a vertex different from the BPV one.
So far only FDCHI2 and IPCHI2 are implemented, but more can be added before merging.
FD and IP are commented o...MR implements a new functor collection, containing candidate-based variables related to a vertex different from the BPV one.
So far only FDCHI2 and IPCHI2 are implemented, but more can be added before merging.
FD and IP are commented out, since some changes are still needed to make these work (see https://gitlab.cern.ch/lhcb/Rec/-/issues/403).
Code coming from https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/995 and https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/932.
Goes with https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3650.Abhijit MathadAbhijit Mathadhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1054Update References for: LHCb!2993, Rec!2735, Allen!1370, Moore!927, Alignment!...2024-03-20T18:05:58+01:00Software for LHCbUpdate References for: LHCb!2993, Rec!2735, Allen!1370, Moore!927, Alignment!439, MooreOnline!325, Panoptes!304, DaVinci!1002 based on lhcb-master-mr/11099https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/955Draft: DV example for storing output of charged isolation MVA (xGBoost) output2024-03-20T18:04:23+01:00Abhijit MathadDraft: DV example for storing output of charged isolation MVA (xGBoost) outputDV example to compute the output of the MVA classifier (xGBoost) for charged track isolation.
Higher values of MVA classifier output indicate that the charged track is less isolated and is more likely to be associated to be coming from t...DV example to compute the output of the MVA classifier (xGBoost) for charged track isolation.
Higher values of MVA classifier output indicate that the charged track is less isolated and is more likely to be associated to be coming from the same decay vertex as the B0. For more details see [presentation](https://indico.cern.ch/event/1234758/#sc-1-4-ml-based-charged-isolat)
To-do:
- [ ] Update the example with full list of observables. (Currently only subset used for testing).
- [ ] Add qmt test.
To be tested with: https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3550Julian Garcia PardinasAbhijit MathadLuca HartmanJulian Garcia Pardinashttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/715Draft: Add test for writing dst with DaVinci2024-03-20T18:03:33+01:00Davide FazziniDraft: Add test for writing dst with DaVinciAdd a test checking DaVinci can run a selection algorithm and persist the candidates in a new .dst file.
Closes https://gitlab.cern.ch/lhcb-dpa/project/-/issues/238Add a test checking DaVinci can run a selection algorithm and persist the candidates in a new .dst file.
Closes https://gitlab.cern.ch/lhcb-dpa/project/-/issues/238Davide FazziniDavide Fazzinihttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1051Draft: test missing neutrino reconstruction2024-03-20T17:59:30+01:00Michael Kent WilkinsonDraft: test missing neutrino reconstructionAdd some tests related to Rec!3301.
To be tested with: Rec!3301, LHCb!3955Add some tests related to Rec!3301.
To be tested with: Rec!3301, LHCb!3955Michael Kent WilkinsonMichael Kent Wilkinsonhttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1029Draft: Switch to using gaudi_add_pytest2024-03-20T17:49:13+01:00Eduardo RodriguesDraft: Switch to using gaudi_add_pytestThis will require a development in Gaudi and a new release, see MR https://gitlab.cern.ch/gaudi/Gaudi/-/merge_requests/1551.This will require a development in Gaudi and a new release, see MR https://gitlab.cern.ch/gaudi/Gaudi/-/merge_requests/1551.Eduardo RodriguesEduardo Rodrigueshttps://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1042Draft: Replacing get functions for reconstruction in DaVinci tests2024-03-20T17:40:02+01:00Davide FazziniDraft: Replacing get functions for reconstruction in DaVinci testsReplacing some of the `get_*`functions used in the DaVinci tests with the corresponding `make_*` version if available.
This replacement is done only for tests using Hlt2 or Turbo samples since at the moment is not possible reading the sp...Replacing some of the `get_*`functions used in the DaVinci tests with the corresponding `make_*` version if available.
This replacement is done only for tests using Hlt2 or Turbo samples since at the moment is not possible reading the sprucing output from the `make_*` function implemented in Moore (the current `get_*` functions are in PyConf).
Related to DaVinci#172.Davide FazziniDavide Fazzini