Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • DaVinci DaVinci
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 22
    • Issues 22
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCb
  • DaVinciDaVinci
  • Merge requests
  • !195

Fix python error when using the DaVinci configurable with the Upgrade DataType

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Olli Lupton requested to merge olupton_fix_davinci_upgrade into master Apr 25, 2018
  • Overview 1
  • Commits 1
  • Changes 1

Fix python error when using the DaVinci configurable with the Upgrade DataType and no specific list of detectors.

The error was:

Traceback (most recent call last):
  File "/tmpdata/olupton/ZombieMoore/Bender/Phys/Bender/scripts/bender", line 392, in <module>
    gaudi  = appMgr ()
  File "/tmpdata/olupton/ZombieMoore/Bender/Phys/Bender/python/Bender/Utils.py", line 613, in appMgr
    _g = GaudiPython.Bindings.AppMgr()
  File "/tmpdata/olupton/ZombieMoore/Gaudi/InstallArea/x86_64-centos7-gcc62-opt/python/GaudiPython/Bindings.py", line 888, in __new__
    cls.__init__(newobj, *args, **kwargs)
  File "/tmpdata/olupton/ZombieMoore/Gaudi/InstallArea/x86_64-centos7-gcc62-opt/python/GaudiPython/Bindings.py", line 943, in __init__
    GaudiKernel.Proxy.Configurable.applyConfigurableUsers()
  File "/tmpdata/olupton/ZombieMoore/Gaudi/InstallArea/x86_64-centos7-gcc62-opt/python/GaudiKernel/Configurable.py", line 1497, in applyConfigurableUsers
    c.__apply_configuration__()
  File "/tmpdata/olupton/ZombieMoore/DaVinci/InstallArea/x86_64-centos7-gcc62-opt/python/DaVinci/Configuration.py", line 676, in __apply_configuration__
    self._upgradeAction()
  File "/tmpdata/olupton/ZombieMoore/DaVinci/InstallArea/x86_64-centos7-gcc62-opt/python/DaVinci/Configuration.py", line 599, in _upgradeAction
    upgrade_only_dets = [ d for d in __known_upgrade_detectors__ if d not in __known_default_detectors]
NameError: global name '__known_upgrade_detectors__' is not defined

when using e.g. bender -d Upgrade.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: olupton_fix_davinci_upgrade