Better naming of moni functions and strong typing of indices
The following discussion from !186 (merged) should be addressed:
-
@lohenry started a discussion: (+2 comments) It is beyond awful, and already is posing lots of problems. I have asked @jheuel to make some changes to the naming.
The issue is that station 0 is used for -iirc- special purposes, so physical stations must start from 1... but when you have a vector you'd like to start at 0. The current solution we are aiming at is to replace this 'moni' and 'non-moni' methods by two families: Idx (index) and ID (identifier) methods. An identifier is the name (e.g. 1 for T1), whereas an index is always contiguous and starts from 0. So then at least if you see in an array or anything an ID method you know this is wrong.
It might even be a case for strong typing :^)
@jheuel Related to LHCBSCIFI-176