Detector merge requestshttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests2024-03-19T15:44:31+01:00https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/403Fix Hcal volumes2024-03-19T15:44:31+01:00Jean-Francois MarchandFix Hcal volumesFix the names of some Hcal volumes
---
Validated by
- [x] Core Software
- [ ] RTA
- [ ] SimulationFix the names of some Hcal volumes
---
Validated by
- [x] Core Software
- [ ] RTA
- [ ] Simulationhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/489fix pos of SteelSheet1{L,R} in EcalBeamPlug2024-03-18T11:00:39+01:00Daniele Manuzzifix pos of SteelSheet1{L,R} in EcalBeamPlug- Fix positions of 2 steel elements in ECAL Beam Plug. Their position was wrong by 1 cm due to missing parentheses.
Compare the changes in `Detector/ECAL/src/ECAL_geo.cpp` with the lines [165](https://gitlab.cern.ch/lhcb-conddb/DDDB/-/bl...- Fix positions of 2 steel elements in ECAL Beam Plug. Their position was wrong by 1 cm due to missing parentheses.
Compare the changes in `Detector/ECAL/src/ECAL_geo.cpp` with the lines [165](https://gitlab.cern.ch/lhcb-conddb/DDDB/-/blob/upgrade/master/Ecal/Installation/BeamPlug.xml?ref_type=heads#L165) and [77](https://gitlab.cern.ch/lhcb-conddb/DDDB/-/blob/upgrade/master/Ecal/Installation/BeamPlug.xml?ref_type=heads#L77) of [`DDDB/Ecal/Installation/BeamPlug.xml`](https://gitlab.cern.ch/lhcb-conddb/DDDB/-/blob/upgrade/master/Ecal/Installation/BeamPlug.xml)
---
Validated by
- [x] Core Software
- [ ] RTA
- [x] Simulationhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/494fix z-coordinate of NeutronShielding2024-02-28T20:24:19+01:00Daniele Manuzzifix z-coordinate of NeutronShieldingThe position of the global envelope of the NeutronShielding was not explicitly set. As a result, it was not placed at the beginning of the Downstream region, but at its centre, where the MUON system is.
This fix assumes the [same positi...The position of the global envelope of the NeutronShielding was not explicitly set. As a result, it was not placed at the beginning of the Downstream region, but at its centre, where the MUON system is.
This fix assumes the [same position](https://gitlab.cern.ch/lhcb-conddb/DDDB/-/blob/upgrade/master/Downstream/geometry.xml?ref_type=heads#L37) as in DetDesc.
@zexu @edelucia
---
Validated by
- [x] Core Software
- [x] RTA
- [x] Simulationhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/478Calo spatial global alignment fix2024-02-09T11:22:09+01:00Maarten Van VeghelCalo spatial global alignment fixAdapt `DeCalorimeter` to be able to deal with global alignment. Further some clean up of code.
Allows for 'quick fix' of shifts seen in calo-tracker alignment by adapting Calo alignment (instead of changing tracker alignment).
See issue...Adapt `DeCalorimeter` to be able to deal with global alignment. Further some clean up of code.
Allows for 'quick fix' of shifts seen in calo-tracker alignment by adapting Calo alignment (instead of changing tracker alignment).
See issues: https://gitlab.cern.ch/lhcb/Alignment/-/issues/100. See for more info also [pdfs](https://indico.cern.ch/event/1325053/contributions/5713331/attachments/2772269/4830830/rta_wp4_trackcalo_alignment_studies_mvanveghel.pdf).
---
Validated by
- [x] Core Software
- [ ] RTA
- [ ] Simulationhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/168Modify CaloCellID for pin data decoding2024-01-11T17:45:40+01:00Jean-Francois MarchandModify CaloCellID for pin data decodingThis modification was originally included in https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3477 but CaloCellID.h has been removed from Kernel/LHCbKernel/include/Kernel/
Needed for https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/34...This modification was originally included in https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3477 but CaloCellID.h has been removed from Kernel/LHCbKernel/include/Kernel/
Needed for https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3477, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2823 and https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/1474 and https://gitlab.cern.ch/lhcb/MooreOnline/-/merge_requests/167
---
Validated by
- [x] Core Software
- [x] RTA
- [x] Simulationhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/337CALO_DD4HEP2023-12-20T11:28:18+01:00Daniele ManuzziCALO_DD4HEPThis is the latest version of the CALO geometry description in `dd4hep`.
TO DOs:
- [x] Overlap checks with Gauss/Geant4 tools
- [x] Mapping between `dd4hep::DDSegmentation::VolumeID` and `Detector::Calo::cellID` to get hits in the simul...This is the latest version of the CALO geometry description in `dd4hep`.
TO DOs:
- [x] Overlap checks with Gauss/Geant4 tools
- [x] Mapping between `dd4hep::DDSegmentation::VolumeID` and `Detector::Calo::cellID` to get hits in the simulation
- [x] 3 equivalent methods are available in `DeCalorimeter.{h,cpp}`: run simulation tests to select the best one and discard the other ones.
- [ ] add a compilation test to always check the consistency of this mapping
- [ ] Validation wrt DetDesc
For more information: daniele.manuzzi@cern.ch
---
Validated by
- [x] Core Software
- [x] RTA
- [x] SimulationDaniele ManuzziDaniele Manuzzihttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/327Fix Calo CellID dd4hep::printout using string representation2022-12-19T18:18:47+01:00Christopher Rob Jonesjonesc@hep.phy.cam.ac.ukFix Calo CellID dd4hep::printout using string representationhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/315Attach CALO Reconstruction conditions to Ecal2022-11-14T17:44:58+01:00Carla Marin Benitocarla.marin.benito@cern.chAttach CALO Reconstruction conditions to EcalAttach Reco conditions to Ecal
Needs https://gitlab.cern.ch/lhcb-conddb/lhcb-conditions-database/-/merge_requests/41
Addresses https://gitlab.cern.ch/lhcb/Detector/-/issues/39
- [x] Test it
FYI @jonrob @chenjiaAttach Reco conditions to Ecal
Needs https://gitlab.cern.ch/lhcb-conddb/lhcb-conditions-database/-/merge_requests/41
Addresses https://gitlab.cern.ch/lhcb/Detector/-/issues/39
- [x] Test it
FYI @jonrob @chenjiaCarla Marin Benitocarla.marin.benito@cern.chCarla Marin Benitocarla.marin.benito@cern.chhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/295Assign Ecal and Hcal ParticleID conditions to CALO Detector Elements2022-11-10T14:32:50+01:00Chenjia ZhangAssign Ecal and Hcal ParticleID conditions to CALO Detector ElementsParticleID.yml needs to be added to Ecal/Hcal conditions so that we can access the conditions they provide.ParticleID.yml needs to be added to Ecal/Hcal conditions so that we can access the conditions they provide.Chenjia ZhangChenjia Zhanghttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/275Provide first pass implementation of DeCalorimeter methods2022-09-24T00:00:33+02:00Jean-Francois MarchandProvide first pass implementation of DeCalorimeter methodsFill DeCalorimeter functions
Needs https://gitlab.cern.ch/lhcb-conddb/lhcb-conditions-database/-/merge_requests/31Fill DeCalorimeter functions
Needs https://gitlab.cern.ch/lhcb-conddb/lhcb-conditions-database/-/merge_requests/31Jean-Francois MarchandJean-Francois Marchandhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/274Fix path for Ecal and Hcal2022-09-22T21:15:31+02:00Chenjia ZhangFix path for Ecal and HcalFix location strings for Ecal and Hcal for DD4Hep usageFix location strings for Ecal and Hcal for DD4Hep usageChenjia ZhangChenjia Zhanghttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/236Add (placeholder) getFEBindex and nSourceIDs functions2022-07-05T08:49:47+02:00Jean-Francois MarchandAdd (placeholder) getFEBindex and nSourceIDs functionsAdd getFEBindex and nSourceIDs functions to DeCalorimeter.h to fix dd4hep build, see https://gitlab.cern.ch/lhcb/Allen/-/issues/335Add getFEBindex and nSourceIDs functions to DeCalorimeter.h to fix dd4hep build, see https://gitlab.cern.ch/lhcb/Allen/-/issues/335Jean-Francois MarchandJean-Francois Marchandhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/185Add CLID_CellID for CaloDigitLinker2022-05-26T09:26:05+02:00Jean-Francois MarchandAdd CLID_CellID for CaloDigitLinkerAdd CLID_CellID for CaloDigitLinker
Should be used with https://gitlab.cern.ch/lhcb/Lbcom/-/merge_requests/608, https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3539, https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/1525, https://git...Add CLID_CellID for CaloDigitLinker
Should be used with https://gitlab.cern.ch/lhcb/Lbcom/-/merge_requests/608, https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3539, https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/1525, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2870 and https://gitlab.cern.ch/lhcb/Boole/-/merge_requests/390https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/155calo to v3 tracks2022-03-15T14:51:56+01:00Maarten Van Veghelcalo to v3 tracksNeeded for https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2547Needed for https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2547https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/104First mock implementation of DeCalorimeter and associated objects2021-11-11T22:46:37+01:00Sebastien PonceFirst mock implementation of DeCalorimeter and associated objectsThis is part of a set of MRs : Detector!104 LHCb!3282 Lbcom!583 Rec!2584 Phys!999 Allen!684 Moore!1054 Boole!361 !17 Gauss!766 Panoramix!107 Alignment!214
All functions needed by LHCb projects are present but they are all empty, returni...This is part of a set of MRs : Detector!104 LHCb!3282 Lbcom!583 Rec!2584 Phys!999 Allen!684 Moore!1054 Boole!361 !17 Gauss!766 Panoramix!107 Alignment!214
All functions needed by LHCb projects are present but they are all empty, returning 0 or empty containers.Sebastien PonceBen CouturierSebastien Ponce