Detector merge requestshttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests2024-02-02T17:54:31+01:00https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/78Draft: implement PLUME geometry2024-02-02T17:54:31+01:00Vladyslav OrlovDraft: implement PLUME geometryIntegration of PLUME detector to the LHCb simulation framework.Integration of PLUME detector to the LHCb simulation framework.Rosen MatevRosen Matevhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/280Draft: Add SMOG22024-03-21T15:52:39+01:00Marco SantimariaDraft: Add SMOG2SMOG2 is added as two wings (L,R) + fixed components - i.e. the WFS (F)SMOG2 is added as two wings (L,R) + fixed components - i.e. the WFS (F)Thomas LathamMarco SantimariaThomas Lathamhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/288Draft: Added static access to nb cells and nb crates for calorimeters2023-06-19T15:29:47+02:00Sebastien PonceDraft: Added static access to nb cells and nb crates for calorimetersgoes together with LHCb!3757 Rec!3107 Moore!1758 MooreOnline!184goes together with LHCb!3757 Rec!3107 Moore!1758 MooreOnline!184https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/294Draft: Imported and sorted materials from LHCb GDML export2024-02-02T17:59:08+01:00Ben CouturierDraft: Imported and sorted materials from LHCb GDML exportImported and sorted materials from LHCb GDML export.
This branch is a draft for comparison purposes only
materials.gdml is the list of materials as extracted from LHCb.gdml
requires https://gitlab.cern.ch/lhcb/Detector/-/merge_requests...Imported and sorted materials from LHCb GDML export.
This branch is a draft for comparison purposes only
materials.gdml is the list of materials as extracted from LHCb.gdml
requires https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/291Gloria CortiThomas LathamGloria Cortihttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/361Draft: First implementation of TORCH detector2024-03-04T16:32:28+01:00Michal KrepsDraft: First implementation of TORCH detectorFirst go at TORCH implementation in DD4HEP. Needed elements are:
- [x] Geometry with relevant constructors. These should be ready, but need to be checked that everything is there. Probably will also have to adjust to U2 structure as this...First go at TORCH implementation in DD4HEP. Needed elements are:
- [x] Geometry with relevant constructors. These should be ready, but need to be checked that everything is there. Probably will also have to adjust to U2 structure as this work started before deciding on that.
- [x] Define optical surfaces
- [x] DD4HEP detector element
- [ ] DD4HEP sensitive detector
Currently implemented geometry is the one corresponding to FTDR simulations and corresponds to DDDB branch `upgrade/TORCH3`. While we need to implement evolution of the geometry, we want to first keep what we have used before and have in detdesc to validate transition to Gauss-on-Gaussino and DD4HEP.
---
Validated by
- [ ] Core Software
- [ ] RTA
- [ ] Simulationhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/373Draft: Add check on Muon Region header2024-02-02T18:01:24+01:00Ben CouturierDraft: Add check on Muon Region headerAdd check on Muon Region headerAdd check on Muon Region headerhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/374Set VP to use simulation conditions properly2024-03-28T10:40:52+01:00David HutchcroftSet VP to use simulation conditions properlyUpdates the VP simulation to read parameters from YAML files, needs YAML https://gitlab.cern.ch/lhcb-conddb/lhcb-conditions-database/-/merge_requests/111 also to work (sim10/run3-ideal is the current target but this should propagate to a...Updates the VP simulation to read parameters from YAML files, needs YAML https://gitlab.cern.ch/lhcb-conddb/lhcb-conditions-database/-/merge_requests/111 also to work (sim10/run3-ideal is the current target but this should propagate to all of the sim10/... branches). This reads from Condtitons/VP/Detector.yml, Conditions/VP/Simulation.yml and sets the parameters for VPDepositCreator and VPDigitCreator.
Marked as draft again as now added marking pixels as bad in groups of 16x16 to MR.
---
Validated by
- [x] Core Software
- [ ] RTA
- [ ] SimulationRTA/2024.03.27Thomas LathamThomas Lathamhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/396Draft: Modified Cavern.xml2023-06-09T23:20:27+02:00Andras BurucsDraft: Modified Cavern.xmlModified Cavern.xmlModified Cavern.xmlhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/398Draft: Detector infrastructure, e.g. cavern and bunker, needed for special si...2024-02-04T13:33:20+01:00Andras BurucsDraft: Detector infrastructure, e.g. cavern and bunker, needed for special simulationsModification for including LHCb Infrastructure in Gauss on Gaussino. The modification needed where found while trying to include the Infrastructure. The changes are made in the compact/trunk/Infrastructure folder for Cavern.xml, and para...Modification for including LHCb Infrastructure in Gauss on Gaussino. The modification needed where found while trying to include the Infrastructure. The changes are made in the compact/trunk/Infrastructure folder for Cavern.xml, and parameters.xml.https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/418Access to LHC condition information2024-03-28T10:25:46+01:00Tommaso Fulghesutommaso.fulghesu@cern.chAccess to LHC condition informationThis MR is ready, just waiting for a local test on data
TO BE TESTED WITH https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3519, https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1017, lhcb/Detector!528
First step towards https://gi...This MR is ready, just waiting for a local test on data
TO BE TESTED WITH https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3519, https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1017, lhcb/Detector!528
First step towards https://gitlab.cern.ch/lhcb/Rec/-/issues/497
Access to LHC conditions by informing `DeLHCb` about `LHCInfo` properties.
It allows to get from condition YAML files contained in https://gitlab.cern.ch/lhcb-conddb/lhcb-conditions-database/-/blob/master/Conditions/LHCb/Online/LHC.yml/ the following quantities
- FillNumber
- LHCState
- LHCEnergy
- LHCbClockPhase
Inspired by https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/383!
TODO:
- [x] Fix the test_DDS
FYI: @mvesteri, @poluekt, @mfontana, @cmarinbe, @raaij
---
Validated by
- [x] Core Software
- [ ] RTA
- [ ] SimulationTommaso Fulghesutommaso.fulghesu@cern.chAnfeng LiTommaso Fulghesutommaso.fulghesu@cern.chhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/421Draft: Read SMOG condition from DeLHCb2024-03-26T22:21:16+01:00Saverio MarianiDraft: Read SMOG condition from DeLHCbImplement a consumer to read SMOG injection state, the injected gas and the injection stability from [the condition database](https://gitlab.cern.ch/lhcb-conddb/lhcb-conditions-database/-/tree/master/Conditions/LHCb/Online/SMOG.yml), as ...Implement a consumer to read SMOG injection state, the injected gas and the injection stability from [the condition database](https://gitlab.cern.ch/lhcb-conddb/lhcb-conditions-database/-/tree/master/Conditions/LHCb/Online/SMOG.yml), as a first needed step towards https://gitlab.cern.ch/lhcb/opg/-/issues/4
Heavily inspired from https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/383 and https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/418
Will target master as soon as https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/418 will be merged
Goes with https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3658 and https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/997
---
Validated by
- [ ] Core Software
- [ ] RTA
- [ ] SimulationRosen MatevRosen Matevhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/442Removing constant attributes of mats and moving FT readout functions to Detector2024-03-23T12:01:22+01:00Louis Henrylouis.henry@cern.chRemoving constant attributes of mats and moving FT readout functions to DetectorTo be tested with LHCb!4483
- Remove pointless attributes in DeFTMat
- Create a strong type FTClusterData in Detector to encode the 16 bits of FT Clusters
- Centralise readout functions in Detector
---
Validated by
- [ ] Core Software
...To be tested with LHCb!4483
- Remove pointless attributes in DeFTMat
- Create a strong type FTClusterData in Detector to encode the 16 bits of FT Clusters
- Centralise readout functions in Detector
---
Validated by
- [ ] Core Software
- [ ] RTA
- [ ] SimulationLouis Henrylouis.henry@cern.chLouis Henrylouis.henry@cern.chhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/446Draft: Biplab codex beta v12024-01-26T15:02:23+01:00Andras BurucsDraft: Biplab codex beta v1*add here a description of the proposed changes*
---
Validated by
- [ ] Core Software
- [ ] RTA
- [ ] Simulation*add here a description of the proposed changes*
---
Validated by
- [ ] Core Software
- [ ] RTA
- [ ] Simulationhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/457Draft: VELO Upgrade II Geometry for Future Upgrades Structure2024-03-28T00:26:18+01:00Dan ThompsonDraft: VELO Upgrade II Geometry for Future Upgrades Structure- New U2 Velo moved from VP to "TV", Timing Velo
- Parameterised model defined in compact/components/trunk/TV/parameters.xml with full instructions on what and how to change the design
- Currently set to "Scenario X" with:
- Pixel Size...- New U2 Velo moved from VP to "TV", Timing Velo
- Parameterised model defined in compact/components/trunk/TV/parameters.xml with full instructions on what and how to change the design
- Currently set to "Scenario X" with:
- Pixel Size = 55um
- Inner radius = 7.2 mm
- Each chip made up of 256 x 256 pixels arranged into 2 rows of 3 chips
- Foil is a cylinder of aluminium 75um thick with a radius of 3.5mm, with the same z-length as the current foil
- Guard ring is specifically factorised out with a different, inactive silicon
- Parameterised Model means changing parameters.xml allows quick changes to geometry including swapping in corrugated foil
Other Branches/MRs:
- Gauss: lhcb/Gauss!1030
- Conditions: lhcb-conddb/lhcb-conditions-database!115
- LHCb: lhcb/LHCb!4375
TODO:
- Decide on final pixel pitch, foil geometry & z positions of sensors - can maybe merge this already and make such changes in subsequent MRSim11/2024.03 (Gauss v60r1)Daniel JohnsonThomas LathamTimothy David EvansDan ThompsonDaniel Johnsonhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/459Draft: UP geometry added in compact/component and run5 LHCb.xml added2024-03-26T07:28:23+01:00Xuhao YuanDraft: UP geometry added in compact/component and run5 LHCb.xml added* New U2 UT added as the name of "UP"
* pixel chips modelled in compact/component/UP/trunk
* Geometry implemented in Detector/UP/src/UP_geo.cpp
* New channelID for HV CMOS modified in Detector/UP/include/Detector/UPChannelID.h
* Run with...* New U2 UT added as the name of "UP"
* pixel chips modelled in compact/component/UP/trunk
* Geometry implemented in Detector/UP/src/UP_geo.cpp
* New channelID for HV CMOS modified in Detector/UP/include/Detector/UPChannelID.h
* Run with LHCb with the new UPDet
* Run with Gauss to know the new detector.
TODO:
* Fix formatting failures in CI pipeline --done!
* Dummy conditions need to be added to lhcb-conditions-database to align with what is being pointed to in compact/components/trunk/UP/conditions.xml --done! with merge request lhcb-conddb/lhcb-conditions-database!112
Run with LHCb!4349 and Gauss!1022
---
Validated by
- [ ] Core Software
- [ ] RTA
- [ ] SimulationSim11/2024.03 (Gauss v60r1)Xuhao YuanShuqi ShengJi Pengpengji@ihep.ac.cnXuhao Yuanhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/463Draft: Future upgrade geometry for MightyPix2024-03-22T18:06:33+01:00Gary RobertsonDraft: Future upgrade geometry for MightyPix---
Starting to move things into place for the restructuring. This MR contains the correct restructuring, but the geometry files are outdated while we work on producing the conditions files. When these files are ready we will update the ...---
Starting to move things into place for the restructuring. This MR contains the correct restructuring, but the geometry files are outdated while we work on producing the conditions files. When these files are ready we will update the repository.
Validated by
- [ ] Core Software
- [ ] RTA
- [ ] SimulationSim11/2024.03 (Gauss v60r1)https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/470UT ChannelID to provide subsector and asic info2024-03-28T00:27:36+01:00Hangyi WuUT ChannelID to provide subsector and asic infoWork with https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4389 and https://gitlab.cern.ch/lhcb-conddb/lhcb-conditions-database/-/merge_requests/118
- Provide subsector information
- Fixed `sensorType` function bug. It should now provi...Work with https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4389 and https://gitlab.cern.ch/lhcb-conddb/lhcb-conditions-database/-/merge_requests/118
- Provide subsector information
- Fixed `sensorType` function bug. It should now provide the real type of sensors, i.e. ABCD, instead of sector types, i.e. Norm, Dual, Quad and Hole.
---
Validated by
- [x] Core Software
- [x] RTA
- [ ] SimulationRTA/2024.03.27Anfeng LiAnfeng Lihttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/471Draft: Multiple scattering in dd4hep2024-03-27T11:38:52+01:00Andrii UsachovDraft: Multiple scattering in dd4hepCompute material parameters that are needed for multiple scattering corrections.
Not yet ready, for discussion
Next steps
- [x] make a test returning the list of materials from dd4hep
- [x] compare the spread of particles from the part...Compute material parameters that are needed for multiple scattering corrections.
Not yet ready, for discussion
Next steps
- [x] make a test returning the list of materials from dd4hep
- [x] compare the spread of particles from the particle gun with what the extrapolator computes, and see what happens
@bcouturi @mveghel @dovombru @decianm
Goes with Rec!3686, related to https://gitlab.cern.ch/lhcb/Rec/-/issues/429
---
Validated by
- [ ] Core Software
- [ ] RTA
- [ ] Simulationhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/477Draft: Upating RICH with Rich1 mirror survey updates in January16-20242024-01-20T23:14:14+01:00Sajan EasoDraft: Upating RICH with Rich1 mirror survey updates in January16-2024
This contains the Rich1 Mirror survey updates for 2023 data, which may potentially
improve the resolutions seen in RICH1 in 2023. This branch is created
wrt the master version on Jan16-2024.
The updates for the survey parameters are cr...
This contains the Rich1 Mirror survey updates for 2023 data, which may potentially
improve the resolutions seen in RICH1 in 2023. This branch is created
wrt the master version on Jan16-2024.
The updates for the survey parameters are created in the trunk area. This will need the references updated and the new alignment parameters created in the conditions database, before making any tests.
A second issue is that, the RICH group would like to continue to
use the current version also, since the Rich1 alignments are created wrt this
version in 2023. For this, following earlier discussions last year,
I created a new folder named Rich_RUN3_v1_01092023 which has
the 'current master version' so that it can be kept frozen. However there is difficulty
in commiting this since it fails the check_path_xml.py although I tried to
update this also. It seems, this script works OK when it is run directly, but not when it is part of pre-commit checks. As a temporary measure
I deactivated the path.xml in this area until this issue is fixed.
---
Validated by
- [ ] Core Software
- [ ] RTA
- [ ] SimulationSebastien PonceBen CouturierSebastien Poncehttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/479draft: create tagged 2022 geometry2024-02-12T17:28:36+01:00Florian Reissdraft: create tagged 2022 geometryCreate a tagged version of the geometry used for processing the 2022 data in HLT2. The detector component xml files will be taken from Detector v1r19p1.
The goal is to have the ability to run the `master` branch of LHCb software with t...Create a tagged version of the geometry used for processing the 2022 data in HLT2. The detector component xml files will be taken from Detector v1r19p1.
The goal is to have the ability to run the `master` branch of LHCb software with the geometry which was used at the time.
Currently, only the VP is added to be able to discuss the chosen naming and if this approach makes sense. The plan is to add the equivalent for the other subdetectors.
The name is chosen to be `2022-v00.00`.
closes #49
If this is merged, the geometry probably should be used in at least a basic reconstruction test
Validated by
* [ ] Core Software
* [ ] RTA
* [ ] Simulation