Detector merge requestshttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests2024-03-19T14:04:05+01:00https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/475Draft: Update SciFi station VOL ID2024-03-19T14:04:05+01:00Zehua XuDraft: Update SciFi station VOL ID*add here a description of the proposed changes*
---
Validated by
- [ ] Core Software
- [ ] RTA
- [ ] Simulation*add here a description of the proposed changes*
---
Validated by
- [ ] Core Software
- [ ] RTA
- [ ] Simulationhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/502Draft: Create TV scenario X model(384 pixel matrix)2024-02-28T18:17:52+01:00Ganrong WangDraft: Create TV scenario X model(384 pixel matrix)- Make changes based on lhcb/Detector!457, change 256x256 -> 384x384, and the corresponding layout of Substrate and Hybrid
- compact/components/TV/trunk/parameters.xml
- compact/components/TV/trunk/visualization.xml
- Detector/TV/s...- Make changes based on lhcb/Detector!457, change 256x256 -> 384x384, and the corresponding layout of Substrate and Hybrid
- compact/components/TV/trunk/parameters.xml
- compact/components/TV/trunk/visualization.xml
- Detector/TV/src/DeTVSensor.cpp
- Detector/TV/include/Detector/TV/TVConstants.h
- Velo U2 "Scenario X" with:
- Pixel Size = 55um
- Inner radius = 7.2 mm
- Each chip made up of 384 x 384 pixels arranged into 2 rows of 3 chips
- Foil and Guard ring are inherited from [lhcb/Detector!457](https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/457):
- Foil is a cylinder of aluminium 75um thick with a radius of 3.5mm, with the same z-length as the current foil
- Guard ring is specifically factorised out with a different, inactive silicon
- Parameterised Model means changing parameters.xml allows quick changes to geometry including swapping in corrugated foil
Other Branches/MRs:
- Gauss: lhcb/Gauss!1030
- LHCb: lhcb/LHCb!4375
- Conditions: lhcb-conddb/lhcb-conditions-database!115
TODO:
- Check for better Substrate and Hybrid layoutsSim11/2024.03 (Gauss v60r1)Ganrong WangPeilian LiDan ThompsonGanrong Wanghttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/460Draft: ECAL Run4 and Run5 geometries2024-02-27T17:37:08+01:00Davide ZulianiDraft: ECAL Run4 and Run5 geometriesAdd Run4 and Run5 ECAL geometries!
TODO:
- [ ] modify `DeCalorimeter.cpp` and `DeCalorimeter.h` to properly match hits with cells
- [ ] find a "better" way to load modules' positions and rotations (so far done through `.txt` files)
- [ ...Add Run4 and Run5 ECAL geometries!
TODO:
- [ ] modify `DeCalorimeter.cpp` and `DeCalorimeter.h` to properly match hits with cells
- [ ] find a "better" way to load modules' positions and rotations (so far done through `.txt` files)
- [ ] run checks with Hybrid-MC framework used so far to simulate new ECAL geometries
- [ ] ...
---
Validated by
- [ ] Core Software
- [ ] RTA
- [ ] Simulation
Closing this MR, developments are in progress [here](https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/503)Philipp Gerhard RoloffMarco PizzichemiDavide ZulianiPhilipp Gerhard Roloffhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/464Draft: Add SciFi threshold scan processing2024-02-27T11:05:00+01:00Lukas WitolaDraft: Add SciFi threshold scan processingFixes methods to convert FTChannelID to hardware related IDs.Fixes methods to convert FTChannelID to hardware related IDs.Lukas WitolaLukas Witolahttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/386Draft: Muon dev geo fix2024-02-08T16:37:32+01:00Flavio Archilliflavio.archilli@cern.chDraft: Muon dev geo fixNew description of the muon detector.
---
Validated by
- [ ] Core Software
- [ ] RTA
- [ ] SimulationNew description of the muon detector.
---
Validated by
- [ ] Core Software
- [ ] RTA
- [ ] SimulationMarco Clemencicmarco.clemencic@cern.chBen CouturierFlavio Archilliflavio.archilli@cern.chMarco Clemencicmarco.clemencic@cern.chhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/439Fix CI job for formatting2024-01-25T18:04:02+01:00Rosen MatevFix CI job for formatting*add here a description of the proposed changes*
---
Validated by
- [x] Core Software
- [x] RTA
- [ ] Simulation*add here a description of the proposed changes*
---
Validated by
- [x] Core Software
- [x] RTA
- [ ] Simulationhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/465Draft: Switched GitLab CI to use LCG 1042024-01-25T09:36:55+01:00Ben CouturierDraft: Switched GitLab CI to use LCG 104Switched GitLab CI config to use LCG 104
Will need to be undrafted when lhcb-master switches to LCG 104
---
Validated by
- [x] Core Software
- [ ] RTA
- [ ] SimulationSwitched GitLab CI config to use LCG 104
Will need to be undrafted when lhcb-master switches to LCG 104
---
Validated by
- [x] Core Software
- [ ] RTA
- [ ] Simulationhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/443MR into dev branch: Fix test using muon_debug.xml2024-01-19T11:02:26+01:00Ben CouturierMR into dev branch: Fix test using muon_debug.xml
Fixes of muon_debug.xml into MuonDev_GeoFix.
Does not target master branch
Fixes of muon_debug.xml into MuonDev_GeoFix.
Does not target master branchFlavio Archilliflavio.archilli@cern.chFlavio Archilliflavio.archilli@cern.chhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/389Draft: compact geometry used for HLT2 2022 processing2024-01-17T11:55:40+01:00Florian ReissDraft: compact geometry used for HLT2 2022 processing* based on trunk geometry of v1r7
Some points to address:
- [ ] what needs to be updated?
- [ ] how to test this?* based on trunk geometry of v1r7
Some points to address:
- [ ] what needs to be updated?
- [ ] how to test this?https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/390Draft: Rich1 MirrorSurvey Update2024-01-16T18:41:54+01:00Sajan EasoDraft: Rich1 MirrorSurvey UpdateThe information from RICH1 mirror survey became available recently. They are included in this update. This is verified in simulation and the next step is to see if we get an improvement in RICH1 alignment from real data. Afterwards we sh...The information from RICH1 mirror survey became available recently. They are included in this update. This is verified in simulation and the next step is to see if we get an improvement in RICH1 alignment from real data. Afterwards we shall try to come up with a way to use this, in the light of the alignment updates already made in the conditions database. This version also fixes some minor overlaps in RICH1 that were discovered recently. For now this MR is kept as a draft.
---
Validated by
- [x] Core Software
- [ ] RTA
- [ ] SimulationBen CouturierBen Couturierhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/427FTChannelID: static_cast added and struct made private2024-01-12T11:47:03+01:00Oscar Rene Albert Buonoscar.buon@cern.chFTChannelID: static_cast added and struct made private`static_cast<unsigned int>` added line 80.
`to_ID_t` has been set `private` to avoid template implementation with non `unsigned int`.
---
Validated by
- [ ] Core Software
- [ ] RTA
- [ ] Simulation`static_cast<unsigned int>` added line 80.
`to_ID_t` has been set `private` to avoid template implementation with non `unsigned int`.
---
Validated by
- [ ] Core Software
- [ ] RTA
- [ ] SimulationSebastien PonceSebastien Poncehttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/112Fixed detector names to allow the constructors to work2023-11-28T11:04:28+01:00Ben CouturierFixed detector names to allow the constructors to workFixed detector names to allow the constructors to workFixed detector names to allow the constructors to workSajan EasoSajan Easohttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/441Draft: U2UT in DD4hep2023-10-31T09:25:58+01:00Ji Pengpengji@ihep.ac.cnDraft: U2UT in DD4hepU2UT in DD4hep runs in this branch successfully!
Modification includes:
(1) The new geometry of upgrade II UT detector has been added into trunk/
(2) The Detector/UT/UT_geo.cpp modified to match the chip-structure.
(3) The DeUT has been ...U2UT in DD4hep runs in this branch successfully!
Modification includes:
(1) The new geometry of upgrade II UT detector has been added into trunk/
(2) The Detector/UT/UT_geo.cpp modified to match the chip-structure.
(3) The DeUT has been upgraded for the new UT detector
(4) The UTChannelID redesigned, include the pixel IDs
The Detector project should be run with LHCb!4311Yiming LiBenjamin AudurierXuhao YuanJianchun WangShuqi ShengMingjie FengJi Pengpengji@ihep.ac.cnYiming Lihttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/438UThit position methods2023-10-13T14:57:46+02:00Hangyi WuUThit position methodsOne commit cherry-picked from https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/395 and adds accessibility to sensor types as required to work with https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4269, https://gitlab.cern.ch/lhcb/R...One commit cherry-picked from https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/395 and adds accessibility to sensor types as required to work with https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4269, https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3559 and https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2622.
---
Validated by
- [ ] Core Software
- [ ] RTA
- [ ] Simulationhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/447Draft: Fix UT test2023-10-13T14:53:43+02:00Hangyi WuDraft: Fix UT test*add here a description of the proposed changes*
One of the UT test sets requirement a bit too tight and doesn't allow the update of Alignment values in the `lhcb-conditions-database`.
---
Validated by
- [ ] Core Software
- [ ] RTA
- [ ...*add here a description of the proposed changes*
One of the UT test sets requirement a bit too tight and doesn't allow the update of Alignment values in the `lhcb-conditions-database`.
---
Validated by
- [ ] Core Software
- [ ] RTA
- [ ] SimulationHangyi WuHangyi Wuhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/419FT: Add fixed variable cluster format2023-10-12T11:12:56+02:00Louis Henrylouis.henry@cern.chFT: Add fixed variable cluster formatAdd helper quantities and rename some monitoring functions
---
Validated by
- [ ] Core Software
- [ ] RTA
- [ ] SimulationAdd helper quantities and rename some monitoring functions
---
Validated by
- [ ] Core Software
- [ ] RTA
- [ ] Simulationhttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/414add python script used to compare two ReadoutMaps2023-09-28T17:50:21+02:00Ya Zhaoadd python script used to compare two ReadoutMaps
---
Validated by
- [ ] Core Software
- [ ] RTA
- [ ] Simulation
---
Validated by
- [ ] Core Software
- [ ] RTA
- [ ] SimulationYa ZhaoYa Zhaohttps://gitlab.cern.ch/lhcb/Detector/-/merge_requests/351Draft: Structure for descriptors for future upgrades2023-08-07T14:38:00+02:00Ben CouturierDraft: Structure for descriptors for future upgradesStructure for descriptors for future upgrades,
I tried to keep the beam pipe and the Magnet only in the description.
The overall structure of the geometry description has to be reviewed to separate common parameters and to make the desc...Structure for descriptors for future upgrades,
I tried to keep the beam pipe and the Magnet only in the description.
The overall structure of the geometry description has to be reviewed to separate common parameters and to make the description more modular.https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/424Maybe uninitialized warning fixed2023-08-07T10:41:34+02:00Oscar Rene Albert Buonoscar.buon@cern.chMaybe uninitialized warning fixedFix for removing a maybe-uninitialized warning from a test.
The variables are actually defined but the compiler doesn't notice it.Fix for removing a maybe-uninitialized warning from a test.
The variables are actually defined but the compiler doesn't notice it.https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/348Draft: scifi api completeness2023-07-22T22:21:41+02:00Zehua XuDraft: scifi api completenessTo fix this issue: https://gitlab.cern.ch/lhcb/Detector/-/issues/33, used for geometry navigationTo fix this issue: https://gitlab.cern.ch/lhcb/Detector/-/issues/33, used for geometry navigation