LHCb merge requestshttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests2024-02-14T13:37:42+01:00https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4411Draft: Add inter-calibration2024-02-14T13:37:42+01:00Jean-Francois MarchandDraft: Add inter-calibrationAdd the possibility to inner calibrate.
Even/odd BXID will have different corrections.
Needs https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2844 and https://gitlab.cern.ch/lhcb-datapkg/ParamFiles/-/merge_requests/66Add the possibility to inner calibrate.
Even/odd BXID will have different corrections.
Needs https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2844 and https://gitlab.cern.ch/lhcb-datapkg/ParamFiles/-/merge_requests/66https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4339Small cleanups that speed up the Calo decoding2023-12-14T08:32:32+01:00Rosen MatevSmall cleanups that speed up the Calo decoding- Protect a verbose message in Calo decoding
- Avoid unnecessary copies of condition data
/cc @jmarchan- Protect a verbose message in Calo decoding
- Avoid unnecessary copies of condition data
/cc @jmarchanSebastien PonceSebastien Poncehttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4338Persistency for ChargedPID, BremInfo and GlobalChargedPID classes2024-03-25T11:47:43+01:00Tara Nanut PetricPersistency for ChargedPID, BremInfo and GlobalChargedPID classesAdds persistency of PID objects from calorimeter and global PID variables (CombDLL/ProbNN) (similar to RichPID, MuonPID, ...) to improve consistency and allow packing choices per variable/object (not being forced to use float/double on d...Adds persistency of PID objects from calorimeter and global PID variables (CombDLL/ProbNN) (similar to RichPID, MuonPID, ...) to improve consistency and allow packing choices per variable/object (not being forced to use float/double on disk/memory resp.; also no need to save keys (32 bit)).
Removes additionalInfo (which is filled from these objects anyway) for this info and improves consistency between NeutralPID objects and the ones here. With these changes, no more additionalInfo in the ProtoParticles is filled.
Needs https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3740 https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3149 https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1050 https://gitlab.cern.ch/lhcb/LHCbIntegrationTests/-/merge_requests/63RTA/2024.03.27Andre GuntherAnfeng LiAndre Guntherhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4313add plot for Links In Error2024-03-18T11:14:11+01:00Ricardo Vazquez Gomezadd plot for Links In Erroradd new plot for CaloMonitoring
can test with https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3614 https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2693 https://gitlab.cern.ch/lhcb/MooreOnline/-/merge_requests/290add new plot for CaloMonitoring
can test with https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3614 https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2693 https://gitlab.cern.ch/lhcb/MooreOnline/-/merge_requests/290Sebastien PonceAnfeng LiSebastien Poncehttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4268Fix unsafe comparison operators in Calo2023-09-18T12:45:12+02:00Jean-Francois MarchandFix unsafe comparison operators in CaloFix issues mentioned in https://gitlab.cern.ch/lhcb/LHCb/-/issues/326Fix issues mentioned in https://gitlab.cern.ch/lhcb/LHCb/-/issues/326https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4097Add NeutralPID object to ProtoParticle2024-01-26T11:50:40+01:00Tara Nanut PetricAdd NeutralPID object to ProtoParticleMake class for NeutralPID object, analogue to MuonPID, RichPID. It contains info previously stored in AdditionalInfo. Info filled in FutureNeutralProtoParticleAlg. Pointer to object stored in ProtoParticle. Additional info removed from n...Make class for NeutralPID object, analogue to MuonPID, RichPID. It contains info previously stored in AdditionalInfo. Info filled in FutureNeutralProtoParticleAlg. Pointer to object stored in ProtoParticle. Additional info removed from neutral ProtoParticles.
For old versions in saved files, the new NeutralPID object will be filled from existing Additional info.
Needs https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2252 .
Needs https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3397.
Needs https://gitlab.cern.ch/lhcb/LHCbIntegrationTests/-/merge_requests/54
Needs https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1012
The functors that used the Additional info are replaced to use the NeutralPID object in https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3397. This ensures testing since the functors are used in test lines.Rosen MatevChristopher Rob Jonesjonesc@hep.phy.cam.ac.ukRosen Matevhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3950Fix noBanksCounter in Calo decoding2023-02-20T09:55:31+01:00Carla Marin Benitocarla.marin.benito@cern.chFix noBanksCounter in Calo decodingBefore this, the code would `return` when finding empty banks with no other action (a debug message, hard to detect). Later on `m_noBanksCounter` was incremented by `banks.empty()` but for this line to execute, it had to be zero already!...Before this, the code would `return` when finding empty banks with no other action (a debug message, hard to detect). Later on `m_noBanksCounter` was incremented by `banks.empty()` but for this line to execute, it had to be zero already! So we were not incrementing the counter (and not printing it) when the banks were empty and on the contrary we were incrementing by 0 in each event and printing the counter when banks were NOT empty.
This MR promotes `m_noBanksCounter` to an `ERROR` message counter and fixes the logic (such that the counter is incremented and printed when the banks are empty and not incremented neither printed when they are not).
cc @jmarchan
References will need to be updated. The expected diff is the disappearing of the counters `"No bank found"` from `FutureEcalZSup` and `FutureHcalZSup`.
Goes with MooreOnline!201Rosen MatevRosen Matevhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3940Draft: Adding track-based calo cluster persistency2024-02-06T09:38:09+01:00Maarten Van VeghelDraft: Adding track-based calo cluster persistencyGoes with https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3288 and https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2021Goes with https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3288 and https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2021https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3913add track-cluster match info to neutral pp2023-02-03T23:31:21+01:00Maarten Van Vegheladd track-cluster match info to neutral ppRelated MRs (see there for more info): https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3255, https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/1977Related MRs (see there for more info): https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3255, https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/1977https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3894brem functors / wrappers2023-02-28T14:21:10+01:00Maarten Van Veghelbrem functors / wrappersAdds wrapper around Particle/Composite/ChargedBasic(?) used by functors to access brem-corrected variants of momenta / covariance functions.
See for more info: https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3233, goes with https://git...Adds wrapper around Particle/Composite/ChargedBasic(?) used by functors to access brem-corrected variants of momenta / covariance functions.
See for more info: https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3233, goes with https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2127 too.
Related (event model) issues: https://gitlab.cern.ch/lhcb/LHCb/-/issues/107Rosen MatevRosen Matevhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3884fix calo index bookkeeping2023-01-30T14:41:06+01:00Maarten Van Veghelfix calo index bookkeepingAssociated to https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3206, see for more info there.Associated to https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3206, see for more info there.https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3840Cleaning dataCodingType 12022-11-11T11:44:16+01:00Jean-Francois MarchandCleaning dataCodingType 1Cleaning of dataCodingType 1, since it was looping over a vector for only one elementCleaning of dataCodingType 1, since it was looping over a vector for only one elementJean-Francois MarchandJean-Francois Marchandhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3793Update data tag used for calo decoding test2022-09-28T01:17:04+02:00Christopher Rob Jonesjonesc@hep.phy.cam.ac.ukUpdate data tag used for calo decoding testAdapts to lhcb-datapkg/PRConfig!256Adapts to lhcb-datapkg/PRConfig!256https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3791Fix calo raw bank type2022-10-05T09:43:26+02:00Jean-Francois MarchandFix calo raw bank typeFix calo bank name to avoid any future confusion
Needs https://gitlab.cern.ch/lhcb/Boole/-/merge_requests/417Fix calo bank name to avoid any future confusion
Needs https://gitlab.cern.ch/lhcb/Boole/-/merge_requests/417Rosen MatevRosen Matevhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3790Draft: Change path of Ecal and Hcal in DeCalorimeter.h for DD4HEP2022-11-07T16:45:41+01:00Chenjia ZhangDraft: Change path of Ecal and Hcal in DeCalorimeter.h for DD4HEPChange path of Ecal and Hcal in DeCalorimeter.h for DD4HEPChange path of Ecal and Hcal in DeCalorimeter.h for DD4HEPhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3779Introduce VeloBackward and remove Calo track type2022-11-22T16:44:26+01:00Andrii UsachovIntroduce VeloBackward and remove Calo track typeFollows #256
Goes with Rec!3122 Alignment!314 Allen!1000 Panoramix!122
@wouter @decianm @graven @guntherFollows #256
Goes with Rec!3122 Alignment!314 Allen!1000 Panoramix!122
@wouter @decianm @graven @guntherhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3763add Epos in CalculateEXY return2022-09-19T13:24:57+02:00Nuria Valls Canudasadd Epos in CalculateEXY returnFollowing Moore!1549 and Rec!3109 there is a need to add another parameter to EXY structure to check for negative energy in case of energy computed for position when using cluster shapes.Following Moore!1549 and Rec!3109 there is a need to add another parameter to EXY structure to check for negative energy in case of energy computed for position when using cluster shapes.Miroslav Saurmiroslav.saur@cern.chNuria Valls CanudasMiroslav Saurmiroslav.saur@cern.chhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3758Add option to calibrate calo digits2022-10-03T22:58:49+02:00Jean-Francois MarchandAdd option to calibrate calo digitsAdd option to calibrate calo digits at the decoding level.
To be used by the pi0 calibration.
Also needs https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/275 for dd4hep compilation which needs https://gitlab.cern.ch/lhcb-conddb/lh...Add option to calibrate calo digits at the decoding level.
To be used by the pi0 calibration.
Also needs https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/275 for dd4hep compilation which needs https://gitlab.cern.ch/lhcb-conddb/lhcb-conditions-database/-/merge_requests/31Rosen MatevRosen Matevhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3755Use error counter instead of error message in CaloFuture2Dview2022-09-01T10:59:11+02:00Carla Marin Benitocarla.marin.benito@cern.chUse error counter instead of error message in CaloFuture2DviewUse error counter instead of error message in `CaloFuture2Dview` to avoid filling the error log with error messages (as reported in https://lblogbook.cern.ch/Shift/8204) if they reappear (the issue causing the error to be printed was a w...Use error counter instead of error message in `CaloFuture2Dview` to avoid filling the error log with error messages (as reported in https://lblogbook.cern.ch/Shift/8204) if they reappear (the issue causing the error to be printed was a wrong rebasing of https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3074 and has been fixed already there).Rosen MatevRosen Matevhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3751Remove CaloFutureMergeTAE2022-09-01T10:55:54+02:00Guanyue WanRemove CaloFutureMergeTAEThis MR removes CaloFutureMergeTAE.cpp, since there's no more usage of it. Suggested by @cmarinbe.This MR removes CaloFutureMergeTAE.cpp, since there's no more usage of it. Suggested by @cmarinbe.Rosen MatevRosen Matev