LHCb merge requestshttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests2024-03-27T16:52:44+01:00https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4383TEST of https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/35272024-03-27T16:52:44+01:00Simone CapelliTEST of https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3527To be tested with: https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/944 , https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3527 and https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4383/
Fixed method of MCParticle to return the goo...To be tested with: https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/944 , https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3527 and https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4383/
Fixed method of MCParticle to return the goodEndVertex, and adjusted the handling of some pointer objects.Simone CapelliSimone Capellihttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4262Draft: Add test to check that we fail when condition version is missing2024-02-05T17:26:23+01:00Rosen MatevDraft: Add test to check that we fail when condition version is missing~~I noticed that jobs don't fail when the conditions version is a nonexistent tag/branch. This is quite bad. I'm not even sure what conditions are used in this case. ~~
Correction: I gave a nonexistent tag/branch but at the same time I ...~~I noticed that jobs don't fail when the conditions version is a nonexistent tag/branch. This is quite bad. I'm not even sure what conditions are used in this case. ~~
Correction: I gave a nonexistent tag/branch but at the same time I had `ConditionsLocation = 'file://...` which means the `ConditionsVersion` value is irrelevant. However, the INFO printout still suggests it is used, which is very misleading. On top of this, as far as I can see, there is no printout of the value of `ConditionsVersion`.
I would suggest that we abort in case `ConditionsVersion` is specified when `ConditionsLocation = 'file://...`.
OTOH, when we have `ConditionsLocation = 'git://...` and supply an nonexistent tag, the job fails but it does so very late. We need an early failure with a clear message.
Here I add a draft of a test for the expected behaviour.
Note that there were recent changes in https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/422 which might have affected behaviour.
@sponce @bcouturi @clemenci