LHCb merge requestshttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests2020-09-07T15:40:23+02:00https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/2745Continuation of !2267 (Add Area accessor for calorimeter parts )2020-09-07T15:40:23+02:00Arthur Marius HennequinContinuation of !2267 (Add Area accessor for calorimeter parts )This is a continuation of !2267 (to address the issues pointed by the reviews)
The original branch is quite old so I rebased it on master.
Goes with https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2191
@sponce @graven @cmarinbe...This is a continuation of !2267 (to address the issues pointed by the reviews)
The original branch is quite old so I rebased it on master.
Goes with https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2191
@sponce @graven @cmarinbe @conrad https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/2977Remove CaloDAQ2022-06-13T12:21:37+02:00Jean-Francois MarchandRemove CaloDAQRemove CaloDataProviderFromTES, discussed in https://gitlab.cern.ch/lhcb-dpa/project/-/issues/8
Remove Calo/CaloDAQ
Needs some other changes in :
- https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2930
- https://gitlab.cern.ch/lhcb/Lbcom...Remove CaloDataProviderFromTES, discussed in https://gitlab.cern.ch/lhcb-dpa/project/-/issues/8
Remove Calo/CaloDAQ
Needs some other changes in :
- https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2930
- https://gitlab.cern.ch/lhcb/Lbcom/-/merge_requests/614
- https://gitlab.cern.ch/lhcb/Phys/-/merge_requests/949 (now merged)
- https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2458 : Add digit v2 to v1 converter, linked to changes in Lbcom and Boole, see next lines
- https://gitlab.cern.ch/lhcb/Lbcom/-/merge_requests/561 : Changes in CaloDigitMCTruth and CaloReCreateMCLinks
- https://gitlab.cern.ch/lhcb/Boole/-/merge_requests/341https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3092fix: prefer std::nearbyint over std::round to avoid gcc 10 perf regression2022-09-22T12:43:19+02:00Christoph Hassefix: prefer std::nearbyint over std::round to avoid gcc 10 perf regressionWhat a nice :rabbit2: :hole: to jump into :see_no_evil:
Especially since I could have saved a lot of time if only I remembered !1856 :face_palm:
We really should be adding `std::round` to the list of things we should flag in code...What a nice :rabbit2: :hole: to jump into :see_no_evil:
Especially since I could have saved a lot of time if only I remembered !1856 :face_palm:
We really should be adding `std::round` to the list of things we should flag in code review.
Local tests show a slight difference in counters, which is expected as the rounding behavior is a bit different.
Why didn't we run into this problem with gcc9 ?! Well, I can't find a single mention of `round` when looking at the `.so` with `objdump`.
No idea what smart tricks gcc9 played, but the `.so` from gcc10 had the `round` functions, so that's why we started paying for them.
fyi: @clemenci @cmarinbe @decianm @jonrob @rmatev @gligorovhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3350Move TMV Utils To LHCbMath Kernel2021-12-08T11:41:43+01:00Andre GuntherMove TMV Utils To LHCbMath KernelUnify the neural network implementation utility by moving it from Rec to LHCb. On the way, small changes are applied to allow the compiler to better optimise, which gives a small speed-up :sun_with_face:
/cc @graven @decianm
Goes wit...Unify the neural network implementation utility by moving it from Rec to LHCb. On the way, small changes are applied to allow the compiler to better optimise, which gives a small speed-up :sun_with_face:
/cc @graven @decianm
Goes with Rec!2641Rosen MatevAndre GuntherRosen Matevhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3363Draft: Change CaloCellID to denseIndex conversions to be SIMD friendly2024-02-02T18:18:30+01:00Arthur Marius HennequinDraft: Change CaloCellID to denseIndex conversions to be SIMD friendly@graven @cmarinbe @mveghel
* Avoid having too many `select()` (prefer boolean operations)
* Use power of two widths so we can avoid integer division (which doesn't exist for avx2)
* Use unsigned overflows to reduce the number of compar...@graven @cmarinbe @mveghel
* Avoid having too many `select()` (prefer boolean operations)
* Use power of two widths so we can avoid integer division (which doesn't exist for avx2)
* Use unsigned overflows to reduce the number of comparisons in validity check
* Use a substractive check instead of an additive one
For SIMD version of validity check see https://godbolt.org/z/5KeY9Wdhf
Goes with https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/2662Arthur Marius HennequinArthur Marius Hennequinhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3732Fix memory leak in SOADataVector2022-09-01T13:35:00+02:00Rosen MatevFix memory leak in SOADataVectorAfter
https://gitlab.cern.ch/lhcb/LHCb/-/commit/39bbdcfa939f03811d972672db8b135cc1f53f18#d62a986127971ff3446eb412bfeac683b78f0672_81_80
SOAData doesn't deallocate memory on destruction but instead that has to
be done explicitly. This cas...After
https://gitlab.cern.ch/lhcb/LHCb/-/commit/39bbdcfa939f03811d972672db8b135cc1f53f18#d62a986127971ff3446eb412bfeac683b78f0672_81_80
SOAData doesn't deallocate memory on destruction but instead that has to
be done explicitly. This case seems to have been missed.
Fixes MooreOnline#8
/cc @ahennequ @mstahl @sstahlRosen MatevRosen Matevhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3927RichHistoBase: Making histogram booking const and thread safe2023-01-19T10:26:57+01:00Christopher Rob Jonesjonesc@hep.phy.cam.ac.ukRichHistoBase: Making histogram booking const and thread safehttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3969Introduce EndUT state2023-04-17T08:10:33+02:00Andrii UsachovIntroduce EndUT stateNeeded for Rec!3310, goes with Allen!1160Needed for Rec!3310, goes with Allen!1160https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4050Utilities to create TCKs for HLT12023-07-03T17:44:27+02:00Roel AaijUtilities to create TCKs for HLT1The persistent format of TCKs in git repositories was defined as part of !3286. This MR adds the following to `hlttck_cdb_listkeys`:
- allow input to be read from stdin;
- allow import from JSON;
- allow export to JSON;
- write a manifes...The persistent format of TCKs in git repositories was defined as part of !3286. This MR adds the following to `hlttck_cdb_listkeys`:
- allow input to be read from stdin;
- allow import from JSON;
- allow export to JSON;
- write a manifest for a git repository;
- use `nlohmann::json` instead of custom `to_json` code;
- slightly change the format of git commit messages to contain only the metadata required to create a manifest;
- factor some of the code out into `HltServicesLib` so it can be used downstream to load configurations from git without running the executable;
- allow TCKs to be added to an existing repository.
The JSON that is used to import a configuration is expected to include a JSON manifest in the pre-existing format under the "manifest" key.
Needed for lhcb/Allen!1149 and lhcb/MooreOnline!212
Goes with Moore!2305RTA/2023.07.04https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4106generate meaningfull unique deterministic names for unpackers, decoders, fetc...2023-06-05T15:34:36+02:00Gerhard Ravengenerate meaningfull unique deterministic names for unpackers, decoders, fetchers, ...Avoid autogenerated names with a hash in them which can cause frivolous downstream changes. Instead, generate unique names based on the parameters of the functions which instantiate these algorithms making those names both unique and det...Avoid autogenerated names with a hash in them which can cause frivolous downstream changes. Instead, generate unique names based on the parameters of the functions which instantiate these algorithms making those names both unique and deterministic.
requires Analysis!981, Alignment!376, DaVinci!899Sebastien PonceSebastien Poncehttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4160MUON Decoding Update2023-09-05T23:04:07+02:00Alessia SattaMUON Decoding UpdateThese branch in addition to the merge https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/404 are needed
1. To access and use the Tell40Link condition,
2. To decode of special banks produced by muon Tell40 when a desyncronization is ...These branch in addition to the merge https://gitlab.cern.ch/lhcb/Detector/-/merge_requests/404 are needed
1. To access and use the Tell40Link condition,
2. To decode of special banks produced by muon Tell40 when a desyncronization is detected
Closes https://gitlab.cern.ch/lhcb/Rec/-/issues/487
Goes with https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2552RTA/2023.08.24Rosen MatevRosen Matevhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4167Add configuration for 2022/2023 (Cherry-pick from sim10-patches)2023-11-08T18:09:55+01:00Michal MazurekAdd configuration for 2022/2023 (Cherry-pick from sim10-patches)@gcorti @adavis @admorris
This allows us to use `DataType=2022` and `DataType=2023`. Cherry-picked from `sim10-patches`:
- https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3869
- https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3933...@gcorti @adavis @admorris
This allows us to use `DataType=2022` and `DataType=2023`. Cherry-picked from `sim10-patches`:
- https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3869
- https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/3933
Related to MR https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4161.
See OPG task https://gitlab.cern.ch/lhcb/opg/-/issues/8.Rosen MatevRosen Matevhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4203Suppress warning with gcc 12.12023-07-22T12:32:56+02:00Christopher Rob Jonesjonesc@hep.phy.cam.ac.ukSuppress warning with gcc 12.1Christopher Rob Jonesjonesc@hep.phy.cam.ac.ukChristopher Rob Jonesjonesc@hep.phy.cam.ac.ukhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4264Remove operator== for floats in simdwrapper2023-09-20T14:23:00+02:00Arthur Marius HennequinRemove operator== for floats in simdwrapperFixes https://gitlab.cern.ch/lhcb/LHCb/-/issues/324
Needs https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3554 https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2620
@sponceFixes https://gitlab.cern.ch/lhcb/LHCb/-/issues/324
Needs https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3554 https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2620
@sponcehttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4338Persistency for ChargedPID, BremInfo and GlobalChargedPID classes2024-03-25T11:47:43+01:00Tara Nanut PetricPersistency for ChargedPID, BremInfo and GlobalChargedPID classesAdds persistency of PID objects from calorimeter and global PID variables (CombDLL/ProbNN) (similar to RichPID, MuonPID, ...) to improve consistency and allow packing choices per variable/object (not being forced to use float/double on d...Adds persistency of PID objects from calorimeter and global PID variables (CombDLL/ProbNN) (similar to RichPID, MuonPID, ...) to improve consistency and allow packing choices per variable/object (not being forced to use float/double on disk/memory resp.; also no need to save keys (32 bit)).
Removes additionalInfo (which is filled from these objects anyway) for this info and improves consistency between NeutralPID objects and the ones here. With these changes, no more additionalInfo in the ProtoParticles is filled.
Needs https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3740 https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3149 https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1050 https://gitlab.cern.ch/lhcb/LHCbIntegrationTests/-/merge_requests/63RTA/2024.03.27Andre GuntherAnfeng LiAndre Guntherhttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4397Reduced precision of TestVDTMath to avoid fluctuations with platforms and com...2023-12-22T09:53:42+01:00Sebastien PonceReduced precision of TestVDTMath to avoid fluctuations with platforms and compilershttps://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4465RichUtils/AllocateCount.h: remove constraint that templated TYPE must have My...2024-03-21T20:29:46+01:00Christopher Rob Jonesjonesc@hep.phy.cam.ac.ukRichUtils/AllocateCount.h: remove constraint that templated TYPE must have MyName()RichUtils/AllocateCount.h: remove contraint that templated TYPE must have a MyName() member functionRichUtils/AllocateCount.h: remove contraint that templated TYPE must have a MyName() member function